CachedCurlRequestTest::testDeprecatedFunctions() - Code Metrics - onoi/http-request - Measure and Improve Code Quality continuously with Scrutinizer

CachedCurlRequestTest::testDeprecatedFunctions() A
last analyzed 2018-01-20 08:34 UTC

↳ Parent: CachedCurlRequestTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	21
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	21
rs	9.3142
c	0
b	0
f	0
cc	1
eloc	13
nc	1
nop	0

<?php

namespace Onoi\HttpRequest\Tests;

use Onoi\HttpRequest\CachedCurlRequest;

/**
 * @covers \Onoi\HttpRequest\CachedCurlRequest
 * @group onoi-http-request
 *
 * @license GNU GPL v2+
 * @since 1.0
 *
 * @author mwjames
 */
class CachedCurlRequestTest extends \PHPUnit_Framework_TestCase {

	public function testCanConstruct() {

		$cache = $this->getMockBuilder( '\Onoi\Cache\Cache' )
			->disableOriginalConstructor()
			->getMockForAbstractClass();

		$instance = new CachedCurlRequest( curl_init(), $cache );

		$this->assertInstanceOf(
			'\Onoi\HttpRequest\CurlRequest',
			$instance
		);

		$this->assertInstanceOf(
			'\Onoi\HttpRequest\CachedCurlRequest',
			$instance
		);
	}

	public function testExecuteForRepeatedRequest() {

		$cache = $this->getMockBuilder( '\Onoi\Cache\Cache' )
			->disableOriginalConstructor()
			->setMethods( array( 'contains', 'fetch' ) )
			->getMockForAbstractClass();

		$cache->expects( $this->once() )
			->method( 'contains' )
			->with( $this->equalTo( 'foo:onoi:http:39aa03567d7d983dab1f1bdc5dc75e84' ) )
			->will( $this->returnValue( true ) );

		$cache->expects( $this->once() )
			->method( 'fetch' )
			->will( $this->returnValue( 22 ) );

		$instance = new CachedCurlRequest( curl_init(), $cache );

		$instance->setCachePrefix( 'foo:' );

		$instance->setOption( CURLOPT_RETURNTRANSFER, true );

		$this->assertEquals(
			22,
			$instance->execute()
		);

		$this->assertTrue(
			$instance->isCached()

		);
	}

	public function testDifferentOptionsToGenerateDifferentKeys() {

		$cache = $this->getMockBuilder( '\Onoi\Cache\Cache' )
			->disableOriginalConstructor()
			->setMethods( array( 'contains' ) )
			->getMockForAbstractClass();

		$cache->expects( $this->at( 0 ) )
			->method( 'contains' )
			->with( $this->equalTo( 'onoi:http:7ccbcfd552a597d67077d6cc037580ac' ) );

		$cache->expects( $this->at( 1 ) )
			->method( 'contains' )
			->with( $this->equalTo( 'onoi:http:e2015ad4244c4663f10f305e299d5c4f' ) );

		$instance = new CachedCurlRequest( curl_init(), $cache );

		$instance->setOption( CURLOPT_RETURNTRANSFER, true );
		$instance->execute();

		$instance->setOption( CURLOPT_RETURNTRANSFER, false );
		$instance->execute();
	}

	public function testToHaveTargetUrlAsPartOfTheCacheKey() {

		$cache = $this->getMockBuilder( '\Onoi\Cache\Cache' )
			->disableOriginalConstructor()
			->setMethods( array( 'contains', 'save' ) )
			->getMockForAbstractClass();

		$cache->expects( $this->at( 0 ) )
			->method( 'contains' )
			->with( $this->equalTo( 'onoi:http:236b194825be3d614ce5fc1b7763a278' ) );

		$cache->expects( $this->at( 2 ) )
			->method( 'contains' )
			->with( $this->equalTo( 'onoi:http:823a603f972819c10d13f32b14460573' ) );

		$instance = new CachedCurlRequest( curl_init( 'http://example.org' ), $cache );

		$instance->setOption( CURLOPT_RETURNTRANSFER, true );
		$instance->execute();

		$instance->setOption( CURLOPT_RETURNTRANSFER, true );
		$instance->setOption( CURLOPT_URL, 'http://example.org' );
		$instance->execute();
	}

	public function testSaveResponse() {

		$cache = $this->getMockBuilder( '\Onoi\Cache\Cache' )
			->disableOriginalConstructor()
			->setMethods( array( 'save', 'contains' ) )
			->getMockForAbstractClass();

		$cache->expects( $this->once() )
			->method( 'save' )
			->with(
				$this->equalTo( 'foo:onoi:http:b87e897ea862a410aff82e3122e2d955' ),
				$this->anything(),
				$this->equalTo( 42 ) );

		$instance = new CachedCurlRequest(
			curl_init(),
			$cache
		);

		$instance->setOption( ONOI_HTTP_REQUEST_RESPONSECACHE_TTL, 42 );
		$instance->setOption( ONOI_HTTP_REQUEST_RESPONSECACHE_PREFIX, 'foo:' );

		$instance->setOption( CURLOPT_URL, 'http://example.org' );
		$instance->setOption( CURLOPT_RETURNTRANSFER, true );

		$instance->execute();
	}

	public function testDefinedConstants() {

		$cache = $this->getMockBuilder( '\Onoi\Cache\Cache' )
			->disableOriginalConstructor()
			->getMockForAbstractClass();

		$constants = array(
			'ONOI_HTTP_REQUEST_RESPONSECACHE_PREFIX',
			'ONOI_HTTP_REQUEST_RESPONSECACHE_TTL'
		);

		$instance = new CachedCurlRequest( curl_init(), $cache );
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

		foreach ( $constants as $constant ) {
			$this->assertTrue( defined( $constant ) );
		}
	}

	public function testDeprecatedFunctions() {

		$cache = $this->getMockBuilder( '\Onoi\Cache\Cache' )
			->disableOriginalConstructor()
			->getMockForAbstractClass();

		$instance = new CachedCurlRequest( curl_init(), $cache );

		$instance->setExpiryInSeconds( 42 );

		$instance->setCachePrefix( 'Foo' );


		$this->assertEquals(
			42,
			$instance->getOption( ONOI_HTTP_REQUEST_RESPONSECACHE_TTL )
		);

		$this->assertEquals(
			'Foo',
			$instance->getOption( ONOI_HTTP_REQUEST_RESPONSECACHE_PREFIX )
		);
	}

}


1			<?php
2
3			namespace Onoi\HttpRequest\Tests;
4
5			use Onoi\HttpRequest\CachedCurlRequest;
6
7			/**
8			* @covers \Onoi\HttpRequest\CachedCurlRequest
9			* @group onoi-http-request
10			*
11			* @license GNU GPL v2+
12			* @since 1.0
13			*
14			* @author mwjames
15			*/
16			class CachedCurlRequestTest extends \PHPUnit_Framework_TestCase {
17
18			public function testCanConstruct() {
19
20			$cache = $this->getMockBuilder( '\Onoi\Cache\Cache' )
21			->disableOriginalConstructor()
22			->getMockForAbstractClass();
23
24			$instance = new CachedCurlRequest( curl_init(), $cache );
25
26			$this->assertInstanceOf(
27			'\Onoi\HttpRequest\CurlRequest',
28			$instance
29			);
30
31			$this->assertInstanceOf(
32			'\Onoi\HttpRequest\CachedCurlRequest',
33			$instance
34			);
35			}
36
37			public function testExecuteForRepeatedRequest() {
38
39			$cache = $this->getMockBuilder( '\Onoi\Cache\Cache' )
40			->disableOriginalConstructor()
41			->setMethods( array( 'contains', 'fetch' ) )
42			->getMockForAbstractClass();
43
44			$cache->expects( $this->once() )
45			->method( 'contains' )
46			->with( $this->equalTo( 'foo:onoi:http:39aa03567d7d983dab1f1bdc5dc75e84' ) )
47			->will( $this->returnValue( true ) );
48
49			$cache->expects( $this->once() )
50			->method( 'fetch' )
51			->will( $this->returnValue( 22 ) );
52
53			$instance = new CachedCurlRequest( curl_init(), $cache );
54
55			$instance->setCachePrefix( 'foo:' );
			0 ignored issues – show Deprecated Code introduced 2015-11-23 12:05 UTC by Report Bug Copy Issue Report The method `Onoi\HttpRequest\CachedC...quest::setCachePrefix()` has been deprecated with message: since 1.3, use option ONOI_HTTP_REQUEST_RESPONSECACHE_PREFIX instead This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
56			$instance->setOption( CURLOPT_RETURNTRANSFER, true );
57
58			$this->assertEquals(
59			22,
60			$instance->execute()
61			);
62
63			$this->assertTrue(
64			$instance->isCached()
			0 ignored issues – show Deprecated Code introduced 2015-11-23 12:05 UTC by Report Bug Copy Issue Report The method `Onoi\HttpRequest\CachedCurlRequest::isCached()` has been deprecated with message: since 1.3, use CachedCurlRequest::isFromCache instead This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
65			);
66			}
67
68			public function testDifferentOptionsToGenerateDifferentKeys() {
69
70			$cache = $this->getMockBuilder( '\Onoi\Cache\Cache' )
71			->disableOriginalConstructor()
72			->setMethods( array( 'contains' ) )
73			->getMockForAbstractClass();
74
75			$cache->expects( $this->at( 0 ) )
76			->method( 'contains' )
77			->with( $this->equalTo( 'onoi:http:7ccbcfd552a597d67077d6cc037580ac' ) );
78
79			$cache->expects( $this->at( 1 ) )
80			->method( 'contains' )
81			->with( $this->equalTo( 'onoi:http:e2015ad4244c4663f10f305e299d5c4f' ) );
82
83			$instance = new CachedCurlRequest( curl_init(), $cache );
84
85			$instance->setOption( CURLOPT_RETURNTRANSFER, true );
86			$instance->execute();
87
88			$instance->setOption( CURLOPT_RETURNTRANSFER, false );
89			$instance->execute();
90			}
91
92			public function testToHaveTargetUrlAsPartOfTheCacheKey() {
93
94			$cache = $this->getMockBuilder( '\Onoi\Cache\Cache' )
95			->disableOriginalConstructor()
96			->setMethods( array( 'contains', 'save' ) )
97			->getMockForAbstractClass();
98
99			$cache->expects( $this->at( 0 ) )
100			->method( 'contains' )
101			->with( $this->equalTo( 'onoi:http:236b194825be3d614ce5fc1b7763a278' ) );
102
103			$cache->expects( $this->at( 2 ) )
104			->method( 'contains' )
105			->with( $this->equalTo( 'onoi:http:823a603f972819c10d13f32b14460573' ) );
106
107			$instance = new CachedCurlRequest( curl_init( 'http://example.org' ), $cache );
108
109			$instance->setOption( CURLOPT_RETURNTRANSFER, true );
110			$instance->execute();
111
112			$instance->setOption( CURLOPT_RETURNTRANSFER, true );
113			$instance->setOption( CURLOPT_URL, 'http://example.org' );
114			$instance->execute();
115			}
116
117			public function testSaveResponse() {
118
119			$cache = $this->getMockBuilder( '\Onoi\Cache\Cache' )
120			->disableOriginalConstructor()
121			->setMethods( array( 'save', 'contains' ) )
122			->getMockForAbstractClass();
123
124			$cache->expects( $this->once() )
125			->method( 'save' )
126			->with(
127			$this->equalTo( 'foo:onoi:http:b87e897ea862a410aff82e3122e2d955' ),
128			$this->anything(),
129			$this->equalTo( 42 ) );
130
131			$instance = new CachedCurlRequest(
132			curl_init(),
133			$cache
134			);
135
136			$instance->setOption( ONOI_HTTP_REQUEST_RESPONSECACHE_TTL, 42 );
137			$instance->setOption( ONOI_HTTP_REQUEST_RESPONSECACHE_PREFIX, 'foo:' );
138
139			$instance->setOption( CURLOPT_URL, 'http://example.org' );
140			$instance->setOption( CURLOPT_RETURNTRANSFER, true );
141
142			$instance->execute();
143			}
144
145			public function testDefinedConstants() {
146
147			$cache = $this->getMockBuilder( '\Onoi\Cache\Cache' )
148			->disableOriginalConstructor()
149			->getMockForAbstractClass();
150
151			$constants = array(
152			'ONOI_HTTP_REQUEST_RESPONSECACHE_PREFIX',
153			'ONOI_HTTP_REQUEST_RESPONSECACHE_TTL'
154			);
155
156			$instance = new CachedCurlRequest( curl_init(), $cache );
			0 ignored issues – show Unused Code introduced 2015-11-23 12:05 UTC by Report Bug Copy Issue Report `$instance` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
157
158			foreach ( $constants as $constant ) {
159			$this->assertTrue( defined( $constant ) );
160			}
161			}
162
163			public function testDeprecatedFunctions() {
164
165			$cache = $this->getMockBuilder( '\Onoi\Cache\Cache' )
166			->disableOriginalConstructor()
167			->getMockForAbstractClass();
168
169			$instance = new CachedCurlRequest( curl_init(), $cache );
170
171			$instance->setExpiryInSeconds( 42 );
			0 ignored issues – show Deprecated Code introduced 2015-11-23 14:06 UTC by Report Bug Copy Issue Report The method `Onoi\HttpRequest\CachedC...t::setExpiryInSeconds()` has been deprecated with message: since 1.3, use option ONOI_HTTP_REQUEST_RESPONSECACHE_TTL instead This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
172			$instance->setCachePrefix( 'Foo' );
			0 ignored issues – show Deprecated Code introduced 2015-11-23 14:06 UTC by Report Bug Copy Issue Report The method `Onoi\HttpRequest\CachedC...quest::setCachePrefix()` has been deprecated with message: since 1.3, use option ONOI_HTTP_REQUEST_RESPONSECACHE_PREFIX instead This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
173
174			$this->assertEquals(
175			42,
176			$instance->getOption( ONOI_HTTP_REQUEST_RESPONSECACHE_TTL )
177			);
178
179			$this->assertEquals(
180			'Foo',
181			$instance->getOption( ONOI_HTTP_REQUEST_RESPONSECACHE_PREFIX )
182			);
183			}
184
185			}
186

onoi / http-request

CachedCurlRequestTest::testDeprecatedFunctions() A last analyzed 2018-01-20 08:34 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

CachedCurlRequestTest::testDeprecatedFunctions() A
last analyzed 2018-01-20 08:34 UTC