RpcResultObject::getResult() - Code Metrics - Inspection of "NEW_VERSION dev" - onnov/json-rpc-server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#2)

by Sergey

created 2021-01-08 20:22 UTC

RpcResultObject::getResult() A

↳ Parent: RpcResultObject

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	1
c	1
b	0
f	0
dl	0
loc	3
ccs	0
cts	2
cp	0
rs	10
cc	1
nc	1
nop	0
crap	2

<?php

/**
 * Created by PhpStorm.
 * Project: json-rpc-server
 * User: sv
 * Date: 06.01.2021
 * Time: 22:00
 */

declare(strict_types=1);

namespace Onnov\JsonRpcServer\Model;

use stdClass;

/**
 * Class RpcResultObject
 * @package Onnov\JsonRpcServer\Model
 */
class RpcResultObject extends RpcResultAbstract
{
    /**
     * RpcResultArray constructor.
     * @param stdClass $result
     */
    public function __construct(stdClass $result)
    {
        $this->result = $result;
    }

    /**
     * @return stdClass
     */
    public function getResult(): stdClass
    {
        return $this->result;

    }
}


1			<?php
2
3			/**
4			* Created by PhpStorm.
5			* Project: json-rpc-server
6			* User: sv
7			* Date: 06.01.2021
8			* Time: 22:00
9			*/
10
11			declare(strict_types=1);
12
13			namespace Onnov\JsonRpcServer\Model;
14
15			use stdClass;
16
17			/**
18			* Class RpcResultObject
19			* @package Onnov\JsonRpcServer\Model
20			*/
21			class RpcResultObject extends RpcResultAbstract
22			{
23			/**
24			* RpcResultArray constructor.
25			* @param stdClass $result
26			*/
27			public function __construct(stdClass $result)
28			{
29			$this->result = $result;
30			}
31
32			/**
33			* @return stdClass
34			*/
35			public function getResult(): stdClass
36			{
37			return $this->result;
			0 ignored issues – show Bug Best Practice introduced 2021-01-06 19:14 UTC by Report Bug Copy Issue Report The expression `return $this->result` could return the type `null` which is incompatible with the type-hinted return `stdClass`. Consider adding an additional type-check to rule them out. Loading history...
38			}
39			}
40

onnov / json-rpc-server

Pull Request — master (#2)

RpcResultObject::getResult() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like