NetAddressValidator - Code Metrics - Inspection of "Some fixes" - onixsib/yii2-net-address-validators - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 915dc2...1c41bf )

by onixsib

created 2016-08-22 11:35 UTC

NetAddressValidator A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	5
Bugs	2	Features	0

Metric	Value
wmc	8
c	5
b	2
f	0
lcom	1
cbo	2
dl	0
loc	31
rs	10

3 Methods

Rating	Name	Size	Complexity
A	init()	6	2
A	validateAttribute()	8	2
A	validateValue()	10	4

<?php
/**
 * @author: onixsib <[email protected]>
 * @date:   03.08.2016
 * @copyright onixsib
 * @link http://onixsib.ru/
 * @file NetAddressValidator
 */

namespace onixsib\validators;

use Yii;
use yii\validators\Validator;

/**
 * Class NetAddressValidator
 */
class NetAddressValidator extends Validator {
	/**
	 * @inheritdoc
	 */
	public function init() {
		parent::init();
		if ($this->message === null) {
			$this->message = \Yii::t('yii', "{attribute} is invalid.");
		}
	}

	public function validateAttribute($model, $attribute) {
		$string = $model->{$attribute};
		if (!$this->validateValue($string)) {
			$this->addError($model, $attribute, \Yii::t('yii', 'This in not valid network address any family'));
			return false;
		}
		return true;
	}

	public function validateValue($string) {

// filter_var suxx
		if ((!preg_match('/^((2[0-4]|1\d|[1-9])?\d|25[0-5])(\.(?1)){3}\z/', $string)) &&
			(!preg_match('/^(((?=(?>.*?(::))(?!.+\3)))\3?|([\dA-F]{1,4}(\3|:(?!$)|$)|\2))(?4){5}((?4){2}|((2[0-4]|1\d|[1-9])?\d|25[0-5])(\.(?7)){3})\z/i', $string)) &&
			(!preg_match('/^([0-9a-F]{1,2}[\.:-]){5}([0-9a-F]{1,2})$/', $string))) {
			return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
		}
		return true;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
	}
}

?>


1			<?php
2			/**
3			* @author: onixsib <[email protected]>
4			* @date: 03.08.2016
5			* @copyright onixsib
6			* @link http://onixsib.ru/
7			* @file NetAddressValidator
8			*/
9
10			namespace onixsib\validators;
11
12			use Yii;
13			use yii\validators\Validator;
14
15			/**
16			* Class NetAddressValidator
17			*/
18			class NetAddressValidator extends Validator {
19			/**
20			* @inheritdoc
21			*/
22			public function init() {
23			parent::init();
24			if ($this->message === null) {
25			$this->message = \Yii::t('yii', "{attribute} is invalid.");
26			}
27			}
28
29			public function validateAttribute($model, $attribute) {
30			$string = $model->{$attribute};
31			if (!$this->validateValue($string)) {
32			$this->addError($model, $attribute, \Yii::t('yii', 'This in not valid network address any family'));
33			return false;
34			}
35			return true;
36			}
37
38			public function validateValue($string) {
39
40			// filter_var suxx
41			if ((!preg_match('/^((2[0-4]\|1\d\|[1-9])?\d\|25[0-5])(\.(?1)){3}\z/', $string)) &&
42			(!preg_match('/^(((?=(?>.*?(::))(?!.+\3)))\3?\|([\dA-F]{1,4}(\3\|:(?!$)\|$)\|\2))(?4){5}((?4){2}\|((2[0-4]\|1\d\|[1-9])?\d\|25[0-5])(\.(?7)){3})\z/i', $string)) &&
43			(!preg_match('/^([0-9a-F]{1,2}[\.:-]){5}([0-9a-F]{1,2})$/', $string))) {
44			return false;
			0 ignored issues – show Bug Best Practice introduced 2016-08-22 11:38 UTC by Report Bug Copy Issue Report The return type of `return false;` (`false`) is incompatible with the return type of the parent method `yii\validators\Validator::validateValue` of type `array\|null`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
45			}
46			return true;
			0 ignored issues – show Bug Best Practice introduced 2016-08-22 11:38 UTC by Report Bug Copy Issue Report The return type of `return true;` (`boolean`) is incompatible with the return type of the parent method `yii\validators\Validator::validateValue` of type `array\|null`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
47			}
48			}
49
50			?>
			0 ignored issues – show Best Practice introduced 2016-08-07 19:27 UTC by Report Bug Copy Issue Report It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...

onixsib / yii2-net-address-validators

Push — master ( 915dc2...1c41bf )

NetAddressValidator A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like