IPv46Validator - Code Metrics - Inspection of "readme.md + bug fix" - onixsib/yii2-net-address-validators - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f58c94...97f1eb )

by onixsib

created 2016-08-07 19:55 UTC

IPv46Validator A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	20
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	4
lcom	1
cbo	2
dl	20
loc	20
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	6	6	2
A	validateAttribute()	8	8	2

How to fix Duplicated Code

<?php
/**
 * @author: onixsib <[email protected]>
 * @date:   03.08.2016
 * @copyright onixsib
 * @link http://onixsib.ru/
 * @file IPv6Validator
 */
namespace onixsib\validators;

use Yii;
use yii\validators\Validator;

/**
 * Class IPv46Validator
 */
class IPv46Validator extends Validator {

	/**
	 * @inheritdoc
	 */
	public function init() {
		parent::init();
		if ($this->message === null) {
			$this->message = Yii::t('yii', "{attribute} is invalid.");
		}
	}

	public function validateAttribute($model, $attribute) {
		$string = $model->{$attribute};

		// filter_var suxx
		if (!preg_match('/^(((?=(?>.*?(::))(?!.+\3)))\3?|([\dA-F]{1,4}(\3|:(?!$)|$)|\2))(?4){5}((?4){2}|((2[0-4]|1\d|[1-9])?\d|25[0-5])(\.(?7)){3})\z/i', $string)) {
			$this->addError($model, $attribute, Yii::t('yii', 'This in not valid IPv6 address {sample}', ['sample' => '::1']));
		}
	}
}

?>


1		<?php
2		/**
3		* @author: onixsib <[email protected]>
4		* @date: 03.08.2016
5		* @copyright onixsib
6		* @link http://onixsib.ru/
7		* @file IPv6Validator
8		*/
9		namespace onixsib\validators;
10
11		use Yii;
12		use yii\validators\Validator;
13
14		/**
15		* Class IPv46Validator
16		*/
17	View Code Duplication	class IPv46Validator extends Validator {
		0 ignored issues – show Duplication introduced 2016-08-07 19:27 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
18		/**
19		* @inheritdoc
20		*/
21		public function init() {
22		parent::init();
23		if ($this->message === null) {
24		$this->message = Yii::t('yii', "{attribute} is invalid.");
25		}
26		}
27
28		public function validateAttribute($model, $attribute) {
29		$string = $model->{$attribute};
30
31		// filter_var suxx
32		if (!preg_match('/^(((?=(?>.*?(::))(?!.+\3)))\3?\|([\dA-F]{1,4}(\3\|:(?!$)\|$)\|\2))(?4){5}((?4){2}\|((2[0-4]\|1\d\|[1-9])?\d\|25[0-5])(\.(?7)){3})\z/i', $string)) {
33		$this->addError($model, $attribute, Yii::t('yii', 'This in not valid IPv6 address {sample}', ['sample' => '::1']));
34		}
35		}
36		}
37
38		?>
		0 ignored issues – show Best Practice introduced 2016-08-07 19:27 UTC by Report Bug Copy Issue Report It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...

onixsib / yii2-net-address-validators

Push — master ( f58c94...97f1eb )

IPv46Validator A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like