Issues in Environment.php - Fixed Issues - Inspection of "Fix some phpmd checks" - onigoetz/deployer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 899e21...c16ad5 )

by Stéphane

created 2016-01-01 16:17 UTC

src/Configuration/Environment.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Onigoetz\Deployer\Configuration;

use Onigoetz\Deployer\Configuration\Containers\ConfigurationContainer;

class Environment extends ConfigurationContainer
{
    /**
     * Find if there are some overrides for a configuration
     *
     * @param string $key
     * @return bool
     */
    protected function hasOverrides($key)
    {
        if (array_key_exists('overrides', $this->data) && array_key_exists($key, $this->data['overrides'])) {
            return true;
        }

        return false;
    }

    public function getSource()
    {
        $source = $this->getValueOrFail('source', 'no source specified');

        $resolved_source = $this->manager->get('source', $source);

        if (!$this->hasOverrides('source')) {
            return $resolved_source;
        }

        return Source::make('override', $this->data['overrides']['source'], $this->manager, $resolved_source);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function getServers()
    {
        $servers = $this->getValueOrFail('servers', 'no servers specified');

        $resolved_servers = [];
        foreach ($servers as $server) {
            $resolved_servers[] = $this->manager->get('server', $server);
        }

        return $resolved_servers;
    }

    public function getDirectories()
    {
        $directories = $this->manager->getDefaultDirectories();

        if (!$this->hasOverrides('directories')) {
            return $directories;
        }

        return new Directories('overriden', $this->data['overrides']['directories'], $this->manager, $directories);
    }

    public function getTasks($event)
    {
        $tasks = $this->getValueOrDefault('tasks', []);

        if (!array_key_exists($event, $tasks)) {
            return [];
        }

        $groups = $tasks[$event];
        $actions = [];

        foreach ($groups as $group) {
            /**
             * @var Tasks
             */
            $items = $this->manager->get('tasks', $group);
            foreach ($items->getTasks() as $name => $action) {
                if (is_numeric($name)) {
                    $actions[] = $action;
                } else {
                    $actions[$name] = $action;
                }
            }
        }

        return $actions;
    }

    /**
     * {@inheritdoc}
     */
    public function checkValidity()
    {
        if (!$this->getSource()->isValid()) {
            return false;
        }

        if (!$this->getDirectories()->isValid()) {
            return false;
        }

        /**
         * @var Server
         */
        foreach ($this->getServers() as $server) {
            if (!$server->isValid()) {
                return false;
            }
        }

        return true;
    }

    public function getSubstitutions($binary)
    {
        return [
            '{{root}}' => $this->getDirectories()->getRoot(),
            '{{binaries}}' => $this->getDirectories()->getBinaries(),
            '{{binary}}' => $binary,
            '{{deploy}}' => $this->getDirectories()->getDeploy(),
            '{{environment}}' => $this->name,
        ];
    }
}


1		<?php
2
3		namespace Onigoetz\Deployer\Configuration;
4
5		use Onigoetz\Deployer\Configuration\Containers\ConfigurationContainer;
6
7		class Environment extends ConfigurationContainer
8		{
9		/**
10		* Find if there are some overrides for a configuration
11		*
12		* @param string $key
13		* @return bool
14		*/
15	27	protected function hasOverrides($key)
16		{
17	27	if (array_key_exists('overrides', $this->data) && array_key_exists($key, $this->data['overrides'])) {
18	9	return true;
19		}
20
21	21	return false;
22		}
23
24	27	public function getSource()
25		{
26	27	$source = $this->getValueOrFail('source', 'no source specified');
27
28	24	$resolved_source = $this->manager->get('source', $source);
29
30	21	if (!$this->hasOverrides('source')) {
31	15	return $resolved_source;
32		}
33
34	6	return Source::make('override', $this->data['overrides']['source'], $this->manager, $resolved_source);
		0 ignored issues – show Documentation introduced 2016-01-01 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$resolved_source` is of type `object<Onigoetz\Deployer...ConfigurationContainer>`, but the function expects a `null\|object<Onigoetz\Dep...r\Configuration\Source>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
35		}
36
37	15	public function getServers()
38		{
39	15	$servers = $this->getValueOrFail('servers', 'no servers specified');
40
41	15	$resolved_servers = [];
42	15	foreach ($servers as $server) {
43	15	$resolved_servers[] = $this->manager->get('server', $server);
44	10	}
45
46	15	return $resolved_servers;
47		}
48
49	21	public function getDirectories()
50		{
51	21	$directories = $this->manager->getDefaultDirectories();
52
53	21	if (!$this->hasOverrides('directories')) {
54	18	return $directories;
55		}
56
57	6	return new Directories('overriden', $this->data['overrides']['directories'], $this->manager, $directories);
58		}
59
60	12	public function getTasks($event)
61		{
62	12	$tasks = $this->getValueOrDefault('tasks', []);
63
64	12	if (!array_key_exists($event, $tasks)) {
65	3	return [];
66		}
67
68	9	$groups = $tasks[$event];
69	9	$actions = [];
70
71	9	foreach ($groups as $group) {
72		/**
73		* @var Tasks
74		*/
75	9	$items = $this->manager->get('tasks', $group);
76	9	foreach ($items->getTasks() as $name => $action) {
77	9	if (is_numeric($name)) {
78	6	$actions[] = $action;
79	4	} else {
80	5	$actions[$name] = $action;
81		}
82	6	}
83	6	}
84
85	9	return $actions;
86		}
87
88		/**
89		* {@inheritdoc}
90		*/
91	24	public function checkValidity()
92		{
93	24	if (!$this->getSource()->isValid()) {
94	3	return false;
95		}
96
97	15	if (!$this->getDirectories()->isValid()) {
98	3	return false;
99		}
100
101		/**
102		* @var Server
103		*/
104	12	foreach ($this->getServers() as $server) {
105	12	if (!$server->isValid()) {
106	6	return false;
107		}
108	6	}
109
110	9	return true;
111		}
112
113	3	public function getSubstitutions($binary)
114		{
115		return [
116	3	'{{root}}' => $this->getDirectories()->getRoot(),
117	3	'{{binaries}}' => $this->getDirectories()->getBinaries(),
118	3	'{{binary}}' => $binary,
119	3	'{{deploy}}' => $this->getDirectories()->getDeploy(),
120	3	'{{environment}}' => $this->name,
121	2	];
122		}
123		}
124

onigoetz / deployer

Push — master ( 899e21...c16ad5 )

src/Configuration/Environment.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like