Git::cloneCommand() - Code Metrics - onigoetz/deployer - Measure and Improve Code Quality continuously with Scrutinizer

Git::cloneCommand() A
last analyzed 2016-01-02 20:10 UTC

↳ Parent: Git

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	3
Bugs	1	Features	0

Metric	Value
c	3
b	1
f	0
dl	0
loc	14
ccs	0
cts	11
cp	0
rs	9.4286
cc	2
eloc	8
nc	2
nop	3
crap	6

<?php

namespace Onigoetz\Deployer\SCM;

class Git extends SCM
{
    public function getCommand(\Net_SFTP $ssh)
    {
        $gitCommand = str_replace("\n", '', $ssh->exec('which git'));
        if ($gitCommand == '') {
            throw new \Exception('the git command wasn\'t found on this server');
        }

        return $gitCommand;
    }

    public function cloneCommand($command, $repository, $binary)
    {
        $cloneCommand = $command . ' clone ';

        if ($this->environment->getSource()->getSubmodules()) {
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $cloneCommand .= ' --recursive';
        }

        $cloneCommand .= ' -b ' . $this->environment->getSource()->getBranch();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $cloneCommand .= ' "' . $repository . '"';
        $cloneCommand .= ' "' . $binary . '"';

        return $cloneCommand;
    }
}


Git::cloneCommand() A
last analyzed 2016-01-02 20:10 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

1			<?php
2
3			namespace Onigoetz\Deployer\SCM;
4
5			class Git extends SCM
6			{
7			public function getCommand(\Net_SFTP $ssh)
8			{
9			$gitCommand = str_replace("\n", '', $ssh->exec('which git'));
10			if ($gitCommand == '') {
11			throw new \Exception('the git command wasn\'t found on this server');
12			}
13
14			return $gitCommand;
15			}
16
17			public function cloneCommand($command, $repository, $binary)
18			{
19			$cloneCommand = $command . ' clone ';
20
21			if ($this->environment->getSource()->getSubmodules()) {
			0 ignored issues – show Bug introduced 2016-01-01 15:28 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Onigoetz\Deployer\Config...\ConfigurationContainer` as the method `getSubmodules()` does only exist in the following sub-classes of `Onigoetz\Deployer\Config...\ConfigurationContainer`: `Onigoetz\Deployer\Configuration\Sources\Cloned`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
22			$cloneCommand .= ' --recursive';
23			}
24
25			$cloneCommand .= ' -b ' . $this->environment->getSource()->getBranch();
			0 ignored issues – show Bug introduced 2016-01-01 15:28 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Onigoetz\Deployer\Config...\ConfigurationContainer` as the method `getBranch()` does only exist in the following sub-classes of `Onigoetz\Deployer\Config...\ConfigurationContainer`: `Onigoetz\Deployer\Configuration\Sources\Cloned`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
26			$cloneCommand .= ' "' . $repository . '"';
27			$cloneCommand .= ' "' . $binary . '"';
28
29			return $cloneCommand;
30			}
31			}
32

onigoetz / deployer

Git::cloneCommand() A last analyzed 2016-01-02 20:10 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

Git::cloneCommand() A
last analyzed 2016-01-02 20:10 UTC