onigoetz /
deployer
| 1 | <?php |
||
| 7 | abstract class InheritingConfigurationContainer extends ConfigurationContainer |
||
| 8 | { |
||
| 9 | /** |
||
| 10 | * @var InheritingConfigurationContainer |
||
| 11 | */ |
||
| 12 | protected $parent; |
||
| 13 | |||
| 14 | 207 | public function __construct($name, array $data, ConfigurationManager $manager, self $parent = null) |
|
| 20 | |||
| 21 | /** |
||
| 22 | * Get the value or throw an exception |
||
| 23 | * Will check the parent before the exception is thrown |
||
| 24 | * |
||
| 25 | * @param $key |
||
| 26 | * @param $errorMessage |
||
| 27 | * @throws \LogicException |
||
| 28 | * @return mixed |
||
| 29 | */ |
||
| 30 | 174 | protected function getValueOrFail($key, $errorMessage) |
|
| 31 | { |
||
| 32 | 174 | if (array_key_exists($key, $this->data)) { |
|
| 33 | 126 | return $this->data[$key]; |
|
| 34 | } |
||
| 35 | |||
| 36 | 99 | if ($this->parent) { |
|
| 37 | 39 | return $this->parent->getValueOrFail($key, $errorMessage); |
|
| 38 | } |
||
| 39 | |||
| 40 | 75 | throw new \LogicException($errorMessage); |
|
| 41 | } |
||
| 42 | |||
| 43 | /** |
||
| 44 | * Get the value or return the default |
||
| 45 | * Will check the parent before the default is returned |
||
| 46 | * |
||
| 47 | * @param $key |
||
| 48 | * @param $default |
||
| 49 | * @return mixed |
||
| 50 | */ |
||
| 51 | 102 | protected function getValueOrDefault($key, $default) |
|
| 59 | } |
||
| 60 |
Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly.
For example, imagine you have a variable
$accountIdthat can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to theidproperty of an instance of theAccountclass. This class holds a proper account, so the id value must no longer be false.Either this assignment is in error or a type check should be added for that assignment.