Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
22 | View Code Duplication | class ManagerPass implements CompilerPassInterface |
|
|
|||
23 | { |
||
24 | /** |
||
25 | * {@inheritdoc} |
||
26 | */ |
||
27 | public function process(ContainerBuilder $container) |
||
48 | |||
49 | /** |
||
50 | * Adds loader to LoadersContainer definition. |
||
51 | * |
||
52 | * @param Definition $loadersContainer |
||
53 | * @param array $attributes |
||
54 | * @param string $id |
||
55 | */ |
||
56 | public function addLoader($loadersContainer, $attributes, $id) |
||
63 | |||
64 | /** |
||
65 | * Set import service LoadersContainer. |
||
66 | * |
||
67 | * @param ContainerBuilder $container |
||
68 | * @param Definition $loadersContainer |
||
69 | */ |
||
70 | public function setImportLoadersContainer(ContainerBuilder $container, $loadersContainer) |
||
76 | |||
77 | /** |
||
78 | * Set export service LoadersContainer. |
||
79 | * |
||
80 | * @param ContainerBuilder $container |
||
81 | * @param Definition $loadersContainer |
||
82 | */ |
||
83 | public function setExportLoadersContainer(ContainerBuilder $container, $loadersContainer) |
||
89 | |||
90 | /** |
||
91 | * @param ContainerBuilder $container |
||
92 | */ |
||
93 | private function setComponentDirectories(ContainerBuilder $container) |
||
103 | } |
||
104 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.