PersonalSettingsTest::setUp() - Code Metrics - Inspection of "[WIP] Refactoring front end" - ongr-io/SettingsBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#168)

unknown

created 2016-04-14 12:10 UTC

PersonalSettingsTest::setUp() A

↳ Parent: PersonalSettingsTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	52
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	52
rs	9.4929
cc	1
eloc	38
nc	1
nop	0

How to fix Long Method

<?php

/*
 * This file is part of the ONGR package.
 *
 * (c) NFQ Technologies UAB <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ONGR\SettingsBundle\Tests\Functional\Settings\Personal;

use ONGR\SettingsBundle\Document\Setting;
use ONGR\SettingsBundle\Document\Profile;
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
use ONGR\ElasticsearchBundle\Service\Manager;
use Symfony\Bundle\FrameworkBundle\Client;

/**
 * Test integration with admin-user feature in admin bundle.
 */
class PersonalSettingsTest extends WebTestCase
{
    /**
     * @var Client
     */
    private $client;

    /**
     * {@inheritdoc}
     */
    protected function setUp()
    {
        parent::setUp();

        static::bootKernel(['environment' => 'test_container_creation']);

        /** @var Client $client */
        $this->client = static::createClient();
        /** @var Manager $manager */
        $manager = static::$kernel->getContainer()->get('es.manager');

        // There is something wrong with ElasticsearchTestCase method getDataArray,
        // if we don't create in here all test data, it's not existing when test is run.
        $content = new Profile();
        $content->setId('default_profile');
        $content->setName('default');
        $manager->persist($content);

        $content = new Profile();
        $content->setName('profile_foo.com_profile');
        $content->setName('profile_foo.com');
        $manager->persist($content);

        $content = new Setting();
        $content->setId('foo_default');
        $content->setName('test');
        $content->setProfile('default');
        $content->setDescription('Description');
        $content->setType(Setting::TYPE_ARRAY);
        $content->setData((object)['value' => 'testData']);
        $manager->persist($content);

        $content = new Setting();
        $content->setId('foo');
        $content->setName('test2');
        $content->setProfile('profile_foo.com');
        $content->setDescription('Description');
        $content->setType(Setting::TYPE_ARRAY);
        $content->setData((object)['value' => 'testData']);
        $manager->persist($content);

        $content = new Setting();
        $content->setId('bar');
        $content->setName('test2');
        $content->setProfile('profile_foo.com');
        $content->setDescription('Description');
        $content->setType(Setting::TYPE_ARRAY);
        $content->setData((object)['value' => 'testData']);
        $manager->persist($content);

        $manager->commit();
    }

    /**
     * When user is logged in, he should see admin settings and profile checkboxes.
     */
    public function testSettingsDisplayed()
    {
        // Retrieve content.
        $crawler = $this->client->request('GET', '/settings/settings');

        // Asserts.
        $settingsDescription = $crawler->filter('.category-ongr_settings_settings');
        $this->assertCount(1, $settingsDescription, 'Live settings setting must exist');

        $profile = $crawler->filter('.profile-ongr_settings_profiles');
        $this->assertCount(2, $profile, 'Profile default checkbox must exist');
    }

    /**
     * When user is logged in, and he selects profile, then settings container must receive that choice.
     */
    public function testSettingsSelected()
    {
        $this->client->request(
            'GET',
            $this->client->getContainer()->get('router')->generate(
                'ongr_settings_personal_settings_change',
                [
                    'encodedName' => base64_encode('ongr_settings_profile_default'),
                ]
            )
        );
        $this->assertTrue($this->client->getResponse()->isOk());
        // Load any url and check that user selected domains are loaded.
        $this->client->request('GET', '/settings/setting/test/edit');
        $settingsContainer = $this->client->getContainer()->get('ongr_settings.settings_container');

        $selectedDomains = $settingsContainer->getProfiles();
        $this->assertTrue(in_array('default', $selectedDomains));
    }
}


1			<?php
2
3			/*
4			* This file is part of the ONGR package.
5			*
6			* (c) NFQ Technologies UAB <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace ONGR\SettingsBundle\Tests\Functional\Settings\Personal;
13
14			use ONGR\SettingsBundle\Document\Setting;
15			use ONGR\SettingsBundle\Document\Profile;
16			use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
17			use ONGR\ElasticsearchBundle\Service\Manager;
18			use Symfony\Bundle\FrameworkBundle\Client;
19
20			/**
21			* Test integration with admin-user feature in admin bundle.
22			*/
23			class PersonalSettingsTest extends WebTestCase
24			{
25			/**
26			* @var Client
27			*/
28			private $client;
29
30			/**
31			* {@inheritdoc}
32			*/
33			protected function setUp()
34			{
35			parent::setUp();
36
37			static::bootKernel(['environment' => 'test_container_creation']);
38
39			/** @var Client $client */
40			$this->client = static::createClient();
41			/** @var Manager $manager */
42			$manager = static::$kernel->getContainer()->get('es.manager');
43
44			// There is something wrong with ElasticsearchTestCase method getDataArray,
45			// if we don't create in here all test data, it's not existing when test is run.
46			$content = new Profile();
47			$content->setId('default_profile');
48			$content->setName('default');
49			$manager->persist($content);
50
51			$content = new Profile();
52			$content->setName('profile_foo.com_profile');
53			$content->setName('profile_foo.com');
54			$manager->persist($content);
55
56			$content = new Setting();
57			$content->setId('foo_default');
58			$content->setName('test');
59			$content->setProfile('default');
60			$content->setDescription('Description');
61			$content->setType(Setting::TYPE_ARRAY);
62			$content->setData((object)['value' => 'testData']);
63			$manager->persist($content);
64
65			$content = new Setting();
66			$content->setId('foo');
67			$content->setName('test2');
68			$content->setProfile('profile_foo.com');
69			$content->setDescription('Description');
70			$content->setType(Setting::TYPE_ARRAY);
71			$content->setData((object)['value' => 'testData']);
72			$manager->persist($content);
73
74			$content = new Setting();
75			$content->setId('bar');
76			$content->setName('test2');
77			$content->setProfile('profile_foo.com');
78			$content->setDescription('Description');
79			$content->setType(Setting::TYPE_ARRAY);
80			$content->setData((object)['value' => 'testData']);
81			$manager->persist($content);
82
83			$manager->commit();
84			}
85
86			/**
87			* When user is logged in, he should see admin settings and profile checkboxes.
88			*/
89			public function testSettingsDisplayed()
90			{
91			// Retrieve content.
92			$crawler = $this->client->request('GET', '/settings/settings');
93
94			// Asserts.
95			$settingsDescription = $crawler->filter('.category-ongr_settings_settings');
96			$this->assertCount(1, $settingsDescription, 'Live settings setting must exist');
97
98			$profile = $crawler->filter('.profile-ongr_settings_profiles');
99			$this->assertCount(2, $profile, 'Profile default checkbox must exist');
100			}
101
102			/**
103			* When user is logged in, and he selects profile, then settings container must receive that choice.
104			*/
105			public function testSettingsSelected()
106			{
107			$this->client->request(
108			'GET',
109			$this->client->getContainer()->get('router')->generate(
110			'ongr_settings_personal_settings_change',
111			[
112			'encodedName' => base64_encode('ongr_settings_profile_default'),
113			]
114			)
115			);
116			$this->assertTrue($this->client->getResponse()->isOk());
117			// Load any url and check that user selected domains are loaded.
118			$this->client->request('GET', '/settings/setting/test/edit');
119			$settingsContainer = $this->client->getContainer()->get('ongr_settings.settings_container');
120
121			$selectedDomains = $settingsContainer->getProfiles();
122			$this->assertTrue(in_array('default', $selectedDomains));
123			}
124			}
125

ongr-io / SettingsBundle

Pull Request — master (#168)

PersonalSettingsTest::setUp() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like