Completed
Pull Request — master (#158)
by
unknown
06:10 queued 03:10
created
Event/SettingChangeEvent.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
     /**
27 27
      * Constructor.
28 28
      *
29
-     * @param Action $action
29
+     * @param string $action
30 30
      */
31 31
     public function __construct($action)
32 32
     {
Please login to merge, or discard this patch.
Settings/General/SettingsContainer.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@
 block discarded – undo
120 120
     }
121 121
 
122 122
     /**
123
-     * @param array $profiles
123
+     * @param string[] $profiles
124 124
      */
125 125
     public function setProfiles($profiles)
126 126
     {
Please login to merge, or discard this patch.
Tests/Unit/Settings/General/SettingsContainerTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -108,7 +108,7 @@
 block discarded – undo
108 108
      * @param bool  $miss
109 109
      * @param array $settings
110 110
      *
111
-     * @return \PHPUnit_Framework_MockObject_MockObject|PoolInterface
111
+     * @return PoolInterface
112 112
      */
113 113
     private function getPool($miss = true, $settings = [])
114 114
     {
Please login to merge, or discard this patch.
Twig/HiddenExtension.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
     }
42 42
 
43 43
     /**
44
-     * @return array
44
+     * @return \Twig_SimpleFunction[]
45 45
      */
46 46
     public function getFunctions()
47 47
     {
Please login to merge, or discard this patch.
Twig/WrapperExtension.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
     /**
20 20
      * Returns list of new Twig functions.
21 21
      *
22
-     * @return array
22
+     * @return \Twig_SimpleFilter[]
23 23
      */
24 24
     public function getFilters()
25 25
     {
Please login to merge, or discard this patch.
EventListener/SettingsCookieListener.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
     ) {
39 39
         $settingsMap = $this->generalSettingsManager->getSettingsMap();
40 40
         $cookiesServiceNames = array_map(
41
-            function ($setting) {
41
+            function($setting) {
42 42
                 return $setting['cookie'];
43 43
             },
44 44
             $settingsMap
Please login to merge, or discard this patch.
Tests/Functional/Controller/UserControllerTest.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
         if ($shouldSucceed) {
80 80
             $this->assertContains(' already logged in', $response->getContent());
81 81
 
82
-             // Assert correct cookie has been set.
82
+                // Assert correct cookie has been set.
83 83
             /** @var Cookie $cookie */
84 84
             $cookie = $client->getCookieJar()->get('ongr_settings_user_auth');
85 85
             $this->assertSame('ongr_settings_user_auth', $cookie->getName());
Please login to merge, or discard this patch.
Tests/Functional/Controller/PersonalSettingsControllerTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@
 block discarded – undo
99 99
 
100 100
         // Try to change value through change setting action.
101 101
         $data[0] = ['foo_setting_1', false];
102
-        $data[1] = ['foo_setting_non_existent', false ];
102
+        $data[1] = ['foo_setting_non_existent', false];
103 103
 
104 104
         foreach ($data as $case) {
105 105
             $client->request('get', '/admin/setting/change/' . base64_encode($case[0]));
Please login to merge, or discard this patch.
Tests/Unit/EventListener/ProfileRequestListenerTest.php 3 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
         // Case #0. No profiles selected.
29 29
         $cases[] = [[], []];
30 30
         // Case #1. One profile selected.
31
-        $cases[] = [ ['ongr_settings_profile_foo-2e-com' => true], ['foo.com'] ];
31
+        $cases[] = [['ongr_settings_profile_foo-2e-com' => true], ['foo.com']];
32 32
         // Case #2. One profile unselected.
33 33
         $cases[] = [
34 34
             ['ongr_settings_profile_foo-2e-com' => false, 'ongr_settings_profile_bar-2e-com' => true],
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@
 block discarded – undo
86 86
     /**
87 87
      * Returns mock of ORM manager.
88 88
      *
89
-     * @return Manager
89
+     * @return \ONGR\ElasticsearchBundle\Service\Manager
90 90
      */
91 91
     protected function getManagerMock()
92 92
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,6 @@
 block discarded – undo
12 12
 namespace ONGR\SettingsBundle\Tests\Unit\EventListener;
13 13
 
14 14
 use ONGR\SettingsBundle\EventListener\ProfileRequestListener;
15
-use ONGR\ElasticsearchBundle\Test\ElasticsearchTestCase;
16 15
 
17 16
 class ProfileRequestListenerTest extends \PHPUnit_Framework_TestCase
18 17
 {
Please login to merge, or discard this patch.