ONGR\SettingsBundle\Controller\SettingsController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	92
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	14
Bugs	0	Features	8

4 Methods

Rating	Name	Duplication	Size	Complexity
A	listAction()	0	4	1
A	updateValueAction()	0	10	1
A	deleteAction()	0	19	2
B	submitAction()	0	24	3

<?php

/*
 * This file is part of the ONGR package.
 *
 * (c) NFQ Technologies UAB <info@nfq.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ONGR\SettingsBundle\Controller;

use ONGR\ElasticsearchBundle\Result\Aggregation\AggregationValue;
use ONGR\ElasticsearchBundle\Service\Repository;
use ONGR\ElasticsearchDSL\Aggregation\TermsAggregation;
use ONGR\SettingsBundle\Document\Setting;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

/**
 * Class SettingsListController. Is used for managing settings in General env.
 */
class SettingsController extends Controller
{
    /**
     * Renders settings list page.
     *
     * @param Request $request

There is no parameter named $request. Was it maybe removed?

     *
     * @return Response
     */
    public function listAction()
    {
        return $this->render('ONGRSettingsBundle:Settings:list.html.twig');
    }

    /**
     * Setting update action.
     *
     * @param Request $request
     *
     * @return JsonResponse
     */
    public function updateValueAction(Request $request)
    {
        $name = $request->get('name');
        $value = $request->get('value');

        $manager = $this->get('ongr_settings.settings_manager');
        $manager->update($name, ['value' => $value]);

        return new JsonResponse(['error' => false]);
    }

    /**
     * Setting delete action
     *
     * @param Request $request
     * @param $id
     *
     * @return JsonResponse
     */
    public function deleteAction(Request $request, $id)

The parameter $request is not used and could be removed.

    {
        try {
            /** @var Repository $repo */
            $repo = $this->get($this->getParameter('ongr_settings.repo'));

            $repo->remove($id);

            return new JsonResponse(['error' => false]);

        } catch (\Exception $e) {
            return new JsonResponse(
                [
                    'error' => true,
                    'message' => 'Error occurred please try to delete setting again.'
                ]
            );
        }
    }

    /**
     * Submit action to create or edit setting if not exists.
     *
     * @param Request $request
     *
     * @return JsonResponse
     */
    public function submitAction(Request $request)
    {
        try {
            $manager = $this->get('ongr_settings.settings_manager');
            $data = $request->get('setting');

            if ($request->get('force')) {
                $name = $request->get('name');
                $manager->update($name, $data);
            } else {
                $manager->create($data);
            }

            return new JsonResponse(['error' => false]);

        } catch (\Exception $e) {
            return new JsonResponse(
                [
                    'error' => true,
                    'message' => 'Error occurred! Something is wrong with provided data. Please try to submit form again.'
                ]
            );
        }
    }
}