ongr-io / SettingsBundle

DependencyInjection/Compiler/ProviderPass.php

Spacing +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
         // elements comes out reversed compared to original.
         uasort(
             $providers,
-            function ($a, $b) {
+            function($a, $b) {
                 if ($a['priority'] == $b['priority']) {
                     return 0;
                 }

Twig/ImagePathExtension.php

Doc Comments +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
     }
 
     /**
-     * @return array
+     * @return \Twig_SimpleFunction[]
      */
     public function getFunctions()
     {

Twig/PersonalSettingWidgetExtension.php

Doc Comments +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
      * @param string $settingName
      * @param bool   $mustAuthorize
      *
-     * @return mixed
+     * @return boolean
      */
     public function getSettingEnabled($settingName, $mustAuthorize = true)
     {

Tests/Functional/Settings/SettingsManagerTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -161,7 +161,7 @@
      *
      * @param string $name
      * @param string $type
-     * @param mixed  $value
+     * @param string  $value
      * @param string $profile
      *
      * @return Setting

Unused Use Statements -1 removed lines

@@ -16,7 +16,6 @@
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
 use ONGR\ElasticsearchBundle\Service\Manager;
 use ONGR\ElasticsearchDSL\Query\MatchAllQuery;
-use Symfony\Component\Translation\TranslatorInterface;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 
 /**

Twig/EncryptionExtension.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
     public function getFilters()
     {
         return [
-            'base64Encode' => new \Twig_SimpleFilter('base64Encode', [$this,'base64EncodeFilter'])
+            'base64Encode' => new \Twig_SimpleFilter('base64Encode', [$this, 'base64EncodeFilter'])
         ];
     }
 

Controller/SettingsManagerController.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 
 use ONGR\SettingsBundle\Settings\General\SettingsManager;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
-use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;

ONGRSettingsBundle.php

Unused Use Statements -1 removed lines

@@ -17,7 +17,6 @@
 use ONGR\SettingsBundle\DependencyInjection\Compiler\SettingAwareFactoryPass;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\HttpKernel\Bundle\Bundle;
-use ONGR\SettingsBundle\DependencyInjection\Security\SessionlessAuthenticationFactory;
 
 /**
  * This class is used to register component into Symfony app kernel.

Service/FormValidator.php

Spacing +7 added lines, -8 removed lines

@@ -39,28 +39,27 @@ 
             $return['error'] = 'You must set a name to the setting. ';
         }
         if (count($return['profiles']) == 0) {
-            $return['error'] = $return['error'].'At least 1 profile has to be set. ';
+            $return['error'] = $return['error'] . 'At least 1 profile has to be set. ';
         }
         switch ($return['type']) {
             case 'bool':
                 $request->request->get('setting-boolean') == 'true' ?
-                    $return['value'] = true :
-                    $return['value'] = false;
+                    $return['value'] = true : $return['value'] = false;
                 break;
             case 'string':
                 $return['value'] = $request->request->get('setting-default');
                 if ($return['value'] == '') {
-                    $return['error'] = $return['error'].'You must set a value to the setting. ';
+                    $return['error'] = $return['error'] . 'You must set a value to the setting. ';
                 }
                 break;
             case 'object':
                 try {
                     $return['value'] = json_encode($parser->parse($request->request->get('setting-object')));
                 } catch (\Exception $e) {
-                    $return['error'] = $return['error'].'Passed setting value does not contain valid yaml. ';
+                    $return['error'] = $return['error'] . 'Passed setting value does not contain valid yaml. ';
                 }
                 if ($return['value'] == '') {
-                    $return['error'] = $return['error'].'You must set a value to the setting. ';
+                    $return['error'] = $return['error'] . 'You must set a value to the setting. ';
                 }
                 break;
             case 'array':
@@ -71,7 +70,7 @@ 
                     }
                 }
                 if (count($return['value']) == 0 || $return['value'][0] == '') {
-                    $return['error'] = $return['error'].'You must set a value to the setting. ';
+                    $return['error'] = $return['error'] . 'You must set a value to the setting. ';
                 }
                 break;
         }
@@ -100,7 +99,7 @@ 
         }
         foreach ($profiles as $profile) {
             if ($return['name'] == $profile['name']) {
-                $return['error'] = 'The profile `'.$profile['name'].'` is already set.';
+                $return['error'] = 'The profile `' . $profile['name'] . '` is already set.';
                 return $return;
             }
         }

Controller/ProfileController.php

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
         }
         try {
             $profileManager->createProfile($data['name'], $data['description']);
-        }catch (\Exception $e) {
+        } catch (\Exception $e) {
             $cache->save('settings_errors', $e->getMessage());
             return new RedirectResponse($this->generateUrl('ongr_settings_profile_add'));
         }

Braces +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
         }
         try {
             $profileManager->createProfile($data['name'], $data['description']);
-        }catch (\Exception $e) {
+        } catch (\Exception $e) {
             $cache->save('settings_errors', $e->getMessage());
             return new RedirectResponse($this->generateUrl('ongr_settings_profile_add'));
         }