FormValidator::validateSettingForm() - Code Metrics - Inspection of "[WIP] Refactoring front end" - ongr-io/SettingsBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#168)

unknown

created 2016-04-08 08:42 UTC

FormValidator::validateSettingForm() C

↳ Parent: FormValidator

Complexity

Conditions	16
Paths	88

Size

Total Lines	55
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	2

Metric	Value
c	2
b	0
f	2
dl	0
loc	55
rs	6.6992
cc	16
eloc	41
nc	88
nop	1

How to fix Long Method Complexity

<?php

/*
 * This file is part of the ONGR package.
 *
 * (c) NFQ Technologies UAB <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ONGR\SettingsBundle\Service;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Yaml\Parser;

class FormValidator
{
    /**
     * Validates add or edit setting form
     *
     * @param Request $request
     *
     * @return array
     */
    public function validateSettingForm(Request $request)
    {
        $parser = new Parser();
        $return = [];
        $return['error'] = '';
        $return['name'] = $request->request->get('settingName');
        $return['type'] = $request->request->get('settingType');
        $return['description'] = $request->request->get('settingDescription');
        $profiles = $request->request->get('settingProfiles');

        is_string($profiles) ? $return['profiles'] = [$profiles] : $return['profiles'] = $profiles;

        if ($return['name'] == '') {
            $return['error'] = 'You must set a name to the setting. ';
        }
        if (count($return['profiles']) == 0) {
            $return['error'] = $return['error'].'At least 1 profile has to be set. ';
        }
        switch ($return['type']) {
            case 'bool':
                $request->request->get('setting-boolean') == 'true' ?
                    $return['value'] = true :
                    $return['value'] = false;
                break;
            case 'string':
                $return['value'] = $request->request->get('setting-default');
                if ($return['value'] == '') {
                    $return['error'] = $return['error'].'You must set a value to the setting. ';
                }
                break;
            case 'object':
                try {
                    $return['value'] = json_encode($parser->parse($request->request->get('setting-object')));
                } catch (\Exception $e) {
                    $return['error'] = $return['error'].'Passed setting value does not contain valid yaml. ';
                }
                if ($return['value'] == '') {
                    $return['error'] = $return['error'].'You must set a value to the setting. ';
                }
                break;
            case 'array':
                $return['value'] = [];
                foreach ($request->request->all() as $key => $item) {
                    if (preg_match('/setting-array_[0-9]*/', $key)) {
                        $return['value'][] = $item;
                    }
                }
                if (count($return['value']) == 0 || $return['value'][0] == '') {
                    $return['error'] = $return['error'].'You must set a value to the setting. ';
                }
                break;
        }

        return $return;
    }

    /**
     * Validates profile form
     *
     * @param Request $request
     * @param array   $profiles
     *
     * @return array
     */
    public function validateProfileForm(Request $request, array $profiles)
    {
        $return = [];
        $return['error'] = '';
        $return['name'] = $request->request->get('profileName');
        $return['description'] = $request->request->get('profileDescription');

        if ($return['name'] == '') {
            $return['error'] = 'You must set a unique name of the profile.';
            return $return;
        }
        foreach ($profiles as $profile) {
            if ($return['name'] == $profile['name']) {
                $return['error'] = 'The profile `'.$profile['name'].'` is already set.';
                return $return;
            }
        }

        return $return;
    }
}





1			<?php
2
3			/*
4			* This file is part of the ONGR package.
5			*
6			* (c) NFQ Technologies UAB <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace ONGR\SettingsBundle\Service;
13
14			use Symfony\Component\HttpFoundation\Request;
15			use Symfony\Component\Yaml\Parser;
16
17			class FormValidator
18			{
19			/**
20			* Validates add or edit setting form
21			*
22			* @param Request $request
23			*
24			* @return array
25			*/
26			public function validateSettingForm(Request $request)
27			{
28			$parser = new Parser();
29			$return = [];
30			$return['error'] = '';
31			$return['name'] = $request->request->get('settingName');
32			$return['type'] = $request->request->get('settingType');
33			$return['description'] = $request->request->get('settingDescription');
34			$profiles = $request->request->get('settingProfiles');
35
36			is_string($profiles) ? $return['profiles'] = [$profiles] : $return['profiles'] = $profiles;
37
38			if ($return['name'] == '') {
39			$return['error'] = 'You must set a name to the setting. ';
40			}
41			if (count($return['profiles']) == 0) {
42			$return['error'] = $return['error'].'At least 1 profile has to be set. ';
43			}
44			switch ($return['type']) {
45			case 'bool':
46			$request->request->get('setting-boolean') == 'true' ?
47			$return['value'] = true :
48			$return['value'] = false;
49			break;
50			case 'string':
51			$return['value'] = $request->request->get('setting-default');
52			if ($return['value'] == '') {
53			$return['error'] = $return['error'].'You must set a value to the setting. ';
54			}
55			break;
56			case 'object':
57			try {
58			$return['value'] = json_encode($parser->parse($request->request->get('setting-object')));
59			} catch (\Exception $e) {
60			$return['error'] = $return['error'].'Passed setting value does not contain valid yaml. ';
61			}
62			if ($return['value'] == '') {
63			$return['error'] = $return['error'].'You must set a value to the setting. ';
64			}
65			break;
66			case 'array':
67			$return['value'] = [];
68			foreach ($request->request->all() as $key => $item) {
69			if (preg_match('/setting-array_[0-9]*/', $key)) {
70			$return['value'][] = $item;
71			}
72			}
73			if (count($return['value']) == 0 \|\| $return['value'][0] == '') {
74			$return['error'] = $return['error'].'You must set a value to the setting. ';
75			}
76			break;
77			}
78
79			return $return;
80			}
81
82			/**
83			* Validates profile form
84			*
85			* @param Request $request
86			* @param array $profiles
87			*
88			* @return array
89			*/
90			public function validateProfileForm(Request $request, array $profiles)
91			{
92			$return = [];
93			$return['error'] = '';
94			$return['name'] = $request->request->get('profileName');
95			$return['description'] = $request->request->get('profileDescription');
96
97			if ($return['name'] == '') {
98			$return['error'] = 'You must set a unique name of the profile.';
99			return $return;
100			}
101			foreach ($profiles as $profile) {
102			if ($return['name'] == $profile['name']) {
103			$return['error'] = 'The profile `'.$profile['name'].'` is already set.';
104			return $return;
105			}
106			}
107
108			return $return;
109			}
110			}
111
112
113
114

ongr-io / SettingsBundle

Pull Request — master (#168)

FormValidator::validateSettingForm() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like