ongr-io / SettingsBundle

Twig/PersonalSettingWidgetExtension.php

Doc Comments +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
      * @param string $settingName
      * @param bool   $mustAuthorize
      *
-     * @return mixed
+     * @return boolean
      */
     public function getSettingEnabled($settingName, $mustAuthorize = true)
     {

Tests/Functional/Settings/SettingsManagerTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -161,7 +161,7 @@
      *
      * @param string $name
      * @param string $type
-     * @param mixed  $value
+     * @param string  $value
      * @param string $profile
      *
      * @return Setting

Unused Use Statements -1 removed lines

@@ -16,7 +16,6 @@
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
 use ONGR\ElasticsearchBundle\Service\Manager;
 use ONGR\ElasticsearchDSL\Query\MatchAllQuery;
-use Symfony\Component\Translation\TranslatorInterface;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 
 /**

Spacing +2 added lines, -2 removed lines

@@ -181,9 +181,9 @@
     private function getSetting($name, $type, $value, $profile = 'default')
     {
         $setting = new Setting();
-        $setting->setId($profile . '_' . $name);
+        $setting->setId($profile.'_'.$name);
         $setting->setName($name);
-        $setting->setDescription('ongr_settings.' . $name);
+        $setting->setDescription('ongr_settings.'.$name);
         $setting->setProfile($profile);
         $setting->setType($type);
         $setting->setData(['value' => $value]);

Twig/EncryptionExtension.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
     public function getFilters()
     {
         return [
-            'base64Encode' => new \Twig_SimpleFilter('base64Encode', [$this,'base64EncodeFilter'])
+            'base64Encode' => new \Twig_SimpleFilter('base64Encode', [$this, 'base64EncodeFilter'])
         ];
     }
 

Controller/SettingsManagerController.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 
 use ONGR\SettingsBundle\Settings\General\SettingsManager;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
-use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;

ONGRSettingsBundle.php

Unused Use Statements -1 removed lines

@@ -17,7 +17,6 @@
 use ONGR\SettingsBundle\DependencyInjection\Compiler\SettingAwareFactoryPass;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\HttpKernel\Bundle\Bundle;
-use ONGR\SettingsBundle\DependencyInjection\Security\SessionlessAuthenticationFactory;
 
 /**
  * This class is used to register component into Symfony app kernel.

Tests/Functional/Controller/PersonalSettingsControllerTest.php

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 namespace ONGR\SettingsBundle\Tests\Functional\Controller;
 
 use ONGR\ElasticsearchBundle\Test\AbstractElasticsearchTestCase;
-use ONGR\SettingsBundle\Tests\Fixtures\Security\LoginTestHelper;
 use Symfony\Bundle\FrameworkBundle\Client;
 
 /**

Settings/General/SettingsManager.php

Spacing +4 added lines, -4 removed lines

@@ -74,7 +74,7 @@ 
     {
         foreach ($profiles as $profile) {
             $setting = new Setting();
-            $setting->setId($profile . '_' . $name);
+            $setting->setId($profile.'_'.$name);
             $setting->setName($name);
             $setting->setDescription($description);
             $setting->setData((object)['value' => $value]);
@@ -130,7 +130,7 @@ 
         foreach ($newProfiles as $profile) {
             $newSetting = clone $setting;
 
-            $newSetting->setId($profile . '_' . $setting->getName());
+            $newSetting->setId($profile.'_'.$setting->getName());
             $newSetting->setProfile($profile);
             $newSettings[] = $newSetting;
         }
@@ -152,7 +152,7 @@ 
      */
     public function get($name, $profile = 'default', $mustExist = true, $type = 'string')
     {
-        $setting = $this->repo->find($profile . '_' . $name);
+        $setting = $this->repo->find($profile.'_'.$name);
         if ($setting === null) {
             if ($mustExist === true) {
                 throw new \UnexpectedValueException();
@@ -175,7 +175,7 @@ 
     protected function createSetting($name, $profile, $type)
     {
         $setting = new Setting();
-        $setting->setId($profile . '_' . $name);
+        $setting->setId($profile.'_'.$name);
         $setting->setName($name);
         $setting->setProfile($profile);
         $setting->setType($type);

Settings/General/SettingAwareServiceFactory.php

Spacing +1 added lines, -1 removed lines

@@ -82,6 +82,6 @@
      */
     protected function guessName($setting)
     {
-        return 'set' . Container::camelize($setting);
+        return 'set'.Container::camelize($setting);
     }
 }

Settings/Personal/PersonalProfilesProvider.php

Spacing +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
 
         $settings = [];
         foreach ($profiles as $profile) {
-            $profileId = 'ongr_settings_profile_' . UnderscoreEscaper::escape($profile['name']);
+            $profileId = 'ongr_settings_profile_'.UnderscoreEscaper::escape($profile['name']);
             $settings[$profileId] = [
                 'name' => $profile['name'],
                 'category' => 'ongr_settings_profiles',