ONGR\SettingsBundle\Document\Setting

Complexity

Total Complexity

18

Size/Duplication

Total Lines	227
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	7
Bugs	0	Features	2

18 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getId()	0	4	1
A	setId()	0	4	1
A	getValue()	0	4	1
A	setValue()	0	4	1
A	getType()	0	4	1
A	setType()	0	4	1
A	getProfile()	0	4	1
A	setProfile()	0	4	1
A	getDescription()	0	4	1
A	setDescription()	0	4	1
A	getName()	0	4	1
A	setName()	0	4	1
A	getSalt()	0	4	1
A	setSalt()	0	4	1
A	getCreatedAt()	0	4	1
A	setCreatedAt()	0	4	1
A	getSerializableData()	0	11	1

<?php

/*
 * This file is part of the ONGR package.
 *
 * (c) NFQ Technologies UAB <info@nfq.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ONGR\SettingsBundle\Document;

use ONGR\ElasticsearchBundle\Annotation as ES;
use ONGR\FilterManagerBundle\SerializableInterface;

/**
 * Stores admin settings.
 *
 * @ES\Document(type="setting")
 */
class Setting implements SerializableInterface
{
    /**
     * @var string
     *
     * @ES\Id()
     */
    private $id;

    /**
     * @var string
     *
     * @ES\Property(type="string", options={"analyzer"="standard"})
     */
    private $name;

    /**
     * @var string
     *
     * @ES\Property(type="string", options={"analyzer"="standard"})
     */
    private $description;

    /**
     * @var string
     *
     * @ES\Property(type="string", options={"analyzer"="standard"})
     */
    private $profile = [];

    /**
     * @var string
     *
     * @ES\Property(type="string", options={"analyzer"="standard"})
     */
    private $type;

    /**
     * @var string
     *
     * @ES\Property(type="string", options={"index"="not_analyzed"})
     */
    private $value;

    /**
     * @var string
     *
     * @ES\Property(type="string", options={"index"="not_analyzed"})
     */
    private $salt;

    /**
     * @var string
     *
     * @ES\Property(type="date")
     */
    private $createdAt;

    /**
     * Setting constructor.
     */
    public function __construct()
    {
        $this->createdAt = new \DateTime();

It seems like new \DateTime() of type object<DateTime> is incompatible with the declared type string of property $createdAt.

    }

    /**
     * @return string
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * @param string $id
     */
    public function setId($id)
    {
        $this->id = $id;
    }

    /**
     * @return string
     */
    public function getValue()
    {
        return $this->value;
    }

    /**
     * @param string $value
     */
    public function setValue($value)
    {
        $this->value = $value;
    }

    /**
     * Get type.
     *
     * @return string
     */
    public function getType()
    {
        return $this->type;
    }

    /**
     * Set type.
     *
     * @param string $type
     */
    public function setType($type)
    {
        $this->type = $type;
    }

    /**
     * Get profile.
     *
     * @return string|array
     */
    public function getProfile()
    {
        return $this->profile;
    }

    /**
     * Set profile.
     *
     * @param string|array $profile
     */
    public function setProfile($profile)
    {
        $this->profile = $profile;

It seems like $profile can also be of type array. However, the property $profile is declared as type string. Maybe add an additional type check?

    }

    /**
     * Get description.
     *
     * @return string
     */
    public function getDescription()
    {
        return $this->description;
    }

    /**
     * Set description.
     *
     * @param string $description
     */
    public function setDescription($description)
    {
        $this->description = $description;
    }

    /**
     * Get name.
     *
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * Set name.
     *
     * @param string $name
     */
    public function setName($name)
    {
        $this->name = $name;
    }

    /**
     * @return string
     */
    public function getSalt()
    {
        return $this->salt;
    }

    /**
     * @param string $salt
     */
    public function setSalt($salt)
    {
        $this->salt = $salt;
    }

    /**
     * @return string
     */
    public function getCreatedAt()
    {
        return $this->createdAt;
    }

    /**
     * @param string $createdAt
     */
    public function setCreatedAt($createdAt)
    {
        $this->createdAt = $createdAt;
    }

    /**
     * Specify data which should be serialized to JSON.
     *
     * @return mixed Data which can be serialized by json_encode.
     */
    public function getSerializableData()
    {
        return [
            'id' => $this->getId(),
            'name' => $this->getName(),
            'description' => $this->getDescription(),
            'profile' => $this->getProfile(),
            'type' => $this->getType(),
            'value' => $this->getValue(),
        ];
    }
}