SettingsManagerTest::getDataArray() - Code Metrics - Inspection of "[WIP] Experiments" - ongr-io/SettingsBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#177)

unknown

created 2016-10-20 07:10 UTC

SettingsManagerTest::getDataArray() B

↳ Parent: SettingsManagerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	76
Code Lines	48

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	76
rs	8.9667
cc	1
eloc	48
nc	1
nop	0

How to fix Long Method

<?php

namespace ONGR\SettingsBundle\Tests\Functional;

use ONGR\ElasticsearchBundle\Test\AbstractElasticsearchTestCase;
use ONGR\SettingsBundle\Service\SettingsManager;

class SettingsManagerTest extends AbstractElasticsearchTestCase
{
    /**
     * @var SettingsManager
     */
    private $settingsManager;

    protected function getDataArray()
    {
        return [
            'settings' => [
                'setting' => [
                    [
                        '_id' => '1',
                        'name' => 'foo',
                        'profile' => [
                            'profile1',
                        ],
                        'value' => '1',
                        'type' => 'bool',
                    ],
                    [
                        '_id' => '2',
                        'name' => 'bar',
                        'profile' => [
                            'profile1',
                            'profile2',
                        ],
                        'value' => 'test-string',
                        'type' => 'string',
                    ],
                    [
                        '_id' => '3',
                        'name' => 'acme',
                        'profile' => [
                            'profile2',
                        ],
                        'value' => '0',
                        'type' => 'bool',
                    ],
                    [
                        '_id' => '4',
                        'name' => 'active_profiles',
                        'value' => [
                            'profile2',
                        ],
                        'type' => 'hidden',
                    ],
                    [
                        '_id' => '5',
                        'name' => 'active_experiments',
                        'value' => [
                            'foo_experiment',
                        ],
                        'type' => 'hidden',
                    ],
                    [
                        '_id' => '6',
                        'name' => 'foo_experiment',
                        'profile' => [
                            'profile1',
                            'profile2',
                        ],
                        'value' => [
                            'test_experiment_value',
                        ],
                        'type' => 'experiment',
                    ],
                    [
                        '_id' => '7',
                        'name' => 'bar_experiment',
                        'profile' => [
                            'profile1',
                        ],
                        'value' => [
                            'test_experiment_value',
                        ],
                        'type' => 'experiment',
                    ],
                ]
            ]
        ];
    }

    public function testGetAllExperiments()
    {
        $expected = [
            [
                'id' => '6',
                'name' => 'foo_experiment',
                'value' => ['test_experiment_value'],
                'profile' => ['profile1', 'profile2'],
                'type' => 'experiment',
                'description' => null,
                'salt' => null,
            ],
            [
                'id' => '7',
                'name' => 'bar_experiment',
                'value' => ['test_experiment_value'],
                'profile' => ['profile1'],
                'type' => 'experiment',
                'description' => null,
                'salt' => null,
            ]
        ];

        $experiments = [];
        $results = $this->getContainer()->get('ongr_settings.settings_manager')->getAllExperiments();

        foreach ($results as $experiment) {
            $experiments[] = $experiment->getSerializableData();
        }

        $this->assertEquals($expected, $experiments);
    }

    public function testToggleExperiment()
    {
        $manager = $this->getSettingsManager();
        $this->assertEquals(['foo_experiment'], $manager->getActiveExperiments());

        $manager->toggleExperiment('foo_experiment');
        $this->assertEquals([], $manager->getActiveExperiments());

        $manager->toggleExperiment('bar_experiment');
        $this->assertEquals(['bar_experiment'], $manager->getActiveExperiments());
    }

    public function testGetCachedExperiment()
    {
        $expected = [
            'id' => '6',
            'name' => 'foo_experiment',
            'value' => ['test_experiment_value'],
            'profile' => ['profile1', 'profile2'],
            'type' => 'experiment',
            'description' => null,
            'salt' => null,
        ];
        $manager = $this->getSettingsManager();
        // Test it without cache:
        $this->assertEquals($expected, $manager->getCachedExperiment('foo_experiment'));
        // Test it with cache:
        $this->assertEquals($expected, $manager->getCachedExperiment('foo_experiment'));
        // test a non existing experiment:
        $this->assertNull($manager->getCachedExperiment('non-existing-experiment'));
    }

    /**
     * @expectedException \LogicException
     * @expectedExceptionMessage The setting `foo` was found but it is not an experiment
     */
    public function testGetCachedExperimentException()
    {
        $this->getSettingsManager()->getCachedExperiment('foo');
    }

    /**
     * @return SettingsManager
     */
    private function getSettingsManager()
    {
        if (!empty($this->settingsManager)) {
            $this->settingsManager->getCache()->deleteAll();
            return $this->settingsManager;
        }

        /** @var SettingsManager $manager */
        $manager = $this->getContainer()->get('ongr_settings.settings_manager');
        $manager->setActiveExperimentsSettingName('active_experiments');

        $this->settingsManager = $manager;

        return $this->settingsManager;
    }

    /**
     * {@inheritdoc}
     */
    protected function tearDown()
    {
        parent::tearDown();

        // Deletes the settings manager cache
        $this->getSettingsManager();
    }
}


1			<?php
2
3			namespace ONGR\SettingsBundle\Tests\Functional;
4
5			use ONGR\ElasticsearchBundle\Test\AbstractElasticsearchTestCase;
6			use ONGR\SettingsBundle\Service\SettingsManager;
7
8			class SettingsManagerTest extends AbstractElasticsearchTestCase
9			{
10			/**
11			* @var SettingsManager
12			*/
13			private $settingsManager;
14
15			protected function getDataArray()
16			{
17			return [
18			'settings' => [
19			'setting' => [
20			[
21			'_id' => '1',
22			'name' => 'foo',
23			'profile' => [
24			'profile1',
25			],
26			'value' => '1',
27			'type' => 'bool',
28			],
29			[
30			'_id' => '2',
31			'name' => 'bar',
32			'profile' => [
33			'profile1',
34			'profile2',
35			],
36			'value' => 'test-string',
37			'type' => 'string',
38			],
39			[
40			'_id' => '3',
41			'name' => 'acme',
42			'profile' => [
43			'profile2',
44			],
45			'value' => '0',
46			'type' => 'bool',
47			],
48			[
49			'_id' => '4',
50			'name' => 'active_profiles',
51			'value' => [
52			'profile2',
53			],
54			'type' => 'hidden',
55			],
56			[
57			'_id' => '5',
58			'name' => 'active_experiments',
59			'value' => [
60			'foo_experiment',
61			],
62			'type' => 'hidden',
63			],
64			[
65			'_id' => '6',
66			'name' => 'foo_experiment',
67			'profile' => [
68			'profile1',
69			'profile2',
70			],
71			'value' => [
72			'test_experiment_value',
73			],
74			'type' => 'experiment',
75			],
76			[
77			'_id' => '7',
78			'name' => 'bar_experiment',
79			'profile' => [
80			'profile1',
81			],
82			'value' => [
83			'test_experiment_value',
84			],
85			'type' => 'experiment',
86			],
87			]
88			]
89			];
90			}
91
92			public function testGetAllExperiments()
93			{
94			$expected = [
95			[
96			'id' => '6',
97			'name' => 'foo_experiment',
98			'value' => ['test_experiment_value'],
99			'profile' => ['profile1', 'profile2'],
100			'type' => 'experiment',
101			'description' => null,
102			'salt' => null,
103			],
104			[
105			'id' => '7',
106			'name' => 'bar_experiment',
107			'value' => ['test_experiment_value'],
108			'profile' => ['profile1'],
109			'type' => 'experiment',
110			'description' => null,
111			'salt' => null,
112			]
113			];
114
115			$experiments = [];
116			$results = $this->getContainer()->get('ongr_settings.settings_manager')->getAllExperiments();
117
118			foreach ($results as $experiment) {
119			$experiments[] = $experiment->getSerializableData();
120			}
121
122			$this->assertEquals($expected, $experiments);
123			}
124
125			public function testToggleExperiment()
126			{
127			$manager = $this->getSettingsManager();
128			$this->assertEquals(['foo_experiment'], $manager->getActiveExperiments());
129
130			$manager->toggleExperiment('foo_experiment');
131			$this->assertEquals([], $manager->getActiveExperiments());
132
133			$manager->toggleExperiment('bar_experiment');
134			$this->assertEquals(['bar_experiment'], $manager->getActiveExperiments());
135			}
136
137			public function testGetCachedExperiment()
138			{
139			$expected = [
140			'id' => '6',
141			'name' => 'foo_experiment',
142			'value' => ['test_experiment_value'],
143			'profile' => ['profile1', 'profile2'],
144			'type' => 'experiment',
145			'description' => null,
146			'salt' => null,
147			];
148			$manager = $this->getSettingsManager();
149			// Test it without cache:
150			$this->assertEquals($expected, $manager->getCachedExperiment('foo_experiment'));
151			// Test it with cache:
152			$this->assertEquals($expected, $manager->getCachedExperiment('foo_experiment'));
153			// test a non existing experiment:
154			$this->assertNull($manager->getCachedExperiment('non-existing-experiment'));
155			}
156
157			/**
158			* @expectedException \LogicException
159			* @expectedExceptionMessage The setting `foo` was found but it is not an experiment
160			*/
161			public function testGetCachedExperimentException()
162			{
163			$this->getSettingsManager()->getCachedExperiment('foo');
164			}
165
166			/**
167			* @return SettingsManager
168			*/
169			private function getSettingsManager()
170			{
171			if (!empty($this->settingsManager)) {
172			$this->settingsManager->getCache()->deleteAll();
173			return $this->settingsManager;
174			}
175
176			/** @var SettingsManager $manager */
177			$manager = $this->getContainer()->get('ongr_settings.settings_manager');
178			$manager->setActiveExperimentsSettingName('active_experiments');
179
180			$this->settingsManager = $manager;
181
182			return $this->settingsManager;
183			}
184
185			/**
186			* {@inheritdoc}
187			*/
188			protected function tearDown()
189			{
190			parent::tearDown();
191
192			// Deletes the settings manager cache
193			$this->getSettingsManager();
194			}
195			}
196

ongr-io / SettingsBundle

Pull Request — master (#177)

SettingsManagerTest::getDataArray() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like