Completed
Pull Request — master (#153)
by
unknown
26:31
created
Event/SettingChangeEvent.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
     /**
27 27
      * Constructor.
28 28
      *
29
-     * @param Action $action
29
+     * @param string $action
30 30
      */
31 31
     public function __construct($action)
32 32
     {
Please login to merge, or discard this patch.
Settings/General/SettingsContainer.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@
 block discarded – undo
120 120
     }
121 121
 
122 122
     /**
123
-     * @param array $profiles
123
+     * @param string[] $profiles
124 124
      */
125 125
     public function setProfiles($profiles)
126 126
     {
Please login to merge, or discard this patch.
Settings/General/SettingsManager.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,6 @@
 block discarded – undo
17 17
 use ONGR\ElasticsearchBundle\ORM\Manager;
18 18
 use ONGR\SettingsBundle\Document\Setting;
19 19
 use ONGR\SettingsBundle\Event\SettingChangeEvent;
20
-use Exception;
21 20
 
22 21
 /**
23 22
  * Class SettingsManager responsible for managing settings actions.
Please login to merge, or discard this patch.
Tests/Functional/Controller/PersonalSettingsControllerTest.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -12,8 +12,6 @@
 block discarded – undo
12 12
 namespace ONGR\SettingsBundle\Tests\Functional\Controller;
13 13
 
14 14
 use ONGR\SettingsBundle\Tests\Fixtures\Security\LoginTestHelper;
15
-use ONGR\SettingsBundle\Tests\Functional\PreparePersonalData;
16
-use ONGR\SettingsBundle\Tests\Functional\PrepareAdminData;
17 15
 use ONGR\ElasticsearchBundle\Test\ElasticsearchTestCase;
18 16
 use Symfony\Bundle\FrameworkBundle\Client;
19 17
 
Please login to merge, or discard this patch.
Tests/Functional/Twig/GeneralSettingsWidgetExtensionTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,6 @@
 block discarded – undo
12 12
 namespace ONGR\SettingsBundle\Tests\Functional\Twig;
13 13
 
14 14
 use ONGR\SettingsBundle\Exception\SettingNotFoundException;
15
-use ONGR\SettingsBundle\Settings\Personal\PersonalSettingsManager;
16 15
 use ONGR\SettingsBundle\Twig\GeneralSettingsWidgetExtension;
17 16
 use ONGR\SettingsBundle\Tests\Fixtures\Security\LoginTestHelper;
18 17
 use ONGR\SettingsBundle\Settings\General\SettingsContainerInterface;
Please login to merge, or discard this patch.
Tests/Functional/Twig/PersonalSettingWidgetExtensionTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,6 @@
 block discarded – undo
15 15
 use ONGR\SettingsBundle\Tests\Fixtures\Security\LoginTestHelper;
16 16
 use ONGR\ElasticsearchBundle\Test\ElasticsearchTestCase;
17 17
 use Symfony\Bundle\FrameworkBundle\Client;
18
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
19 18
 
20 19
 /**
21 20
  * Tests for testing settings TWIG extension functionality.
Please login to merge, or discard this patch.
Unit/DependencyInjection/Security/SessionlessAuthenticationFactoryTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@
 block discarded – undo
66 66
     }
67 67
 
68 68
     /**
69
-     * @return array
69
+     * @return string[]
70 70
      */
71 71
     public function getFirewallsDetails()
72 72
     {
Please login to merge, or discard this patch.
Tests/Unit/Settings/General/SettingsContainerTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -108,7 +108,7 @@
 block discarded – undo
108 108
      * @param bool  $miss
109 109
      * @param array $settings
110 110
      *
111
-     * @return \PHPUnit_Framework_MockObject_MockObject|PoolInterface
111
+     * @return PoolInterface
112 112
      */
113 113
     private function getPool($miss = true, $settings = [])
114 114
     {
Please login to merge, or discard this patch.
Tests/Unit/Settings/General/SettingsManagerTest.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
     /**
128 128
      * Returns mock of SettingsManager.
129 129
      *
130
-     * @param object $ormManagerMock
130
+     * @param Manager $ormManagerMock
131 131
      *
132 132
      * @return SettingsManager
133 133
      */
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
     /**
144 144
      * Returns mock of event dispatcher.
145 145
      *
146
-     * @return EventDispatcherInterface|MockObject
146
+     * @return EventDispatcherInterface
147 147
      */
148 148
     protected function getEventDispatcherMock()
149 149
     {
Please login to merge, or discard this patch.