ongr-io / SettingsBundle

Tests/Functional/Twig/PersonalSettingWidgetExtensionTest.php

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 use ONGR\SettingsBundle\Tests\Fixtures\Security\LoginTestHelper;
 use ONGR\ElasticsearchBundle\Test\ElasticsearchTestCase;
 use Symfony\Bundle\FrameworkBundle\Client;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 
 /**
  * Tests for testing settings TWIG extension functionality.

Controller/SettingsManagerController.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 
 use ONGR\SettingsBundle\Settings\General\SettingsManager;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
-use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;

ONGRSettingsBundle.php

Unused Use Statements -1 removed lines

@@ -17,7 +17,6 @@
 use ONGR\SettingsBundle\DependencyInjection\Compiler\SettingAwareFactoryPass;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\HttpKernel\Bundle\Bundle;
-use ONGR\SettingsBundle\DependencyInjection\Security\SessionlessAuthenticationFactory;
 
 /**
  * This class is used to register component into Symfony app kernel.

Tests/Functional/Controller/PersonalSettingsControllerTest.php

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 namespace ONGR\SettingsBundle\Tests\Functional\Controller;
 
 use ONGR\ElasticsearchBundle\Test\AbstractElasticsearchTestCase;
-use ONGR\SettingsBundle\Tests\Fixtures\Security\LoginTestHelper;
 use Symfony\Bundle\FrameworkBundle\Client;
 
 /**

Settings/General/SettingsManager.php

Spacing +4 added lines, -4 removed lines

@@ -74,7 +74,7 @@ 
     {
         foreach ($profiles as $profile) {
             $setting = new Setting();
-            $setting->setId($profile . '_' . $name);
+            $setting->setId($profile.'_'.$name);
             $setting->setName($name);
             $setting->setDescription($description);
             $setting->setData((object)['value' => $value]);
@@ -130,7 +130,7 @@ 
         foreach ($newProfiles as $profile) {
             $newSetting = clone $setting;
 
-            $newSetting->setId($profile . '_' . $setting->getName());
+            $newSetting->setId($profile.'_'.$setting->getName());
             $newSetting->setProfile($profile);
             $newSettings[] = $newSetting;
         }
@@ -152,7 +152,7 @@ 
      */
     public function get($name, $profile = 'default', $mustExist = true, $type = 'string')
     {
-        $setting = $this->repo->find($profile . '_' . $name);
+        $setting = $this->repo->find($profile.'_'.$name);
         if ($setting === null) {
             if ($mustExist === true) {
                 throw new \UnexpectedValueException();
@@ -175,7 +175,7 @@ 
     protected function createSetting($name, $profile, $type)
     {
         $setting = new Setting();
-        $setting->setId($profile . '_' . $name);
+        $setting->setId($profile.'_'.$name);
         $setting->setName($name);
         $setting->setProfile($profile);
         $setting->setType($type);

Settings/Personal/PersonalProfilesProvider.php

Spacing +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
 
         $settings = [];
         foreach ($profiles as $profile) {
-            $profileId = 'ongr_settings_profile_' . UnderscoreEscaper::escape($profile['name']);
+            $profileId = 'ongr_settings_profile_'.UnderscoreEscaper::escape($profile['name']);
             $settings[$profileId] = [
                 'name' => $profile['name'],
                 'category' => 'ongr_settings_profiles',

DependencyInjection/ONGRSettingsExtension.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
         // Set profiles.
         $container->setParameter('ongr_settings.settings_container.profiles', $config['profiles']);
 
-        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
+        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
         $loader->load('services/twig_extension.yml');
         $loader->load('services/personal_settings.yml');
         $loader->load('services/general_settings.yml');

Twig/HiddenExtension.php

Spacing +1 added lines, -1 removed lines

@@ -110,7 +110,7 @@
                 foreach ($value as $value2) {
                     if (!is_array($value2)) {
                         $new[] = [
-                            'name' => $name . '[]',
+                            'name' => $name.'[]',
                             'value' => $value2,
                         ];
                     }

Service/FormValidator.php

Spacing +1 added lines, -2 removed lines

@@ -44,8 +44,7 @@
         switch ($return['type']) {
             case 'bool':
                 $request->request->get('setting-boolean') == 'true' ?
-                    $return['value'] = true :
-                    $return['value'] = false;
+                    $return['value'] = true : $return['value'] = false;
                 break;
             case 'string':
                 $return['value'] = $request->request->get('setting-default');