PersonalSettingsControllerTest - Code Metrics - Inspection of "[WIP] Refactoring front end" - ongr-io/SettingsBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#168)

unknown

created 2016-04-14 13:00 UTC

PersonalSettingsControllerTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	5
Bugs	0	Features	0

Metric	Value
wmc	3
c	5
b	0
f	0
lcom	1
cbo	2
dl	0
loc	41
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	5	1
A	testSettingsAction()	0	21	2

<?php

/*
 * This file is part of the ONGR package.
 *
 * (c) NFQ Technologies UAB <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ONGR\SettingsBundle\Tests\Functional\Controller;

use ONGR\ElasticsearchBundle\Test\AbstractElasticsearchTestCase;
use ONGR\SettingsBundle\Tests\Fixtures\Security\LoginTestHelper;
use Symfony\Bundle\FrameworkBundle\Client;

/**
 * Tests for SettingsController.
 */
class PersonalSettingsControllerTest extends AbstractElasticsearchTestCase
{
    /**
     * @var Client.
     */
    private $client;

    /**
     * {@inheritdoc}
     */
    protected function setUp()
    {
        parent::setUp();
        $this->client = static::createClient();
    }

    /**
     * Test settings page ability to set values to cookie.
     */
    public function testSettingsAction()
    {
        $this->getManager();
        /** @var Client $client */
        $client = $this->client;

        // Visit settings page.
        $crawler = $client->request('GET', '/settings/settings');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        // Assert categories are rendered.
        /** @var array $categories */
        $categories = $client->getContainer()->getParameter('ongr_settings.settings.categories');
        $content = $client->getResponse()->getContent();
        unset($categories['ongr_settings_profiles']);

        // Print $content.
        foreach ($categories as $category) {
            $this->assertContains($category['name'], $content);
        }

    }
}


1			<?php
2
3			/*
4			* This file is part of the ONGR package.
5			*
6			* (c) NFQ Technologies UAB <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace ONGR\SettingsBundle\Tests\Functional\Controller;
13
14			use ONGR\ElasticsearchBundle\Test\AbstractElasticsearchTestCase;
15			use ONGR\SettingsBundle\Tests\Fixtures\Security\LoginTestHelper;
16			use Symfony\Bundle\FrameworkBundle\Client;
17
18			/**
19			* Tests for SettingsController.
20			*/
21			class PersonalSettingsControllerTest extends AbstractElasticsearchTestCase
22			{
23			/**
24			* @var Client.
25			*/
26			private $client;
27
28			/**
29			* {@inheritdoc}
30			*/
31			protected function setUp()
32			{
33			parent::setUp();
34			$this->client = static::createClient();
35			}
36
37			/**
38			* Test settings page ability to set values to cookie.
39			*/
40			public function testSettingsAction()
41			{
42			$this->getManager();
43			/** @var Client $client */
44			$client = $this->client;
45
46			// Visit settings page.
47			$crawler = $client->request('GET', '/settings/settings');
			0 ignored issues – show Unused Code introduced 2016-04-13 19:47 UTC by Report Bug Copy Issue Report `$crawler` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
48
49			// Assert categories are rendered.
50			/** @var array $categories */
51			$categories = $client->getContainer()->getParameter('ongr_settings.settings.categories');
52			$content = $client->getResponse()->getContent();
53			unset($categories['ongr_settings_profiles']);
54
55			// Print $content.
56			foreach ($categories as $category) {
57			$this->assertContains($category['name'], $content);
58			}
59
60			}
61			}
62

ongr-io / SettingsBundle

Pull Request — master (#168)

PersonalSettingsControllerTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like