$normalized was never initialized. Although not strictly required by PHP, it is generally a good practice to add $normalized = array(); before regardless.
Adding an explicit array definition is generally preferable to implicit array
definition as it guarantees a stable state of the code.
Let’s take a look at an example:
foreach($collectionas$item){$myArray['foo']=$item->getFoo();if($item->hasBar()){$myArray['bar']=$item->getBar();}// do something with $myArray}
As you can see in this example, the array $myArray is initialized the first
time when the foreach loop is entered. You can also see that the value of the
bar key is only written conditionally; thus, its value might result from a
previous iteration.
This might or might not be intended. To make your intention clear, your code
more readible and to avoid accidental bugs, we recommend to add an explicit
initialization $myArray=array() either outside or inside the foreach loop.
Loading history...
49
$normalized[$lt] = $values[1];
50
51
$state->setValue($normalized);
52
53
return $state;
54
}
55
56
/**
57
* {@inheritdoc}
58
*/
59
public function preProcessSearch(Search $search, Search $relatedSearch, FilterState $state = null)
60
{
61
$stateAgg = new StatsAggregation($state->getName());
62
$stateAgg->setField($this->getDocumentField());
63
$search->addAggregation($stateAgg);
64
}
65
66
/**
67
* {@inheritdoc}
68
*/
69
public function getViewData(DocumentIterator $result, ViewData $data)
ongr-io /
FilterManagerBundle
Aivaras Gotovskis
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.
Let’s take a look at an example:
As you can see in this example, the array
$myArrayis initialized the first time when the foreach loop is entered. You can also see that the value of thebarkey is only written conditionally; thus, its value might result from a previous iteration.This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.