Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like DynamicAggregate often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use DynamicAggregate, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 39 | class DynamicAggregate extends AbstractSingleRequestValueFilter implements |
||
| 40 | FieldAwareInterface, |
||
| 41 | ViewDataFactoryInterface |
||
| 42 | { |
||
| 43 | use FieldAwareTrait; |
||
| 44 | |||
| 45 | /** |
||
| 46 | * @var array |
||
| 47 | */ |
||
| 48 | private $sortType; |
||
| 49 | |||
| 50 | /** |
||
| 51 | * @var string |
||
| 52 | */ |
||
| 53 | private $nameField; |
||
| 54 | |||
| 55 | /** |
||
| 56 | * @var bool |
||
| 57 | */ |
||
| 58 | private $showZeroChoices; |
||
| 59 | |||
| 60 | /** |
||
| 61 | * @param array $sortType |
||
| 62 | */ |
||
| 63 | public function setSortType($sortType) |
||
| 67 | |||
| 68 | /** |
||
| 69 | * @return array |
||
| 70 | */ |
||
| 71 | public function getSortType() |
||
| 75 | |||
| 76 | /** |
||
| 77 | * @return string |
||
| 78 | */ |
||
| 79 | public function getNameField() |
||
| 83 | |||
| 84 | /** |
||
| 85 | * @param string $nameField |
||
| 86 | */ |
||
| 87 | public function setNameField($nameField) |
||
| 91 | |||
| 92 | /** |
||
| 93 | * @return bool |
||
| 94 | */ |
||
| 95 | public function getShowZeroChoices() |
||
| 96 | { |
||
| 97 | return $this->showZeroChoices; |
||
| 98 | } |
||
| 99 | |||
| 100 | /** |
||
| 101 | * @param bool $showZeroChoices |
||
| 102 | */ |
||
| 103 | public function setShowZeroChoices($showZeroChoices) |
||
| 104 | { |
||
| 105 | $this->showZeroChoices = $showZeroChoices; |
||
| 106 | } |
||
| 107 | |||
| 108 | /** |
||
| 109 | * {@inheritdoc} |
||
| 110 | */ |
||
| 111 | public function getState(Request $request) |
||
| 124 | |||
| 125 | /** |
||
| 126 | * {@inheritdoc} |
||
| 127 | */ |
||
| 128 | public function modifySearch(Search $search, FilterState $state = null, SearchRequest $request = null) |
||
| 145 | |||
| 146 | /** |
||
| 147 | * {@inheritdoc} |
||
| 148 | */ |
||
| 149 | public function preProcessSearch(Search $search, Search $relatedSearch, FilterState $state = null) |
||
| 204 | |||
| 205 | /** |
||
| 206 | * {@inheritdoc} |
||
| 207 | */ |
||
| 208 | public function createViewData() |
||
| 212 | |||
| 213 | /** |
||
| 214 | * {@inheritdoc} |
||
| 215 | */ |
||
| 216 | public function getViewData(DocumentIterator $result, ViewData $data) |
||
| 279 | |||
| 280 | /** |
||
| 281 | * {@inheritdoc} |
||
| 282 | */ |
||
| 283 | public function isRelated() |
||
| 287 | |||
| 288 | /** |
||
| 289 | * Fetches buckets from search results. |
||
| 290 | * |
||
| 291 | * @param DocumentIterator $result Search results. |
||
| 292 | * @param string $filterName Filter name. |
||
| 293 | * @param array $values Values from the state object |
||
| 294 | * |
||
| 295 | * @return array Buckets. |
||
| 296 | */ |
||
| 297 | protected function fetchAggregation(DocumentIterator $result, $filterName, $values) |
||
| 311 | |||
| 312 | /** |
||
| 313 | * A method used to add an additional filter to the aggregations |
||
| 314 | * in preProcessSearch |
||
| 315 | * |
||
| 316 | * @param FilterAggregation $filterAggregation |
||
| 317 | * @param NestedAggregation $deepLevelAggregation |
||
| 318 | * @param array $terms Terms of additional filter |
||
| 319 | * @param string $aggName |
||
| 320 | * |
||
| 321 | * @return BuilderInterface |
||
| 322 | */ |
||
| 323 | View Code Duplication | protected function addSubFilterAggregation( |
|
| 349 | |||
| 350 | /** |
||
| 351 | * @param string $key |
||
| 352 | * @param string $name |
||
| 353 | * @param ViewData $data |
||
| 354 | * @param bool $active True when the choice is active |
||
| 355 | * |
||
| 356 | * @return array |
||
| 357 | */ |
||
| 358 | protected function getOptionUrlParameters($key, $name, ViewData $data, $active) |
||
| 378 | |||
| 379 | /** |
||
| 380 | * Returns whether choice with the specified key is active. |
||
| 381 | * |
||
| 382 | * @param string $key |
||
| 383 | * @param ViewData $data |
||
| 384 | * @param string $activeName |
||
| 385 | * |
||
| 386 | * @return bool |
||
| 387 | */ |
||
| 388 | protected function isChoiceActive($key, ViewData $data, $activeName) |
||
| 392 | |||
| 393 | /** |
||
| 394 | * Forms $unsortedChoices array with all possible choices. |
||
| 395 | * 0 is assigned to the document count of the choices. |
||
| 396 | * |
||
| 397 | * @param DocumentIterator $result |
||
| 398 | * @param ViewData $data |
||
| 399 | * |
||
| 400 | * @return array |
||
| 401 | */ |
||
| 402 | private function formInitialUnsortedChoices($result, $data) |
||
| 423 | } |
||
| 424 |
If a variable is not always an object, we recommend to add an additional type check to ensure your method call is safe: