ONGR\FilterManagerBundle\Filter\Widget\Dynamic\Dynamic

Complexity

Total Complexity

27

Size/Duplication

Total Lines	193
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes	9
Bugs	0	Features	5

11 Methods

Rating	Name	Duplication	Size	Complexity
C	getState()	0	39	7
A	modifySearch()	0	6	3
A	preProcessSearch()	0	11	3
B	getViewData()	0	30	5
A	createViewData()	0	10	3
A	getTags()	0	4	1
A	setTags()	0	4	1
A	getRequestField()	0	4	1
A	setRequestField()	0	4	1
A	getFilters()	0	4	1
A	setFilters()	0	4	1

<?php

/*
 * This file is part of the ONGR package.
 *
 * (c) NFQ Technologies UAB <info@nfq.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ONGR\FilterManagerBundle\Filter\Widget\Dynamic;

use ONGR\ElasticsearchBundle\Result\DocumentIterator;
use ONGR\ElasticsearchBundle\Mapping\Caser;
use ONGR\ElasticsearchDSL\Search;
use ONGR\FilterManagerBundle\Filter\FilterInterface;
use ONGR\FilterManagerBundle\Filter\FilterState;
use ONGR\FilterManagerBundle\Filter\Helper\ViewDataFactoryInterface;
use ONGR\FilterManagerBundle\Filter\Relation\RelationAwareTrait;
use ONGR\FilterManagerBundle\Filter\ViewData;
use ONGR\FilterManagerBundle\Filter\ViewData\ChoicesAwareViewData;
use ONGR\FilterManagerBundle\Search\SearchRequest;
use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException;
use Symfony\Component\HttpFoundation\Request;

/**
 * This class provides sorting filter.
 */
class Dynamic implements FilterInterface, ViewDataFactoryInterface
{
    use RelationAwareTrait;

    /**
     * @var string
     */
    private $requestField;

    /**
     * @var FilterInterface
     */
    private $filter;

    /**
     * @var FilterInterface[]
     */
    private $filters;

    /**
     * @var array
     */
    private $urlParameters;

    /**
     * @var array
     */
    private $tags = [];

    /**
     * {@inheritdoc}
     */
    public function getState(Request $request)
    {
        $state = new FilterState();
        $value = $request->get($this->getRequestField());
        $this->urlParameters[$this->getRequestField()] = $value;

        if (isset($value) && is_array($value)) {
            if (empty($this->filters)) {
                throw new InvalidConfigurationException('No filters provided to dynamic filter');
            }

            if (isset($value['filter'])) {
                if (isset($this->filters[$value['filter']])) {
                    $this->filter = clone $this->filters[$value['filter']];
                } else {
                    throw new InvalidConfigurationException(
                        sprintf('Filter `%s`, requested in dynamic filter not defined', $value['filter'])
                    );
                }
            } else {
                $this->filter = clone reset($this->filters);

It seems like clone reset($this->filters) can also be of type false. However, the property $filter is declared as type object<ONGR\FilterManagerBundle\Filter\FilterInterface>. Maybe add an additional type check?

            }

            $this->filter->setRequestField($this->getRequestField());

            if (isset($value['field'])) {
                $this->filter->setField($value['field']);

It seems like you code against a concrete implementation and not the interface ONGR\FilterManagerBundle\Filter\FilterInterface as the method setField() does only exist in the following implementations of said interface: ONGR\FilterManagerBundle\Filter\Widget\Choice\MultiTermChoice, ONGR\FilterManagerBundle\Filter\Widget\Choice\SingleTermChoice, ONGR\FilterManagerBundle\Filter\Widget\Range\AbstractRange, ONGR\FilterManagerBundle\Filter\Widget\Range\DateRange, ONGR\FilterManagerBundle\Filter\Widget\Range\Range, ONGR\FilterManagerBundle\Filter\Widget\Search\AbstractSingleValue, ONGR\FilterManagerBundle\Filter\Widget\Search\DocumentValue, ONGR\FilterManagerBundle\Filter\Widget\Search\FieldValue, ONGR\FilterManagerBundle\Filter\Widget\Search\FuzzySearch, ONGR\FilterManagerBundle\Filter\Widget\Search\MatchSearch.

            }

            $request = new Request(
                [
                    $this->getRequestField() => $this->urlParameters[$this->getRequestField()]['value']
                ]
            );
            $state = $this->filter->getState($request);
        }

        return $state;
    }

    /**
     * {@inheritdoc}
     */
    public function modifySearch(Search $search, FilterState $state = null, SearchRequest $request = null)
    {
        if ($state && $state->isActive()) {
            $this->filter->modifySearch($search, $state, $request);
        }
    }

    /**
     * {@inheritdoc}
     */
    public function preProcessSearch(Search $search, Search $relatedSearch, FilterState $state = null)
    {
        $out = null;

        if ($state && $state->isActive()) {
            $out = $this->filter->preProcessSearch($search, $relatedSearch, $state);
            $state->setUrlParameters($this->urlParameters);
        }

        return $out;
    }

    /**
     * {@inheritdoc}
     */
    public function getViewData(DocumentIterator $result, ViewData $data)
    {
        if ($this->filter) {
            $data = $this->filter->getViewData($result, $data);

            if ($data instanceof ChoicesAwareViewData) {
                $choices = [];

                foreach ($data->getChoices() as $choice) {
                    $urlParameters = $this->urlParameters;
                    $choiceParameters = $choice->getUrlParameters();
                    $value = null;

                    if (isset($choiceParameters[$this->getRequestField()])) {
                        $value = $choiceParameters[$this->getRequestField()];
                    }

                    $urlParameters[$this->getRequestField()]['value'] = $value;
                    $choiceParameters[$this->getRequestField()] = $urlParameters[$this->getRequestField()];

                    $choice->setUrlParameters($choiceParameters);
                    $choices[] = $choice;
                }

                $data->setChoices($choices);
            }
        }

        return $data;
    }

    /**
     * {@inheritdoc}
     */
    public function createViewData()
    {
        if ($this->filter and $this->filter instanceof ViewDataFactoryInterface) {

Using logical operators such as and instead of && is generally not recommended.

            $data = $this->filter->createViewData();
        } else {
            $data = new ViewData();
        }

        return $data;
    }

    /**
     * {@inheritdoc}
     */
    public function getTags()
    {
        return $this->tags;
    }

    /**
     * @param array $tags
     */
    public function setTags(array $tags)
    {
        $this->tags = $tags;
    }

    /**
     * @return mixed
     */
    public function getRequestField()
    {
        return $this->requestField;
    }

    /**
     * @param mixed $requestField
     */
    public function setRequestField($requestField)
    {
        $this->requestField = $requestField;
    }

    /**
     * @return FilterInterface[]
     */
    public function getFilters()
    {
        return $this->filters;
    }

    /**
     * @param FilterInterface[] $filters
     */
    public function setFilters($filters)
    {
        $this->filters = $filters;
    }
}