DocumentValue::getState() - Code Metrics - Inspection of "Fix for property if it is private in the document" - ongr-io/FilterManagerBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#208)

by Simonas

created 2016-11-14 08:30 UTC

DocumentValue::getState() A

↳ Parent: DocumentValue

Complexity

Conditions	3
Paths	4

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	9
nc	4
nop	1

<?php

/*
 * This file is part of the ONGR package.
 *
 * (c) NFQ Technologies UAB <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ONGR\FilterManagerBundle\Filter\Widget\Search;

use ONGR\ElasticsearchDSL\Query\TermQuery;
use ONGR\ElasticsearchDSL\Search;
use ONGR\FilterManagerBundle\Filter\FilterState;
use ONGR\FilterManagerBundle\Filter\Relation\RelationAwareTrait;
use ONGR\FilterManagerBundle\Search\SearchRequest;
use Symfony\Component\HttpFoundation\Request;

/**
 * Filter for filtering on exact value in specified field.
 */
class DocumentValue extends AbstractSingleValue
{

    use RelationAwareTrait;

    /**
     * {@inheritdoc}
     */
    public function getState(Request $request)
    {
        $state = new FilterState();
        $document = $request->get('document');

        if (is_object($document)) {
            try {
                $state->setValue(function ($document) {return $document->{$this->getOption('field')};});
                $state->setActive(true);
            } catch (\Exception $e) {}

        }

        return $state;
    }

    /**
     * {@inheritdoc}
     */
    public function modifySearch(Search $search, FilterState $state = null, SearchRequest $request = null)
    {
        $search->addPostFilter(new TermQuery($this->getDocumentField(), $state->getValue()));
function someFunction(A $objectMaybe = null)
{
    if ($objectMaybe instanceof A) {
        $objectMaybe->doSomething();
    }
}
    }
}


1			<?php
2
3			/*
4			* This file is part of the ONGR package.
5			*
6			* (c) NFQ Technologies UAB <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace ONGR\FilterManagerBundle\Filter\Widget\Search;
13
14			use ONGR\ElasticsearchDSL\Query\TermQuery;
15			use ONGR\ElasticsearchDSL\Search;
16			use ONGR\FilterManagerBundle\Filter\FilterState;
17			use ONGR\FilterManagerBundle\Filter\Relation\RelationAwareTrait;
18			use ONGR\FilterManagerBundle\Search\SearchRequest;
19			use Symfony\Component\HttpFoundation\Request;
20
21			/**
22			* Filter for filtering on exact value in specified field.
23			*/
24			class DocumentValue extends AbstractSingleValue
25			{
26
27			use RelationAwareTrait;
28
29			/**
30			* {@inheritdoc}
31			*/
32			public function getState(Request $request)
33			{
34			$state = new FilterState();
35			$document = $request->get('document');
36
37			if (is_object($document)) {
38			try {
39			$state->setValue(function ($document) {return $document->{$this->getOption('field')};});
40			$state->setActive(true);
41			} catch (\Exception $e) {}
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-11-14 09:27 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
42			}
43
44			return $state;
45			}
46
47			/**
48			* {@inheritdoc}
49			*/
50			public function modifySearch(Search $search, FilterState $state = null, SearchRequest $request = null)
51			{
52			$search->addPostFilter(new TermQuery($this->getDocumentField(), $state->getValue()));
			0 ignored issues – show Bug introduced 2016-11-14 09:27 UTC by Report Bug Copy Issue Report It seems like `$state` is not always an object, but can also be of type `null`. Maybe add an additional type check? If a variable is not always an object, we recommend to add an additional type check to ensure your method call is safe: function someFunction(A $objectMaybe = null) { if ($objectMaybe instanceof A) { $objectMaybe->doSomething(); } } Loading history...
53			}
54			}
55

ongr-io / FilterManagerBundle

Pull Request — master (#208)

DocumentValue::getState() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like