AbstractSingleRequestValueFilter::getState() - Code Metrics - Inspection of "Replace plural to singular in namespaces and class..." - ongr-io/FilterManagerBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#144)

by Mantas

created 2015-12-22 13:16 UTC

AbstractSingleRequestValueFilter::getState() A

↳ Parent: AbstractSingleRequestValueFilter

Complexity

Conditions	4
Paths	3

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	14
rs	9.2
cc	4
eloc	9
nc	3
nop	1

<?php

/*
 * This file is part of the ONGR package.
 *
 * (c) NFQ Technologies UAB <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ONGR\FilterManagerBundle\Filter\Widget;

use ONGR\FilterManagerBundle\Filter\FilterInterface;
use ONGR\FilterManagerBundle\Filter\FilterState;
use ONGR\FilterManagerBundle\Filter\Relation\RelationAwareTrait;
use Symfony\Component\HttpFoundation\Request;

/**
 * This class generalises filters using single field value from request.
 */
abstract class AbstractSingleRequestValueFilter implements FilterInterface
{
    use RelationAwareTrait;

    /**
     * @var string
     */
    private $requestField;

    /**
     * @var array
     */
    private $tags = [];

    /**
     * {@inheritdoc}
     */
    public function getState(Request $request)
    {
        $state = new FilterState();
        $value = $request->get($this->getRequestField());

        if (isset($value) && $value !== '') {
            $value = is_array($value) ? array_values($value) : $value;
            $state->setActive(true);
            $state->setValue($value);
            $state->setUrlParameters([$this->getRequestField() => $value]);
        }

        return $state;
    }

    /**
     * @return string
     */
    public function getRequestField()
    {
        return $this->requestField;
    }

    /**
     * @param string $requestField
     */
    public function setRequestField($requestField)
    {
        $this->requestField = $requestField;
    }

    /**
     * @return string
     */
    public function getTags()
    {
        return $this->tags;
    }

    /**
     * @param string $tags
     */
    public function setTags($tags)
    {
        $this->tags = $tags;

    }
}


1			<?php
2
3			/*
4			* This file is part of the ONGR package.
5			*
6			* (c) NFQ Technologies UAB <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace ONGR\FilterManagerBundle\Filter\Widget;
13
14			use ONGR\FilterManagerBundle\Filter\FilterInterface;
15			use ONGR\FilterManagerBundle\Filter\FilterState;
16			use ONGR\FilterManagerBundle\Filter\Relation\RelationAwareTrait;
17			use Symfony\Component\HttpFoundation\Request;
18
19			/**
20			* This class generalises filters using single field value from request.
21			*/
22			abstract class AbstractSingleRequestValueFilter implements FilterInterface
23			{
24			use RelationAwareTrait;
25
26			/**
27			* @var string
28			*/
29			private $requestField;
30
31			/**
32			* @var array
33			*/
34			private $tags = [];
35
36			/**
37			* {@inheritdoc}
38			*/
39			public function getState(Request $request)
40			{
41			$state = new FilterState();
42			$value = $request->get($this->getRequestField());
43
44			if (isset($value) && $value !== '') {
45			$value = is_array($value) ? array_values($value) : $value;
46			$state->setActive(true);
47			$state->setValue($value);
48			$state->setUrlParameters([$this->getRequestField() => $value]);
49			}
50
51			return $state;
52			}
53
54			/**
55			* @return string
56			*/
57			public function getRequestField()
58			{
59			return $this->requestField;
60			}
61
62			/**
63			* @param string $requestField
64			*/
65			public function setRequestField($requestField)
66			{
67			$this->requestField = $requestField;
68			}
69
70			/**
71			* @return string
72			*/
73			public function getTags()
74			{
75			return $this->tags;
76			}
77
78			/**
79			* @param string $tags
80			*/
81			public function setTags($tags)
82			{
83			$this->tags = $tags;
			0 ignored issues – show Documentation Bug introduced 2015-12-15 14:55 UTC by Report Bug Copy Issue Report It seems like `$tags` of type `string` is incompatible with the declared type `array` of property `$tags`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
84			}
85			}
86

ongr-io / FilterManagerBundle

Pull Request — master (#144)

AbstractSingleRequestValueFilter::getState() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like