ONGR\FilterManagerBundle\Filter\Widget\Range\DateRange

Complexity

Total Complexity

6

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	6

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getState()	0	17	4
A	preProcessSearch()	0	6	1
A	getViewData()	0	13	1

<?php

/*
 * This file is part of the ONGR package.
 *
 * (c) NFQ Technologies UAB <info@nfq.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ONGR\FilterManagerBundle\Filter\Widget\Range;

use ONGR\ElasticsearchDSL\Aggregation\StatsAggregation;
use ONGR\ElasticsearchDSL\Search;
use ONGR\ElasticsearchBundle\Result\DocumentIterator;
use ONGR\FilterManagerBundle\Filter\FilterState;
use ONGR\FilterManagerBundle\Filter\ViewData;
use ONGR\FilterManagerBundle\Filter\ViewData\RangeAwareViewData;
use Symfony\Component\HttpFoundation\Request;

/**
 * Date range filter, selects documents from lower date to upper date.
 */
class DateRange extends AbstractRange
{
    /**
     * {@inheritdoc}
     */
    public function getState(Request $request)
    {
        $state = parent::getState($request);

        if ($state->getValue()) {
            $values = explode(';', $state->getValue(), 2);
            $gt = $this->isInclusive() ? 'gte' : 'gt';
            $lt = $this->isInclusive() ? 'lte' : 'lt';

            $normalized[$gt] = $values[0];

$normalized was never initialized. Although not strictly required by PHP, it is generally a good practice to add $normalized = array(); before regardless.

            $normalized[$lt] = $values[1];

            $state->setValue($normalized);
        }

        return $state;
    }

    /**
     * {@inheritdoc}
     */
    public function preProcessSearch(Search $search, Search $relatedSearch, FilterState $state = null)
    {
        $stateAgg = new StatsAggregation('date_range_agg');
        $stateAgg->setField($this->getField());
        $search->addAggregation($stateAgg);
    }

    /**
     * {@inheritdoc}
     */
    public function getViewData(DocumentIterator $result, ViewData $data)
    {
        /** @var $data RangeAwareViewData */
        $data->setMinBounds(
            new \DateTime('@' . (int) ($result->getAggregation('date_range_agg')->getValue()['min'] / 1000))

The method getValue does only exist in ONGR\ElasticsearchBundle\Result\Aggregation\ValueAggregation, but not in ONGR\ElasticsearchBundle\Result\Aggregation\AggregationIterator.

        );

        $data->setMaxBounds(
            new \DateTime('@' . (int) ($result->getAggregation('date_range_agg')->getValue()['max'] / 1000))
        );

        return $data;
    }
}