Issues in GeoBoundingBoxFilter.php - Fixed Issues - Inspection of "Merge pull request #58 from mvar/remove_filters" - ongr-io/ElasticsearchDSL - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 766668...5ee3f6 )

by Mantas

created 2016-01-26 08:14 UTC

src/Filter/GeoBoundingBoxFilter.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php


/*
 * This file is part of the ONGR package.
 *
 * (c) NFQ Technologies UAB <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ONGR\ElasticsearchDSL\Filter;

@trigger_error(
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
    'The GeoBoundingBoxFilter class is deprecated and will be removed in 2.0. Use GeoBoundingBoxQuery instead.',
    E_USER_DEPRECATED
);

use ONGR\ElasticsearchDSL\Query\GeoBoundingBoxQuery;

/**
 * Represents Elasticsearch "Geo Bounding Box" filter.
 *
 * @deprecated Will be removed in 2.0. Use the GeoBoundingBoxQuery instead.
 */
class GeoBoundingBoxFilter extends GeoBoundingBoxQuery
{
}


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2015-12-31 12:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 26 and the first side effect is on line 14. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3			/*
4			* This file is part of the ONGR package.
5			*
6			* (c) NFQ Technologies UAB <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace ONGR\ElasticsearchDSL\Filter;
13
14			@trigger_error(
			0 ignored issues – show Security Best Practice introduced 2015-12-31 12:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
15			'The GeoBoundingBoxFilter class is deprecated and will be removed in 2.0. Use GeoBoundingBoxQuery instead.',
16			E_USER_DEPRECATED
17			);
18
19			use ONGR\ElasticsearchDSL\Query\GeoBoundingBoxQuery;
20
21			/**
22			* Represents Elasticsearch "Geo Bounding Box" filter.
23			*
24			* @deprecated Will be removed in 2.0. Use the GeoBoundingBoxQuery instead.
25			*/
26			class GeoBoundingBoxFilter extends GeoBoundingBoxQuery
27			{
28			}
29

ongr-io / ElasticsearchDSL

Push — master ( 766668...5ee3f6 )

src/Filter/GeoBoundingBoxFilter.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like