| Conditions | 9 |
| Paths | 9 |
| Total Lines | 79 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 57 | if (!isset($indexClasses[$class])) { |
||
| 58 | throw new \RuntimeException( |
||
| 59 | sprintf( |
||
| 60 | 'Document `%s` defined in ongr_elasticsearch.indexes config could not been found', |
||
| 61 | $class, |
||
| 62 | ) |
||
|
|
|||
| 63 | ); |
||
| 64 | } |
||
| 65 | |||
| 66 | $indexSettings = $this->parseIndexSettingsFromClass($parser, $class); |
||
| 67 | |||
| 68 | if ($class !== $name) { |
||
| 69 | $indexSettings->setIndexName('ongr.es.index.'.$name); |
||
| 70 | } |
||
| 71 | |||
| 72 | if (isset($indexOverride['alias'])) { |
||
| 73 | $indexSettings->setAlias($indexOverride['alias']); |
||
| 74 | } |
||
| 75 | |||
| 76 | if (isset($indexOverride['settings'])) { |
||
| 77 | $indexSettings->setIndexMetadata($indexOverride['settings']); |
||
| 78 | } |
||
| 79 | |||
| 80 | if (isset($indexOverride['hosts'])) { |
||
| 81 | $indexSettings->setHosts($indexOverride['hosts']); |
||
| 82 | } |
||
| 83 | |||
| 84 | if (isset($indexOverride['default'])) { |
||
| 85 | $indexSettings->setDefaultIndex($indexOverride['default']); |
||
| 86 | } |
||
| 87 | |||
| 88 | $indexSettingsArray[$name] = $indexSettings; |
||
| 89 | $overwrittenClasses[$class] = $class; |
||
| 90 | } |
||
| 91 | |||
| 92 | foreach (array_diff($indexClasses, $overwrittenClasses) as $indexClass) { |
||
| 93 | try { |
||
| 94 | $indexSettingsArray[$indexClass] = $this->parseIndexSettingsFromClass($parser, $indexClass); |
||
| 95 | } catch (DocumentIndexParserException $e) {} |
||
| 96 | } |
||
| 97 | |||
| 98 | foreach($indexSettingsArray as $indexSettings) { |
||
| 99 | $this->createIndex($container, $indexSettings); |
||
| 100 | } |
||
| 101 | |||
| 102 | $container->setParameter(Configuration::ONGR_INDEXES, $this->indexes); |
||
| 103 | $container->setParameter( |
||
| 104 | Configuration::ONGR_DEFAULT_INDEX, |
||
| 105 | $this->defaultIndex ?? current(array_keys($this->indexes)) |
||
| 106 | ); |
||
| 107 | } |
||
| 108 | |||
| 109 | private function parseIndexSettingsFromClass(DocumentParser $parser, string $className) : IndexSettings |
||
| 110 | { |
||
| 111 | $class = new \ReflectionClass($className); |
||
| 112 | |||
| 113 | /** @var Index $document */ |
||
| 114 | $document = $parser->getIndexAnnotation($class); |
||
| 115 | |||
| 116 | if ($document === null) { |
||
| 117 | throw new DocumentIndexParserException(); |
||
| 118 | } |
||
| 119 | |||
| 120 | $indexSettings = new IndexSettings( |
||
| 121 | $className, |
||
| 122 | $className, |
||
| 123 | $parser->getIndexAliasName($class), |
||
| 124 | $parser->getIndexMetadata($class), |
||
| 125 | $parser->getPropertyMetadata($class), |
||
| 126 | $document->hosts, |
||
| 127 | $parser->isDefaultIndex($class) |
||
| 128 | ); |
||
| 129 | |||
| 130 | $indexSettings->setIndexMetadata(['settings' => [ |
||
| 131 | 'number_of_replicas' => $document->numberOfReplicas, |
||
| 132 | 'number_of_shards' => $document->numberOfShards, |
||
| 133 | ]]); |
||
| 134 | |||
| 135 | return $indexSettings; |
||
| 136 | } |
||
| 229 |