Complex classes like Manager often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Manager, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
28 | class Manager |
||
29 | { |
||
30 | /** |
||
31 | * @var string Manager name |
||
32 | */ |
||
33 | private $name; |
||
34 | |||
35 | /** |
||
36 | * @var array Manager configuration |
||
37 | */ |
||
38 | private $config = []; |
||
39 | |||
40 | /** |
||
41 | * @var Client |
||
42 | */ |
||
43 | private $client; |
||
44 | |||
45 | /** |
||
46 | * @var Converter |
||
47 | */ |
||
48 | private $converter; |
||
49 | |||
50 | /** |
||
51 | * @var bool |
||
52 | */ |
||
53 | private $readOnly; |
||
54 | |||
55 | /** |
||
56 | * @var array Container for bulk queries |
||
57 | */ |
||
58 | private $bulkQueries = []; |
||
59 | |||
60 | /** |
||
61 | * @var array Holder for consistency, refresh and replication parameters |
||
62 | */ |
||
63 | private $bulkParams = []; |
||
64 | |||
65 | /** |
||
66 | * @var array |
||
67 | */ |
||
68 | private $indexSettings; |
||
69 | |||
70 | /** |
||
71 | * @var MetadataCollector |
||
72 | */ |
||
73 | private $metadataCollector; |
||
74 | |||
75 | /** |
||
76 | * After commit to make data available the refresh or flush operation is needed |
||
77 | * so one of those methods has to be defined, the default is refresh. |
||
78 | * |
||
79 | * @var string |
||
80 | */ |
||
81 | private $commitMode = 'refresh'; |
||
82 | |||
83 | /** |
||
84 | * Reference to the persisted objects that need to be given an ID that returns from |
||
85 | * elasticsearch |
||
86 | * |
||
87 | * @var array |
||
88 | */ |
||
89 | private $persistedObjects = []; |
||
90 | |||
91 | /** |
||
92 | * The size that defines after how much document inserts call commit function. |
||
93 | * |
||
94 | * @var int |
||
95 | */ |
||
96 | private $bulkCommitSize = 100; |
||
97 | |||
98 | /** |
||
99 | * Container to count how many documents was passed to the bulk query. |
||
100 | * |
||
101 | * @var int |
||
102 | */ |
||
103 | private $bulkCount = 0; |
||
104 | |||
105 | /** |
||
106 | * @var Repository[] Repository local cache |
||
107 | */ |
||
108 | private $repositories; |
||
109 | |||
110 | /** |
||
111 | * @param string $name Manager name |
||
112 | * @param array $config Manager configuration |
||
113 | * @param Client $client |
||
114 | * @param array $indexSettings |
||
115 | * @param MetadataCollector $metadataCollector |
||
116 | * @param Converter $converter |
||
117 | */ |
||
118 | public function __construct( |
||
135 | |||
136 | /** |
||
137 | * Returns Elasticsearch connection. |
||
138 | * |
||
139 | * @return Client |
||
140 | */ |
||
141 | public function getClient() |
||
145 | |||
146 | /** |
||
147 | * @return string |
||
148 | */ |
||
149 | public function getName() |
||
153 | |||
154 | /** |
||
155 | * @return array |
||
156 | */ |
||
157 | public function getConfig() |
||
161 | |||
162 | /** |
||
163 | * Returns repository by document class. |
||
164 | * |
||
165 | * @param string $className FQCN or string in Bundle:Document format |
||
166 | * |
||
167 | * @return Repository |
||
168 | */ |
||
169 | public function getRepository($className) |
||
186 | |||
187 | /** |
||
188 | * @return MetadataCollector |
||
189 | */ |
||
190 | public function getMetadataCollector() |
||
194 | |||
195 | /** |
||
196 | * @return Converter |
||
197 | */ |
||
198 | public function getConverter() |
||
202 | |||
203 | /** |
||
204 | * @return string |
||
205 | */ |
||
206 | public function getCommitMode() |
||
210 | |||
211 | /** |
||
212 | * @param string $commitMode |
||
213 | */ |
||
214 | public function setCommitMode($commitMode) |
||
222 | |||
223 | /** |
||
224 | * @return int |
||
225 | */ |
||
226 | public function getBulkCommitSize() |
||
230 | |||
231 | /** |
||
232 | * @param int $bulkCommitSize |
||
233 | */ |
||
234 | public function setBulkCommitSize($bulkCommitSize) |
||
238 | |||
239 | /** |
||
240 | * Creates a repository. |
||
241 | * |
||
242 | * @param string $className |
||
243 | * |
||
244 | * @return Repository |
||
245 | */ |
||
246 | private function createRepository($className) |
||
250 | |||
251 | /** |
||
252 | * Executes search query in the index. |
||
253 | * |
||
254 | * @param array $types List of types to search in. |
||
255 | * @param array $query Query to execute. |
||
256 | * @param array $queryStringParams Query parameters. |
||
257 | * |
||
258 | * @return array |
||
259 | */ |
||
260 | public function search(array $types, array $query, array $queryStringParams = []) |
||
273 | |||
274 | /** |
||
275 | * Adds document to next flush. |
||
276 | * |
||
277 | * @param object $document |
||
278 | */ |
||
279 | public function persist($document) |
||
289 | |||
290 | /** |
||
291 | * Adds document for removal. |
||
292 | * |
||
293 | * @param object $document |
||
294 | */ |
||
295 | public function remove($document) |
||
309 | |||
310 | /** |
||
311 | * Flushes elasticsearch index. |
||
312 | * |
||
313 | * @param array $params |
||
314 | * |
||
315 | * @return array |
||
316 | */ |
||
317 | public function flush(array $params = []) |
||
321 | |||
322 | /** |
||
323 | * Refreshes elasticsearch index. |
||
324 | * |
||
325 | * @param array $params |
||
326 | * |
||
327 | * @return array |
||
328 | */ |
||
329 | public function refresh(array $params = []) |
||
333 | |||
334 | /** |
||
335 | * Adds ids to documents |
||
336 | * |
||
337 | * @param array $bulkQueries |
||
338 | * |
||
339 | * @param array $bulkResponse |
||
340 | */ |
||
341 | public function addIds(array $bulkQueries, $bulkResponse = []) |
||
342 | { |
||
343 | if (empty($bulkResponse)) { |
||
344 | $this->persistedObjects = []; |
||
345 | return; |
||
346 | } |
||
347 | $indexing = []; |
||
348 | foreach ($bulkQueries['body'] as $number => $query) { |
||
349 | if (isset($query['index']) && !isset($query['index']['_id'])) { |
||
350 | $indexing[] = $number / 2; |
||
351 | } |
||
352 | } |
||
353 | if (isset($bulkQueries['body'][0]['index'])) { |
||
354 | if (isset($this->persistedObjects)) { |
||
355 | $i = 0; |
||
356 | foreach ($this->persistedObjects as $document) { |
||
357 | $class = get_class($document); |
||
358 | $mapping = $this->metadataCollector->getMapping($class); |
||
359 | |||
360 | if (isset($mapping['aliases']['_id'])) { |
||
361 | $mapping = $mapping['aliases']['_id']; |
||
362 | $id_property = $mapping['propertyName']; |
||
363 | |||
364 | if ($mapping['propertyType'] == 'public') { |
||
365 | $document->$id_property = $bulkResponse['items'][$indexing[$i]]['create']['_id']; |
||
366 | } elseif (isset($mapping['methods']['setter'])) { |
||
367 | $method = $mapping['methods']['setter']; |
||
368 | $document->$method($bulkResponse['items'][$indexing[$i]]['create']['_id']); |
||
369 | } |
||
370 | } |
||
371 | $i++; |
||
372 | } |
||
373 | } |
||
374 | $this->persistedObjects = []; |
||
375 | } |
||
376 | } |
||
377 | |||
378 | /** |
||
379 | * Inserts the current query container to the index, used for bulk queries execution. |
||
380 | * |
||
381 | * @param array $params Parameters that will be passed to the flush or refresh queries. |
||
382 | * |
||
383 | * @return null|array |
||
384 | */ |
||
385 | public function commit(array $params = []) |
||
410 | |||
411 | /** |
||
412 | * Adds query to bulk queries container. |
||
413 | * |
||
414 | * @param string $operation One of: index, update, delete, create. |
||
415 | * @param string|array $type Elasticsearch type name. |
||
416 | * @param array $query DSL to execute. |
||
417 | * |
||
418 | * @throws \InvalidArgumentException |
||
419 | */ |
||
420 | public function bulk($operation, $type, array $query) |
||
462 | |||
463 | /** |
||
464 | * Optional setter to change bulk query params. |
||
465 | * |
||
466 | * @param array $params Possible keys: |
||
467 | * ['consistency'] = (enum) Explicit write consistency setting for the operation. |
||
468 | * ['refresh'] = (boolean) Refresh the index after performing the operation. |
||
469 | * ['replication'] = (enum) Explicitly set the replication type. |
||
470 | */ |
||
471 | public function setBulkParams(array $params) |
||
475 | |||
476 | /** |
||
477 | * Creates fresh elasticsearch index. |
||
478 | * |
||
479 | * @param bool $noMapping Determines if mapping should be included. |
||
480 | * |
||
481 | * @return array |
||
482 | */ |
||
483 | public function createIndex($noMapping = false) |
||
493 | |||
494 | /** |
||
495 | * Drops elasticsearch index. |
||
496 | */ |
||
497 | public function dropIndex() |
||
503 | |||
504 | /** |
||
505 | * Tries to drop and create fresh elasticsearch index. |
||
506 | * |
||
507 | * @param bool $noMapping Determines if mapping should be included. |
||
508 | * |
||
509 | * @return array |
||
510 | */ |
||
511 | public function dropAndCreateIndex($noMapping = false) |
||
521 | |||
522 | /** |
||
523 | * Checks if connection index is already created. |
||
524 | * |
||
525 | * @return bool |
||
526 | */ |
||
527 | public function indexExists() |
||
531 | |||
532 | /** |
||
533 | * Returns index name this connection is attached to. |
||
534 | * |
||
535 | * @return string |
||
536 | */ |
||
537 | public function getIndexName() |
||
541 | |||
542 | /** |
||
543 | * Sets index name for this connection. |
||
544 | * |
||
545 | * @param string $name |
||
546 | */ |
||
547 | public function setIndexName($name) |
||
551 | |||
552 | /** |
||
553 | * Returns Elasticsearch version number. |
||
554 | * |
||
555 | * @return string |
||
556 | */ |
||
557 | public function getVersionNumber() |
||
561 | |||
562 | /** |
||
563 | * Clears elasticsearch client cache. |
||
564 | */ |
||
565 | public function clearCache() |
||
571 | |||
572 | /** |
||
573 | * Set connection to read only state. |
||
574 | * |
||
575 | * @param bool $readOnly |
||
576 | */ |
||
577 | public function setReadOnly($readOnly) |
||
581 | |||
582 | /** |
||
583 | * Checks if connection is read only. |
||
584 | * |
||
585 | * @param string $message Error message. |
||
586 | * |
||
587 | * @throws Forbidden403Exception |
||
588 | */ |
||
589 | public function isReadOnly($message = '') |
||
595 | |||
596 | /** |
||
597 | * Returns a single document by ID. Returns NULL if document was not found. |
||
598 | * |
||
599 | * @param string $className Document class name or Elasticsearch type name |
||
600 | * @param string $id Document ID to find |
||
601 | * |
||
602 | * @return object |
||
603 | */ |
||
604 | public function find($className, $id) |
||
622 | |||
623 | /** |
||
624 | * Executes given search. |
||
625 | * |
||
626 | * @param array $types |
||
627 | * @param Search $search |
||
628 | * @param string $resultsType |
||
629 | * |
||
630 | * @return DocumentIterator|RawIterator|array |
||
631 | */ |
||
632 | public function execute($types, Search $search, $resultsType = Result::RESULTS_OBJECT) |
||
642 | |||
643 | /** |
||
644 | * Parses raw result. |
||
645 | * |
||
646 | * @param array $raw |
||
647 | * @param string $resultsType |
||
648 | * @param string $scrollDuration |
||
649 | * |
||
650 | * @return DocumentIterator|RawIterator|array |
||
651 | * |
||
652 | * @throws \Exception |
||
653 | */ |
||
654 | private function parseResult($raw, $resultsType, $scrollDuration = null) |
||
675 | |||
676 | /** |
||
677 | * Normalizes response array. |
||
678 | * |
||
679 | * @param array $data |
||
680 | * |
||
681 | * @return array |
||
682 | */ |
||
683 | private function convertToNormalizedArray($data) |
||
703 | |||
704 | /** |
||
705 | * Fetches next set of results. |
||
706 | * |
||
707 | * @param string $scrollId |
||
708 | * @param string $scrollDuration |
||
709 | * @param string $resultsType |
||
710 | * |
||
711 | * @return AbstractResultsIterator |
||
712 | * |
||
713 | * @throws \Exception |
||
714 | */ |
||
715 | public function scroll( |
||
724 | |||
725 | /** |
||
726 | * Clears scroll. |
||
727 | * |
||
728 | * @param string $scrollId |
||
729 | */ |
||
730 | public function clearScroll($scrollId) |
||
734 | |||
735 | /** |
||
736 | * Resolves type name by class name. |
||
737 | * |
||
738 | * @param string $className |
||
739 | * |
||
740 | * @return string |
||
741 | */ |
||
742 | private function resolveTypeName($className) |
||
750 | } |
||
751 |
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: