SuggestionIterator - Code Metrics - Inspection of "Merge branch 'v0.9' into v0.10" - ongr-io/ElasticsearchBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — legacy ( c3f933 )

by Simonas

created 2016-05-26 08:10 UTC

SuggestionIterator A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	129
Duplicated Lines	10.08 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	15
c	1
b	0
f	0
lcom	1
cbo	2
dl	13
loc	129
rs	10

11 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	offsetExists()	0	4	2
A	offsetGet()	13	13	3
A	offsetSet()	0	4	1
A	offsetUnset()	0	4	1
A	current()	0	4	1
A	next()	0	4	1
A	key()	0	4	1
A	valid()	0	4	1
A	rewind()	0	4	1
A	convert()	0	14	2

How to fix Duplicated Code

<?php

/*
 * This file is part of the ONGR package.
 *
 * (c) NFQ Technologies UAB <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ONGR\ElasticsearchBundle\Result\Suggestion;

/**
 * Suggestions results holder.
 */
class SuggestionIterator implements \ArrayAccess, \Iterator
{
    /**
     * @var array
     */
    private $rawData = [];

    /**
     * @var SuggestionEntry[]
     */
    private $convertedData = [];

    /**
     * Constructor.
     *
     * @param array $rawData
     */
    public function __construct($rawData)
    {
        $this->rawData = $rawData;
    }

    /**
     * {@inheritdoc}
     */
    public function offsetExists($offset)
    {
        return isset($this->rawData[$offset]) || isset($this->convertedData[$offset]);
    }

    /**
     * Offset to retrieve.
     *
     * @param string|int $offset
     *
     * @return SuggestionEntry[]|null
     */
    public function offsetGet($offset)

    {
        if (!$this->offsetExists($offset)) {
            return null;
        }

        if (!isset($this->convertedData[$offset])) {
            $this->convertedData[$offset] = $this->convert($this->rawData[$offset]);
            $this->rawData[$offset] = null;
        }

        return $this->convertedData[$offset];
    }

    /**
     * {@inheritdoc}
     */
    public function offsetSet($offset, $value)
    {
        throw new \LogicException('Data of this iterator can not be changed after initialization.');
    }

    /**
     * {@inheritdoc}
     */
    public function offsetUnset($offset)
    {
        throw new \LogicException('Data of this iterator can not be changed after initialization.');
    }

    /**
     * {@inheritdoc}
     */
    public function current()
    {
        return $this->offsetGet($this->key());
    }

    /**
     * {@inheritdoc}
     */
    public function next()
    {
        next($this->rawData);
    }

    /**
     * {@inheritdoc}
     */
    public function key()
    {
        return key($this->rawData);
    }

    /**
     * {@inheritdoc}
     */
    public function valid()
    {
        return $this->key() !== null;
    }

    /**
     * {@inheritdoc}
     */
    public function rewind()
    {
        reset($this->rawData);
    }

    /**
     * Converts array to a array of suggestion objects.
     *
     * @param array $data
     *
     * @return SuggestionEntry[]
     */
    private function convert($data)
    {
        $out = [];
        foreach ($data as $entry) {
            $out[] = new SuggestionEntry(
                $entry['text'],
                $entry['offset'],
                $entry['length'],
                new OptionIterator($entry['options'])
            );
        }

        return $out;
    }
}


1		<?php
2
3		/*
4		* This file is part of the ONGR package.
5		*
6		* (c) NFQ Technologies UAB <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace ONGR\ElasticsearchBundle\Result\Suggestion;
13
14		/**
15		* Suggestions results holder.
16		*/
17		class SuggestionIterator implements \ArrayAccess, \Iterator
18		{
19		/**
20		* @var array
21		*/
22		private $rawData = [];
23
24		/**
25		* @var SuggestionEntry[]
26		*/
27		private $convertedData = [];
28
29		/**
30		* Constructor.
31		*
32		* @param array $rawData
33		*/
34		public function __construct($rawData)
35		{
36		$this->rawData = $rawData;
37		}
38
39		/**
40		* {@inheritdoc}
41		*/
42		public function offsetExists($offset)
43		{
44		return isset($this->rawData[$offset]) \|\| isset($this->convertedData[$offset]);
45		}
46
47		/**
48		* Offset to retrieve.
49		*
50		* @param string\|int $offset
51		*
52		* @return SuggestionEntry[]\|null
53		*/
54	View Code Duplication	public function offsetGet($offset)
		0 ignored issues – show Duplication introduced 2015-12-10 16:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
55		{
56		if (!$this->offsetExists($offset)) {
57		return null;
58		}
59
60		if (!isset($this->convertedData[$offset])) {
61		$this->convertedData[$offset] = $this->convert($this->rawData[$offset]);
62		$this->rawData[$offset] = null;
63		}
64
65		return $this->convertedData[$offset];
66		}
67
68		/**
69		* {@inheritdoc}
70		*/
71		public function offsetSet($offset, $value)
72		{
73		throw new \LogicException('Data of this iterator can not be changed after initialization.');
74		}
75
76		/**
77		* {@inheritdoc}
78		*/
79		public function offsetUnset($offset)
80		{
81		throw new \LogicException('Data of this iterator can not be changed after initialization.');
82		}
83
84		/**
85		* {@inheritdoc}
86		*/
87		public function current()
88		{
89		return $this->offsetGet($this->key());
90		}
91
92		/**
93		* {@inheritdoc}
94		*/
95		public function next()
96		{
97		next($this->rawData);
98		}
99
100		/**
101		* {@inheritdoc}
102		*/
103		public function key()
104		{
105		return key($this->rawData);
106		}
107
108		/**
109		* {@inheritdoc}
110		*/
111		public function valid()
112		{
113		return $this->key() !== null;
114		}
115
116		/**
117		* {@inheritdoc}
118		*/
119		public function rewind()
120		{
121		reset($this->rawData);
122		}
123
124		/**
125		* Converts array to a array of suggestion objects.
126		*
127		* @param array $data
128		*
129		* @return SuggestionEntry[]
130		*/
131		private function convert($data)
132		{
133		$out = [];
134		foreach ($data as $entry) {
135		$out[] = new SuggestionEntry(
136		$entry['text'],
137		$entry['offset'],
138		$entry['length'],
139		new OptionIterator($entry['options'])
140		);
141		}
142
143		return $out;
144		}
145		}
146

ongr-io / ElasticsearchBundle

Push — legacy ( c3f933 )

SuggestionIterator A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

11 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like