ManagerFactory::createManager() - Code Metrics - Inspection of "Changed the default value for ongr cache to %kerne..." - ongr-io/ElasticsearchBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 1.0 (#637)

unknown

created 2016-06-10 10:31 UTC

ManagerFactory::createManager() C

↳ Parent: ManagerFactory

Complexity

Conditions	7
Paths	24

Size

Total Lines	51
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
c	3
b	0
f	1
dl	0
loc	51
rs	6.9743
cc	7
eloc	30
nc	24
nop	4

How to fix Long Method

<?php

/*
 * This file is part of the ONGR package.
 *
 * (c) NFQ Technologies UAB <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ONGR\ElasticsearchBundle\Service;

use Elasticsearch\ClientBuilder;
use ONGR\ElasticsearchBundle\Mapping\MetadataCollector;
use ONGR\ElasticsearchBundle\Result\Converter;
use Psr\Log\LoggerInterface;

/**
 * Elasticsearch Manager factory class.
 */
class ManagerFactory
{
    /**
     * @var MetadataCollector
     */
    private $metadataCollector;

    /**
     * @var Converter
     */
    private $converter;

    /**
     * @var LoggerInterface
     */
    private $logger;

    /**
     * @var LoggerInterface
     */
    private $tracer;

    /**
     * @param MetadataCollector $metadataCollector Metadata collector service.
     * @param Converter         $converter         Converter service to transform arrays to objects and visa versa.
     * @param LoggerInterface   $tracer
     * @param LoggerInterface   $logger
     */
    public function __construct($metadataCollector, $converter, $tracer = null, $logger = null)
    {
        $this->metadataCollector = $metadataCollector;
        $this->converter = $converter;
        $this->tracer = $tracer;
        $this->logger = $logger;
    }

    /**
     * Factory function to create a manager instance.
     *
     * @param string $managerName   Manager name.
     * @param array  $connection    Connection configuration.
     * @param array  $analysis      Analyzers, filters and tokenizers config.
     * @param array  $managerConfig Manager configuration.
     *
     * @return Manager
     */
    public function createManager($managerName, $connection, $analysis, $managerConfig)
    {
        foreach (array_keys($analysis) as $analyzerType) {
            foreach ($connection['analysis'][$analyzerType] as $name) {
                $connection['settings']['analysis'][$analyzerType][$name] = $analysis[$analyzerType][$name];
            }
        }
        unset($connection['analysis']);

        if (!isset($connection['settings']['number_of_replicas'])) {
            $connection['settings']['number_of_replicas'] = 0;
        }

        if (!isset($connection['settings']['number_of_shards'])) {
            $connection['settings']['number_of_shards'] = 1;
        }

        $mappings = $this->metadataCollector->getClientMapping($managerConfig['mappings']);

        $client = ClientBuilder::create();
        $client->setHosts($connection['hosts']);
        $client->setTracer($this->tracer);

        if ($this->logger && $managerConfig['logger']['enabled']) {
            $client->setLogger($this->logger);
        }

        $indexSettings = [
            'index' => $connection['index_name'],
            'body' => array_filter(
                [
                    'settings' => $connection['settings'],
                    'mappings' => $mappings,
                ]
            ),
        ];

        $manager = new Manager(
            $managerName,
            $managerConfig,
            $client->build(),
            $indexSettings,
            $this->metadataCollector,
            $this->converter
        );

        $manager->setCommitMode($managerConfig['commit_mode']);
        $manager->setBulkCommitSize($managerConfig['bulk_size']);

        return $manager;
    }
}


1			<?php
2
3			/*
4			* This file is part of the ONGR package.
5			*
6			* (c) NFQ Technologies UAB <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace ONGR\ElasticsearchBundle\Service;
13
14			use Elasticsearch\ClientBuilder;
15			use ONGR\ElasticsearchBundle\Mapping\MetadataCollector;
16			use ONGR\ElasticsearchBundle\Result\Converter;
17			use Psr\Log\LoggerInterface;
18
19			/**
20			* Elasticsearch Manager factory class.
21			*/
22			class ManagerFactory
23			{
24			/**
25			* @var MetadataCollector
26			*/
27			private $metadataCollector;
28
29			/**
30			* @var Converter
31			*/
32			private $converter;
33
34			/**
35			* @var LoggerInterface
36			*/
37			private $logger;
38
39			/**
40			* @var LoggerInterface
41			*/
42			private $tracer;
43
44			/**
45			* @param MetadataCollector $metadataCollector Metadata collector service.
46			* @param Converter $converter Converter service to transform arrays to objects and visa versa.
47			* @param LoggerInterface $tracer
48			* @param LoggerInterface $logger
49			*/
50			public function __construct($metadataCollector, $converter, $tracer = null, $logger = null)
51			{
52			$this->metadataCollector = $metadataCollector;
53			$this->converter = $converter;
54			$this->tracer = $tracer;
55			$this->logger = $logger;
56			}
57
58			/**
59			* Factory function to create a manager instance.
60			*
61			* @param string $managerName Manager name.
62			* @param array $connection Connection configuration.
63			* @param array $analysis Analyzers, filters and tokenizers config.
64			* @param array $managerConfig Manager configuration.
65			*
66			* @return Manager
67			*/
68			public function createManager($managerName, $connection, $analysis, $managerConfig)
69			{
70			foreach (array_keys($analysis) as $analyzerType) {
71			foreach ($connection['analysis'][$analyzerType] as $name) {
72			$connection['settings']['analysis'][$analyzerType][$name] = $analysis[$analyzerType][$name];
73			}
74			}
75			unset($connection['analysis']);
76
77			if (!isset($connection['settings']['number_of_replicas'])) {
78			$connection['settings']['number_of_replicas'] = 0;
79			}
80
81			if (!isset($connection['settings']['number_of_shards'])) {
82			$connection['settings']['number_of_shards'] = 1;
83			}
84
85			$mappings = $this->metadataCollector->getClientMapping($managerConfig['mappings']);
86
87			$client = ClientBuilder::create();
88			$client->setHosts($connection['hosts']);
89			$client->setTracer($this->tracer);
90
91			if ($this->logger && $managerConfig['logger']['enabled']) {
92			$client->setLogger($this->logger);
93			}
94
95			$indexSettings = [
96			'index' => $connection['index_name'],
97			'body' => array_filter(
98			[
99			'settings' => $connection['settings'],
100			'mappings' => $mappings,
101			]
102			),
103			];
104
105			$manager = new Manager(
106			$managerName,
107			$managerConfig,
108			$client->build(),
109			$indexSettings,
110			$this->metadataCollector,
111			$this->converter
112			);
113
114			$manager->setCommitMode($managerConfig['commit_mode']);
115			$manager->setBulkCommitSize($managerConfig['bulk_size']);
116
117			return $manager;
118			}
119			}
120

ongr-io / ElasticsearchBundle

Pull Request — 1.0 (#637)

ManagerFactory::createManager() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like