ONGR\ElasticsearchBundle\Service\ImportService

Complexity

Total Complexity

8

Size/Duplication

Total Lines	76
Duplicated Lines	10.53 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes	3
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getReader()	0	4	1
B	importIndex()	0	35	4
A	getFilePath()	8	8	3

<?php

/*
 * This file is part of the ONGR package.
 *
 * (c) NFQ Technologies UAB <info@nfq.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ONGR\ElasticsearchBundle\Service;

use ONGR\ElasticsearchBundle\Service\Json\JsonReader;
use Symfony\Component\Console\Helper\ProgressBar;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * ImportService class.
 */
class ImportService
{
    /**
     * Imports Elasticsearch index data.
     *
     * @param Manager         $manager
     * @param string          $filename
     * @param OutputInterface $output
     * @param array           $options
     */
    public function importIndex(
        Manager $manager,
        $filename,
        OutputInterface $output,
        $options
    ) {
        $reader = $this->getReader($manager, $this->getFilePath($filename), $options);

        $progress = new ProgressBar($output, $reader->count());
        $progress->setRedrawFrequency(100);
        $progress->start();

        $bulkSize = $options['bulk-size'];
        foreach ($reader as $key => $document) {
            $data = $document['_source'];
            $data['_id'] = $document['_id'];

            if (array_key_exists('fields', $document)) {
                $data = array_merge($document['fields'], $data);
            }

            $manager->bulk('index', $document['_type'], $data);

It seems like $data defined by $document['_source'] on line 45 can also be of type string; however, ONGR\ElasticsearchBundle\Service\Manager::bulk() does only seem to accept array, maybe add an additional type check?

            if (($key + 1) % $bulkSize == 0) {
                $manager->commit();
            }

            $progress->advance();
        }

        $manager->commit();

        $progress->finish();
        $output->writeln('');
    }

    /**
     * Returns a real file path.
     *
     * @param string $filename
     *
     * @return string
     */
    protected function getFilePath($filename)

This method seems to be duplicated in your project.

    {
        if ($filename{0} == '/' || strstr($filename, ':') !== false) {
            return $filename;
        }

        return realpath(getcwd() . '/' . $filename);
    }

    /**
     * Prepares JSON reader.
     *
     * @param Manager $manager
     * @param string  $filename
     * @param array   $options
     *
     * @return JsonReader
     */
    protected function getReader($manager, $filename, $options)
    {
        return new JsonReader($manager, $filename, $options);
    }
}