DocumentGenerateCommand - Code Metrics - Inspection of "[WIP] 6.0 major version release candidate" - ongr-io/ElasticsearchBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#869)

unknown

created 2019-09-27 06:41 UTC

DocumentGenerateCommand C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	696
Duplicated Lines	10.06 %

Coupling/Cohesion

Components	1
Dependencies	10

Importance

Changes

Metric	Value
wmc	56
lcom	1
cbo	10
dl	70
loc	696
c	0
b	0
f	0
rs	5.424

22 Methods

Rating	Name	Duplication	Size	Complexity
A	configure()	0	8	1
A	execute()	0	6	2
F	interact()	26	213	19
A	isUniqueAnnotation()	0	10	3
A	askForPropertyName()	0	8	1
A	askForPropertyOptions()	0	19	1
A	askForPropertyClass()	0	13	1
A	getDocumentClasses()	0	15	1
A	parseShortcutNotation()	0	13	2
A	validatePropertyClass()	0	16	3
A	validateDocumentName()	0	11	2
A	validateFieldName()	0	15	4
A	validatePropertyType()	11	11	2
A	validateDocumentAnnotation()	11	11	2
A	validatePropertyAnnotation()	11	11	2
A	validatePropertyVisibility()	11	11	2
A	getQuestion()	0	13	2
A	getOptionsLabel()	0	10	2
A	getException()	0	6	1
A	getPropertyTypes()	0	10	1
A	getDocumentAnnotations()	0	4	1
B	getReservedKeywords()	0	71	1

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like DocumentGenerateCommand often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use DocumentGenerateCommand, and based on these observations, apply Extract Interface, too.

<?php

/*
 * This file is part of the ONGR package.
 *
 * (c) NFQ Technologies UAB <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ONGR\ElasticsearchBundle\Command;

use Symfony\Component\Console\Helper\FormatterHelper;
use Symfony\Component\Console\Helper\QuestionHelper;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\ConfirmationQuestion;
use Symfony\Component\Console\Question\Question;
use Symfony\Component\HttpKernel\Kernel;

class DocumentGenerateCommand extends AbstractIndexServiceAwareCommand
{
    const NAME = 'ongr:es:document:generate';

    /**
     * @var QuestionHelper
     */
    private $questionHelper;

    /**
     * @var string[]
     */
    private $propertyAnnotations;

    /**
     * @var string[]
     */
    private $propertyVisibilities;

    /**
     * {@inheritdoc}
     */
    protected function configure()
    {
        parent::configure();

        $this
            ->setName(self::NAME)
            ->setDescription('Generates a new Elasticsearch document inside a bundle');
    }

    /**
     * {@inheritdoc}
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        if ($input->hasParameterOption(['--no-interaction', '-n'])) {
            throw $this->getException('No interaction mode is not allowed!');
        }
    }

    /**
     * {@inheritdoc}
     */
    protected function interact(InputInterface $input, OutputInterface $output)
    {
        /** @var FormatterHelper $formatter */
        $formatter = $this->getHelperSet()->get('formatter');
        $this->questionHelper = new QuestionHelper();

        $output->writeln(
            [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                '',
                $formatter->formatBlock('Welcome to the Elasticsearch Bundle document generator', 'bg=blue', true),
                '',
                'This command helps you generate Elasticsearch documents.',
                '',
                'First, you need to give the document class namespace you want to generate.',
                'You must use the shortcut notation like <comment>App\YourProjectPath\PostDocument</comment>.',
                '',
            ]
        );

        /** @var Kernel $kernel */
        $kernel = $this->getContainer()->get('kernel');
        $bundleNames = array_keys($kernel->getBundles());

        while (true) {
            $document = $this->questionHelper->ask(
                $input,
                $output,
                $this->getQuestion('The Document shortcut name', null, [$this, 'validateDocumentName'], $bundleNames)
            );

            list($bundle, $document) = $this->parseShortcutNotation($document);

            if (in_array(strtolower($document), $this->getReservedKeywords())) {
                $output->writeln($this->getException('"%s" is a reserved word.', [$document])->getMessage());
                continue;
            }

            try {
                if (!file_exists(
                    $kernel->getBundle($bundle)->getPath() . '/Document/' . str_replace('\\', '/', $document) . '.php'
                )) {
                    break;
                }

                $output->writeln(
                    $this->getException('Document "%s:%s" already exists.', [$bundle, $document])->getMessage()
                );
            } catch (\Exception $e) {
                $output->writeln($this->getException('Bundle "%s" does not exist.', [$bundle])->getMessage());
            }
        }

        $output->writeln($this->getOptionsLabel($this->getDocumentAnnotations(), 'Available types'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $annotation = $this->questionHelper->ask(
            $input,
            $output,
            $this->getQuestion(
                'Document type',
                'document',
                [$this, 'validateDocumentAnnotation'],
                $this->getDocumentAnnotations()
            )
        );

        $this->propertyAnnotations = ['embedded', 'property'];
        $documentType = lcfirst($document);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

        if ($annotation == 'document') {
            $this->propertyAnnotations = ['embedded', 'id', 'parentDocument', 'property', 'ttl'];
            $documentType = $this->questionHelper->ask(
                $input,
                $output,
                $this->getQuestion(
                    "\n" . 'Elasticsearch Document name',
                    lcfirst($document),
                    [$this, 'validateFieldName']
                )
            );
        }

        $properties = [];
        $output->writeln(['', $formatter->formatBlock('New Document Property?', 'bg=blue;fg=white', true)]);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        while (true) {
            $property = [];
            $question = $this->getQuestion(
                'Property name [<comment>press <info><return></info> to stop</comment>]',
                false
            );

            if (!$field = $this->questionHelper->ask($input, $output, $question)) {
                break;
            }

            foreach ($properties as $previousProperty) {
                if ($previousProperty['field_name'] == $field) {
                    $output->writeln($this->getException('Duplicate field name "%s"', [$field])->getMessage());
                    continue(2);
                }
            }

            try {
                $this->validateFieldName($field);
            } catch (\InvalidArgumentException $e) {
                $output->writeln($e->getMessage());
                continue;
            }

            $this->propertyVisibilities  = ['private', 'protected', 'public'];
            $output->writeln($this->getOptionsLabel($this->propertyVisibilities, 'Available visibilities'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $property['visibility'] = $this->questionHelper->ask(
                $input,
                $output,
                $this->getQuestion(
                    'Property visibility',
                    'private',
                    [$this, 'validatePropertyVisibility'],
                    $this->propertyVisibilities
                )
            );

            $output->writeln($this->getOptionsLabel($this->propertyAnnotations, 'Available annotations'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $property['annotation'] = $this->questionHelper->ask(
                $input,
                $output,
                $this->getQuestion(
                    'Property meta field',
                    'property',
                    [$this, 'validatePropertyAnnotation'],
                    $this->propertyAnnotations
                )
            );

            $property['field_name'] = $property['property_name'] = $field;

            switch ($property['annotation']) {
                case 'embedded':
                    $property['property_name'] = $this->askForPropertyName($input, $output, $property['field_name']);
                    $property['property_class'] = $this->askForPropertyClass($input, $output);

                    $question = new ConfirmationQuestion("\n<info>Multiple</info> [<comment>no</comment>]: ", false);
                    $question->setAutocompleterValues(['yes', 'no']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    $property['property_multiple'] = $this->questionHelper->ask($input, $output, $question);

                    $property['property_options'] = $this->askForPropertyOptions($input, $output);
                    break;
                case 'parentDocument':

                    if (!$this->isUniqueAnnotation($properties, $property['annotation'])) {
                        $output->writeln(
                            $this
                                ->getException('Only one "%s" field can be added', [$property['annotation']])
                                ->getMessage()
                        );
                        continue(2);
                    }
                    $property['property_class'] = $this->askForPropertyClass($input, $output);
                    break;
                case 'property':
                    $property['property_name'] = $this->askForPropertyName($input, $output, $property['field_name']);

                    $output->writeln($this->getOptionsLabel($this->getPropertyTypes(), 'Available types'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    $property['property_type'] = $this->questionHelper->ask(
                        $input,
                        $output,
                        $this->getQuestion(
                            'Property type',
                            'text',
                            [$this, 'validatePropertyType'],
                            $this->getPropertyTypes()
                        )
                    );

                    $property['property_options'] = $this->askForPropertyOptions($input, $output);
                    break;
                case 'ttl':

                    if (!$this->isUniqueAnnotation($properties, $property['annotation'])) {
                        $output->writeln(
                            $this
                                ->getException('Only one "%s" field can be added', [$property['annotation']])
                                ->getMessage()
                        );
                        continue(2);
                    }
                    $property['property_default'] = $this->questionHelper->ask(
                        $input,
                        $output,
                        $this->getQuestion("\n" . 'Default time to live')
                    );
                    break;
                case 'id':
                    if (!$this->isUniqueAnnotation($properties, $property['annotation'])) {
                        $output->writeln(
                            $this
                                ->getException('Only one "%s" field can be added', [$property['annotation']])
                                ->getMessage()
                        );
                        continue(2);
                    }
                    break;
            }

            $properties[] = $property;
            $output->writeln(['', $formatter->formatBlock('New Document Property', 'bg=blue;fg=white', true)]);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        $this->getContainer()->get('es.generate')->generate(
            $this->getContainer()->get('kernel')->getBundle($bundle),
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            $document,
            $annotation,
            $documentType,
            $properties
        );
    }

    /**
     * @param array  $properties
     * @param string $annotation
     *
     * @return string
     */
    private function isUniqueAnnotation($properties, $annotation)
    {
        foreach ($properties as $property) {
            if ($property['annotation'] == $annotation) {
                return false;
            }
        }

        return true;
    }

    /**
     * Asks for property name
     *
     * @param InputInterface  $input
     * @param OutputInterface $output
     * @param string          $default
     *
     * @return string
     */
    private function askForPropertyName(InputInterface $input, OutputInterface $output, $default = null)
    {
        return $this->questionHelper->ask(
            $input,
            $output,
            $this->getQuestion("\n" . 'Property name in Elasticsearch', $default, [$this, 'validateFieldName'])
        );
    }

    /**
     * Asks for property options
     *
     * @param InputInterface  $input
     * @param OutputInterface $output
     *
     * @return string
     */
    private function askForPropertyOptions(InputInterface $input, OutputInterface $output)
    {
        $output->writeln(
            "\n"
                . '<info>Enter property options, for example <comment>"index"="not_analyzed"</comment>'
                . ' allows mapper to index this field, so it is searchable, but value will be not analyzed.</info>'
        );

        return $this->questionHelper->ask(
            $input,
            $output,
            $this->getQuestion(
                'Property options [<comment>press <info><return></info> to stop</comment>]',
                false,
                null,
                ['"index"="not_analyzed"', '"analyzer"="standard"']
            )
        );
    }

    /**
     * Asks for property class
     *
     * @param InputInterface  $input
     * @param OutputInterface $output
     *
     * @return string
     */
    private function askForPropertyClass(InputInterface $input, OutputInterface $output)
    {
        return $this->questionHelper->ask(
            $input,
            $output,
            $this->getQuestion(
                "\n" . 'Property class',
                null,
                [$this, 'validatePropertyClass'],
                array_merge($this->getDocumentClasses(), array_keys($this->getContainer()->get('kernel')->getBundles()))
            )
        );
    }

    /**
     * Returns available document classes
     *
     * @return array
     */
    private function getDocumentClasses()
    {
//        /** @var MetadataCollector $metadataCollector */
//        $metadataCollector = $this->getContainer()->get('es.metadata_collector');
//        $classes = [];
//
//        foreach ($this->getContainer()->getParameter('es.managers') as $manager) {
//            $documents = $metadataCollector->getMappings($manager['mappings']);
//            foreach ($documents as $document) {
//                $classes[] = sprintf('%s:%s', $document['bundle'], $document['class']);
//            }
//        }
//        return $classes;
        return [];
    }

    /**
     * Parses shortcut notation
     *
     * @param string $shortcut
     *
     * @return string[]
     * @throws \InvalidArgumentException
     */
    private function parseShortcutNotation($shortcut)
    {
        $shortcut = str_replace('/', '\\', $shortcut);

        if (false === $pos = strpos($shortcut, ':')) {
            throw $this->getException(
                'The document name isn\'t valid ("%s" given, expecting something like AcmeBundle:Post)',
                [$shortcut]
            );
        }

        return [substr($shortcut, 0, $pos), substr($shortcut, $pos + 1)];
    }

    /**
     * Validates property class
     *
     * @param string $input
     *
     * @return string
     * @throws \InvalidArgumentException
     */
    public function validatePropertyClass($input)
    {
        list($bundle, $document) = $this->parseShortcutNotation($input);

        try {
            $bundlePath = $this->getContainer()->get('kernel')->getBundle($bundle)->getPath();
        } catch (\Exception $e) {
            throw $this->getException('Bundle "%s" does not exist.', [$bundle]);
        }

        if (!file_exists($bundlePath . '/Document/' . str_replace('\\', '/', $document) . '.php')) {
            throw $this->getException('Document "%s:%s" does not exist.', [$bundle, $document]);
        }

        return $input;
    }

    /**
     * Performs basic checks in document name
     *
     * @param string $document
     *
     * @return string
     * @throws \InvalidArgumentException
     */
    public function validateDocumentName($document)
    {
        if (!preg_match('{^[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*:[a-zA-Z0-9_\x7f-\xff\\\/]+$}', $document)) {
            throw $this->getException(
                'The document name isn\'t valid ("%s" given, expecting something like AcmeBundle:Post)',
                [$document]
            );
        }

        return $document;
    }

    /**
     * Validates field name
     *
     * @param string $field
     *
     * @return string
     * @throws \InvalidArgumentException
     */
    public function validateFieldName($field)
    {
        if (!$field || $field != lcfirst(preg_replace('/[^a-zA-Z]+/', '', $field))) {
            throw $this->getException(
                'The parameter isn\'t valid ("%s" given, expecting camelcase separated words)',
                [$field]
            );
        }

        if (in_array(strtolower($field), $this->getReservedKeywords())) {
            throw $this->getException('"%s" is a reserved word.', [$field]);
        }

        return $field;
    }

    /**
     * Validates property type
     *
     * @param string $type
     *
     * @return string
     * @throws \InvalidArgumentException
     */
    public function validatePropertyType($type)

    {
        if (!in_array($type, $this->getPropertyTypes())) {
            throw $this->getException(
                'The property type isn\'t valid ("%s" given, expecting one of following: %s)',
                [$type, implode(', ', $this->getPropertyTypes())]
            );
        }

        return $type;
    }

    /**
     * Validates document annotation
     *
     * @param string $annotation
     *
     * @return string
     * @throws \InvalidArgumentException
     */
    public function validateDocumentAnnotation($annotation)

    {
        if (!in_array($annotation, $this->getDocumentAnnotations())) {
            throw $this->getException(
                'The document annotation isn\'t valid ("%s" given, expecting one of following: %s)',
                [$annotation, implode(', ', $this->getDocumentAnnotations())]
            );
        }

        return $annotation;
    }

    /**
     * Validates property annotation
     *
     * @param string $annotation
     *
     * @return string
     * @throws \InvalidArgumentException
     */
    public function validatePropertyAnnotation($annotation)

    {
        if (!in_array($annotation, $this->propertyAnnotations)) {
            throw $this->getException(
                'The property annotation isn\'t valid ("%s" given, expecting one of following: %s)',
                [$annotation, implode(', ', $this->propertyAnnotations)]
            );
        }

        return $annotation;
    }

    /**
     * Validates property visibility
     *
     * @param string $visibility
     *
     * @return string
     * @throws \InvalidArgumentException When the visibility is not found in the list of allowed ones.
     */
    public function validatePropertyVisibility($visibility)

    {
        if (!in_array($visibility, $this->propertyVisibilities)) {
            throw $this->getException(
                'The property visibility isn\'t valid ("%s" given, expecting one of following: %s)',
                [$visibility, implode(', ', $this->propertyVisibilities)]
            );
        }

        return $visibility;
    }

    /**
     * Returns formatted question
     *
     * @param string        $question
     * @param mixed         $default
     * @param callable|null $validator
     * @param array|null    $values
     *
     * @return Question
     */
    private function getQuestion($question, $default = null, callable $validator = null, array $values = null)
    {
        $question = new Question(
            sprintf('<info>%s</info>%s: ', $question, $default ? sprintf(' [<comment>%s</comment>]', $default) : ''),
            $default
        );

        $question
            ->setValidator($validator)
            ->setAutocompleterValues($values);


        return $question;
    }

    /**
     * Returns options label
     *
     * @param array  $options
     * @param string $suffix
     *
     * @return string[]
     */
    private function getOptionsLabel(array $options, $suffix)
    {
        $label = sprintf('<info>%s:</info> ', $suffix);

        foreach ($options as &$option) {
            $option = sprintf('<comment>%s</comment>', $option);
        }

        return ['', $label . implode(', ', $options) . '.'];
    }

    /**
     * Returns formatted exception
     *
     * @param string $format
     * @param array  $args
     *
     * @return \InvalidArgumentException
     */
    private function getException($format, $args = [])
    {
        /** @var FormatterHelper $formatter */
        $formatter = $this->getHelperSet()->get('formatter');
        return new \InvalidArgumentException($formatter->formatBlock(vsprintf($format, $args), 'bg=red', true));
    }

    /**
     * Returns available property types
     *
     * @return array
     */
    private function getPropertyTypes()
    {
        $reflection = new \ReflectionClass('ONGR\ElasticsearchBundle\Annotation\Property');

        return $this
            ->getContainer()
            ->get('es.annotations.cached_reader')
            ->getPropertyAnnotation($reflection->getProperty('type'), 'Doctrine\Common\Annotations\Annotation\Enum')
            ->value;
    }

    /**
     * Returns document annotations
     *
     * @return string[]
     */
    private function getDocumentAnnotations()
    {
        return ['document', 'nested', 'object'];
    }

    /**
     * Returns reserved keywords
     *
     * @return string[]
     */
    private function getReservedKeywords()
    {
        return [
            'abstract',
            'and',
            'array',
            'as',
            'break',
            'callable',
            'case',
            'catch',
            'class',
            'clone',
            'const',
            'continue',
            'declare',
            'default',
            'do',
            'else',
            'elseif',
            'enddeclare',
            'endfor',
            'endforeach',
            'endif',
            'endswitch',
            'endwhile',
            'extends',
            'final',
            'finally',
            'for',
            'foreach',
            'function',
            'global',
            'goto',
            'if',
            'implements',
            'interface',
            'instanceof',
            'insteadof',
            'namespace',
            'new',
            'or',
            'private',
            'protected',
            'public',
            'static',
            'switch',
            'throw',
            'trait',
            'try',
            'use',
            'var',
            'while',
            'xor',
            'yield',
            'die',
            'echo',
            'empty',
            'exit',
            'eval',
            'include',
            'include_once',
            'isset',
            'list',
            'require',
            'require_once',
            'return',
            'print',
            'unset',
        ];
    }
}


Pull Request — master (#869)

DocumentGenerateCommand C

Complexity

Size/Duplication

Coupling/Cohesion

Importance

22 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

ongr-io / ElasticsearchBundle

Pull Request — master (#869)

DocumentGenerateCommand C

Complexity

Size/Duplication

Coupling/Cohesion

Importance

22 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like