ONGR\ElasticsearchBundle\Result\DocumentIterator

Complexity

Total Complexity

5

Size/Duplication

Total Lines	47
Duplicated Lines	23.4 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	5
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	2
A	getAggregation()	11	11	2
A	convertDocument()	0	4	1

<?php

/*
 * This file is part of the ONGR package.
 *
 * (c) NFQ Technologies UAB <info@nfq.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ONGR\ElasticsearchBundle\Result;

use ONGR\ElasticsearchBundle\Result\Aggregation\ValueAggregation;
use ONGR\ElasticsearchBundle\Service\Manager;
use ONGR\ElasticsearchDSL\Aggregation\AbstractAggregation;

/**
 * Class DocumentIterator.
 */
class DocumentIterator extends AbstractResultsIterator
{
    /**
     * @var array
     */
    private $aggregations;

Consider using a different property name as you override a private property of the parent class.

    /**
     * {@inheritdoc}
     */
    public function __construct(array $rawData, Manager $manager, array $scroll = [])
    {
        if (isset($rawData['aggregations'])) {
            $this->aggregations = $rawData['aggregations'];
            unset($rawData['aggregations']);
        }

        parent::__construct($rawData, $manager, $scroll);
    }

    /**
     * Get a specific aggregation by name. It fetches from the top level only.
     *
     * @param string $name
     *
     * @return ValueAggregation|null
     */
    public function getAggregation($name)

This method seems to be duplicated in your project.

    {
        // TODO: remove this *** after DSL update
        $name = AbstractAggregation::PREFIX . $name;

        if (!isset($this->aggregations[$name])) {
            return null;
        }

        return new ValueAggregation($this->aggregations[$name]);
    }

    /**
     * {@inheritdoc}
     */
    protected function convertDocument(array $document)
    {
        return $this->getConverter()->convertToDocument($document, $this->getManager());
    }
}