ImportService - Code Metrics - Inspection of "Removing --raw flag from import command as only ra..." - ongr-io/ElasticsearchBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#503)

by Mantas

created 2015-12-21 14:55 UTC

ImportService A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	71
Duplicated Lines	11.27 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes	4
Bugs	0	Features	1

Metric	Value
wmc	8
lcom	0
cbo	4
dl	8
loc	71
rs	10
c	4
b	0
f	1

3 Methods

Rating	Name	Duplication	Size	Complexity
B	importIndex()	0	30	4
A	getFilePath()	8	8	3
A	getReader()	0	4	1

How to fix Duplicated Code

<?php

/*
 * This file is part of the ONGR package.
 *
 * (c) NFQ Technologies UAB <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ONGR\ElasticsearchBundle\Service;

use ONGR\ElasticsearchBundle\Service\Json\JsonReader;
use Symfony\Component\Console\Helper\ProgressBar;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * ImportService class.
 */
class ImportService
{
    /**
     * Imports Elasticsearch index data.
     *
     * @param Manager         $manager
     * @param string          $filename
     * @param OutputInterface $output
     * @param int             $bulkSize
     */
    public function importIndex(Manager $manager, $filename, OutputInterface $output, $bulkSize)
    {
        $reader = $this->getReader($manager, $this->getFilePath($filename), false);

        $progress = new ProgressBar($output, $reader->count());
        $progress->setRedrawFrequency(100);
        $progress->start();

        foreach ($reader as $key => $document) {
            $data = $document['_source'];
            $data['_id'] = $document['_id'];

            if (array_key_exists('fields', $document)) {
                $data = array_merge($document['fields'], $data);
            }

            $manager->bulk('index', $document['_type'], $data);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

            if (($key + 1) % $bulkSize == 0) {
                $manager->commit();
            }

            $progress->advance();
        }

        $manager->commit();

        $progress->finish();
        $output->writeln('');
    }

    /**
     * Returns a real file path.
     *
     * @param string $filename
     *
     * @return string
     */
    protected function getFilePath($filename)

    {
        if ($filename{0} == '/' || strstr($filename, ':') !== false) {
            return $filename;
        }

        return realpath(getcwd() . '/' . $filename);
    }

    /**
     * Prepares JSON reader.
     *
     * @param Manager $manager
     * @param string  $filename
     * @param bool    $convertDocuments
     *
     * @return JsonReader
     */
    protected function getReader($manager, $filename, $convertDocuments)
    {
        return new JsonReader($manager, $filename, $convertDocuments);
    }
}


1		<?php
2
3		/*
4		* This file is part of the ONGR package.
5		*
6		* (c) NFQ Technologies UAB <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace ONGR\ElasticsearchBundle\Service;
13
14		use ONGR\ElasticsearchBundle\Service\Json\JsonReader;
15		use Symfony\Component\Console\Helper\ProgressBar;
16		use Symfony\Component\Console\Output\OutputInterface;
17
18		/**
19		* ImportService class.
20		*/
21		class ImportService
22		{
23		/**
24		* Imports Elasticsearch index data.
25		*
26		* @param Manager $manager
27		* @param string $filename
28		* @param OutputInterface $output
29		* @param int $bulkSize
30		*/
31		public function importIndex(Manager $manager, $filename, OutputInterface $output, $bulkSize)
32		{
33		$reader = $this->getReader($manager, $this->getFilePath($filename), false);
34
35		$progress = new ProgressBar($output, $reader->count());
36		$progress->setRedrawFrequency(100);
37		$progress->start();
38
39		foreach ($reader as $key => $document) {
40		$data = $document['_source'];
41		$data['_id'] = $document['_id'];
42
43		if (array_key_exists('fields', $document)) {
44		$data = array_merge($document['fields'], $data);
45		}
46
47		$manager->bulk('index', $document['_type'], $data);
		0 ignored issues – show Bug introduced 2015-12-21 15:00 UTC by Report Bug Copy Issue Report It seems like `$data` defined by `$document['_source']` on line `40` can also be of type `string`; however, `ONGR\ElasticsearchBundle\Service\Manager::bulk()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
48
49		if (($key + 1) % $bulkSize == 0) {
50		$manager->commit();
51		}
52
53		$progress->advance();
54		}
55
56		$manager->commit();
57
58		$progress->finish();
59		$output->writeln('');
60		}
61
62		/**
63		* Returns a real file path.
64		*
65		* @param string $filename
66		*
67		* @return string
68		*/
69	View Code Duplication	protected function getFilePath($filename)
		0 ignored issues – show Duplication introduced 2015-11-23 09:47 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
70		{
71		if ($filename{0} == '/' \|\| strstr($filename, ':') !== false) {
72		return $filename;
73		}
74
75		return realpath(getcwd() . '/' . $filename);
76		}
77
78		/**
79		* Prepares JSON reader.
80		*
81		* @param Manager $manager
82		* @param string $filename
83		* @param bool $convertDocuments
84		*
85		* @return JsonReader
86		*/
87		protected function getReader($manager, $filename, $convertDocuments)
88		{
89		return new JsonReader($manager, $filename, $convertDocuments);
90		}
91		}
92

ongr-io / ElasticsearchBundle

Pull Request — master (#503)

ImportService A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like