Complex classes like Manager often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Manager, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
28 | class Manager |
||
29 | { |
||
30 | /** |
||
31 | * @var string Manager name |
||
32 | */ |
||
33 | private $name; |
||
34 | |||
35 | /** |
||
36 | * @var array Manager configuration |
||
37 | */ |
||
38 | private $config = []; |
||
39 | |||
40 | /** |
||
41 | * @var Client |
||
42 | */ |
||
43 | private $client; |
||
44 | |||
45 | /** |
||
46 | * @var Converter |
||
47 | */ |
||
48 | private $converter; |
||
49 | |||
50 | /** |
||
51 | * @var array Container for bulk queries |
||
52 | */ |
||
53 | private $bulkQueries = []; |
||
54 | |||
55 | /** |
||
56 | * @var array Holder for consistency, refresh and replication parameters |
||
57 | */ |
||
58 | private $bulkParams = []; |
||
59 | |||
60 | /** |
||
61 | * @var array |
||
62 | */ |
||
63 | private $indexSettings; |
||
64 | |||
65 | /** |
||
66 | * @var MetadataCollector |
||
67 | */ |
||
68 | private $metadataCollector; |
||
69 | |||
70 | /** |
||
71 | * After commit to make data available the refresh or flush operation is needed |
||
72 | * so one of those methods has to be defined, the default is refresh. |
||
73 | * |
||
74 | * @var string |
||
75 | */ |
||
76 | private $commitMode = 'refresh'; |
||
77 | |||
78 | /** |
||
79 | * The size that defines after how much document inserts call commit function. |
||
80 | * |
||
81 | * @var int |
||
82 | */ |
||
83 | private $bulkCommitSize = 100; |
||
84 | |||
85 | /** |
||
86 | * Container to count how many documents was passed to the bulk query. |
||
87 | * |
||
88 | * @var int |
||
89 | */ |
||
90 | private $bulkCount = 0; |
||
91 | |||
92 | /** |
||
93 | * @var Repository[] Repository local cache |
||
94 | */ |
||
95 | private $repositories; |
||
96 | |||
97 | /** |
||
98 | * @var EventDispatcherInterface |
||
99 | */ |
||
100 | private $eventDispatcher; |
||
101 | |||
102 | /** |
||
103 | * @var Stopwatch |
||
104 | */ |
||
105 | private $stopwatch; |
||
106 | |||
107 | /** |
||
108 | * @param string $name Manager name |
||
109 | * @param array $config Manager configuration |
||
110 | * @param Client $client |
||
111 | * @param array $indexSettings |
||
112 | * @param MetadataCollector $metadataCollector |
||
113 | * @param Converter $converter |
||
114 | */ |
||
115 | public function __construct( |
||
130 | |||
131 | /** |
||
132 | * Returns Elasticsearch connection. |
||
133 | * |
||
134 | * @return Client |
||
135 | */ |
||
136 | public function getClient() |
||
140 | |||
141 | /** |
||
142 | * @return string |
||
143 | */ |
||
144 | public function getName() |
||
148 | |||
149 | /** |
||
150 | * @return array |
||
151 | */ |
||
152 | public function getConfig() |
||
156 | |||
157 | /** |
||
158 | * @param EventDispatcherInterface $eventDispatcher |
||
159 | */ |
||
160 | public function setEventDispatcher(EventDispatcherInterface $eventDispatcher) |
||
164 | |||
165 | /** |
||
166 | * @param Stopwatch $stopwatch |
||
167 | */ |
||
168 | public function setStopwatch(Stopwatch $stopwatch) |
||
172 | |||
173 | /** |
||
174 | * Returns repository by document class. |
||
175 | * |
||
176 | * @param string $className FQCN or string in Bundle:Document format |
||
177 | * |
||
178 | * @return Repository |
||
179 | */ |
||
180 | public function getRepository($className) |
||
207 | |||
208 | /** |
||
209 | * @return MetadataCollector |
||
210 | */ |
||
211 | public function getMetadataCollector() |
||
215 | |||
216 | /** |
||
217 | * @return Converter |
||
218 | */ |
||
219 | public function getConverter() |
||
223 | |||
224 | /** |
||
225 | * @return string |
||
226 | */ |
||
227 | public function getCommitMode() |
||
231 | |||
232 | /** |
||
233 | * @param string $commitMode |
||
234 | */ |
||
235 | public function setCommitMode($commitMode) |
||
243 | |||
244 | /** |
||
245 | * @return int |
||
246 | */ |
||
247 | public function getBulkCommitSize() |
||
251 | |||
252 | /** |
||
253 | * @param int $bulkCommitSize |
||
254 | */ |
||
255 | public function setBulkCommitSize($bulkCommitSize) |
||
259 | |||
260 | /** |
||
261 | * Creates a repository. |
||
262 | * |
||
263 | * @param string $className |
||
264 | * |
||
265 | * @return Repository |
||
266 | */ |
||
267 | private function createRepository($className) |
||
271 | |||
272 | /** |
||
273 | * Executes search query in the index. |
||
274 | * |
||
275 | * @param array $types List of types to search in. |
||
276 | * @param array $query Query to execute. |
||
277 | * @param array $queryStringParams Query parameters. |
||
278 | * |
||
279 | * @return array |
||
280 | */ |
||
281 | public function search(array $types, array $query, array $queryStringParams = []) |
||
302 | |||
303 | /** |
||
304 | * Adds document to next flush. |
||
305 | * |
||
306 | * @param object $document |
||
307 | */ |
||
308 | public function persist($document) |
||
315 | |||
316 | /** |
||
317 | * Adds document for removal. |
||
318 | * |
||
319 | * @param object $document |
||
320 | */ |
||
321 | public function remove($document) |
||
335 | |||
336 | /** |
||
337 | * Flushes elasticsearch index. |
||
338 | * |
||
339 | * @param array $params |
||
340 | * |
||
341 | * @return array |
||
342 | */ |
||
343 | public function flush(array $params = []) |
||
347 | |||
348 | /** |
||
349 | * Refreshes elasticsearch index. |
||
350 | * |
||
351 | * @param array $params |
||
352 | * |
||
353 | * @return array |
||
354 | */ |
||
355 | public function refresh(array $params = []) |
||
359 | |||
360 | /** |
||
361 | * Inserts the current query container to the index, used for bulk queries execution. |
||
362 | * |
||
363 | * @param array $params Parameters that will be passed to the flush or refresh queries. |
||
364 | * |
||
365 | * @return null|array |
||
366 | * |
||
367 | * @throws BulkWithErrorsException |
||
368 | */ |
||
369 | public function commit(array $params = []) |
||
418 | |||
419 | /** |
||
420 | * Adds query to bulk queries container. |
||
421 | * |
||
422 | * @param string $operation One of: index, update, delete, create. |
||
423 | * @param string|array $type Elasticsearch type name. |
||
424 | * @param array $query DSL to execute. |
||
425 | * |
||
426 | * @throws \InvalidArgumentException |
||
427 | * |
||
428 | * @return null|array |
||
429 | */ |
||
430 | public function bulk($operation, $type, array $query) |
||
478 | |||
479 | /** |
||
480 | * Optional setter to change bulk query params. |
||
481 | * |
||
482 | * @param array $params Possible keys: |
||
483 | * ['consistency'] = (enum) Explicit write consistency setting for the operation. |
||
484 | * ['refresh'] = (boolean) Refresh the index after performing the operation. |
||
485 | * ['replication'] = (enum) Explicitly set the replication type. |
||
486 | */ |
||
487 | public function setBulkParams(array $params) |
||
491 | |||
492 | /** |
||
493 | * Creates fresh elasticsearch index. |
||
494 | * |
||
495 | * @param bool $noMapping Determines if mapping should be included. |
||
496 | * |
||
497 | * @return array |
||
498 | */ |
||
499 | public function createIndex($noMapping = false) |
||
507 | |||
508 | /** |
||
509 | * Drops elasticsearch index. |
||
510 | */ |
||
511 | public function dropIndex() |
||
515 | |||
516 | /** |
||
517 | * Tries to drop and create fresh elasticsearch index. |
||
518 | * |
||
519 | * @param bool $noMapping Determines if mapping should be included. |
||
520 | * |
||
521 | * @return array |
||
522 | */ |
||
523 | public function dropAndCreateIndex($noMapping = false) |
||
533 | |||
534 | /** |
||
535 | * Checks if connection index is already created. |
||
536 | * |
||
537 | * @return bool |
||
538 | */ |
||
539 | public function indexExists() |
||
543 | |||
544 | /** |
||
545 | * Returns index name this connection is attached to. |
||
546 | * |
||
547 | * @return string |
||
548 | */ |
||
549 | public function getIndexName() |
||
553 | |||
554 | /** |
||
555 | * Sets index name for this connection. |
||
556 | * |
||
557 | * @param string $name |
||
558 | */ |
||
559 | public function setIndexName($name) |
||
563 | |||
564 | /** |
||
565 | * Returns mappings of the index for this connection. |
||
566 | * |
||
567 | * @return array |
||
568 | */ |
||
569 | public function getIndexMappings() |
||
573 | |||
574 | /** |
||
575 | * Returns Elasticsearch version number. |
||
576 | * |
||
577 | * @return string |
||
578 | */ |
||
579 | public function getVersionNumber() |
||
583 | |||
584 | /** |
||
585 | * Clears elasticsearch client cache. |
||
586 | */ |
||
587 | public function clearCache() |
||
591 | |||
592 | /** |
||
593 | * Returns a single document by ID. Returns NULL if document was not found. |
||
594 | * |
||
595 | * @param string $className Document class name or Elasticsearch type name |
||
596 | * @param string $id Document ID to find |
||
597 | * @param string $routing Custom routing for the document |
||
598 | * |
||
599 | * @return object |
||
600 | */ |
||
601 | public function find($className, $id, $routing = null) |
||
623 | |||
624 | /** |
||
625 | * Fetches next set of results. |
||
626 | * |
||
627 | * @param string $scrollId |
||
628 | * @param string $scrollDuration |
||
629 | * |
||
630 | * @return mixed |
||
631 | * |
||
632 | * @throws \Exception |
||
633 | */ |
||
634 | public function scroll( |
||
642 | |||
643 | /** |
||
644 | * Clears scroll. |
||
645 | * |
||
646 | * @param string $scrollId |
||
647 | */ |
||
648 | public function clearScroll($scrollId) |
||
652 | |||
653 | /** |
||
654 | * Calls "Get Settings API" in Elasticsearch and will return you the currently configured settings. |
||
655 | * |
||
656 | * return array |
||
657 | */ |
||
658 | public function getSettings() |
||
662 | |||
663 | /** |
||
664 | * Gets Elasticsearch aliases information. |
||
665 | * @param $params |
||
666 | * |
||
667 | * @return array |
||
668 | */ |
||
669 | public function getAliases($params = []) |
||
673 | |||
674 | /** |
||
675 | * Resolves type name by class name. |
||
676 | * |
||
677 | * @param string $className |
||
678 | * |
||
679 | * @return string |
||
680 | */ |
||
681 | private function resolveTypeName($className) |
||
689 | |||
690 | /** |
||
691 | * Starts and stops an event in the stopwatch |
||
692 | * |
||
693 | * @param string $action only 'start' and 'stop' |
||
694 | * @param string $name name of the event |
||
695 | */ |
||
696 | private function stopwatch($action, $name) |
||
702 | } |
||
703 |
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: