Complex classes like Manager often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Manager, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
32 | class Manager |
||
33 | { |
||
34 | /** |
||
35 | * @var string Manager name |
||
36 | */ |
||
37 | private $name; |
||
38 | |||
39 | /** |
||
40 | * @var array Manager configuration |
||
41 | */ |
||
42 | private $config = []; |
||
43 | |||
44 | /** |
||
45 | * @var Client |
||
46 | */ |
||
47 | private $client; |
||
48 | |||
49 | /** |
||
50 | * @var Converter |
||
51 | */ |
||
52 | private $converter; |
||
53 | |||
54 | /** |
||
55 | * @var array Container for bulk queries |
||
56 | */ |
||
57 | private $bulkQueries = []; |
||
58 | |||
59 | /** |
||
60 | * @var array Holder for consistency, refresh and replication parameters |
||
61 | */ |
||
62 | private $bulkParams = []; |
||
63 | |||
64 | /** |
||
65 | * @var array |
||
66 | */ |
||
67 | private $indexSettings; |
||
68 | |||
69 | /** |
||
70 | * @var MetadataCollector |
||
71 | */ |
||
72 | private $metadataCollector; |
||
73 | |||
74 | /** |
||
75 | * After commit to make data available the refresh or flush operation is needed |
||
76 | * so one of those methods has to be defined, the default is refresh. |
||
77 | * |
||
78 | * @var string |
||
79 | */ |
||
80 | private $commitMode = 'refresh'; |
||
81 | |||
82 | /** |
||
83 | * The size that defines after how much document inserts call commit function. |
||
84 | * |
||
85 | * @var int |
||
86 | */ |
||
87 | private $bulkCommitSize = 100; |
||
88 | |||
89 | /** |
||
90 | * Container to count how many documents was passed to the bulk query. |
||
91 | * |
||
92 | * @var int |
||
93 | */ |
||
94 | private $bulkCount = 0; |
||
95 | |||
96 | /** |
||
97 | * @var Repository[] Repository local cache |
||
98 | */ |
||
99 | private $repositories; |
||
100 | |||
101 | /** |
||
102 | * @var EventDispatcherInterface |
||
103 | */ |
||
104 | private $eventDispatcher; |
||
105 | |||
106 | /** |
||
107 | * @param string $name Manager name |
||
108 | * @param array $config Manager configuration |
||
109 | * @param Client $client |
||
110 | * @param array $indexSettings |
||
111 | * @param MetadataCollector $metadataCollector |
||
112 | * @param Converter $converter |
||
113 | */ |
||
114 | public function __construct( |
||
115 | $name, |
||
116 | array $config, |
||
117 | $client, |
||
118 | array $indexSettings, |
||
119 | $metadataCollector, |
||
120 | $converter |
||
121 | ) { |
||
122 | $this->name = $name; |
||
123 | $this->config = $config; |
||
124 | $this->client = $client; |
||
125 | $this->indexSettings = $indexSettings; |
||
126 | $this->metadataCollector = $metadataCollector; |
||
127 | $this->converter = $converter; |
||
128 | } |
||
129 | |||
130 | /** |
||
131 | * Returns Elasticsearch connection. |
||
132 | * |
||
133 | * @return Client |
||
134 | */ |
||
135 | public function getClient() |
||
136 | { |
||
137 | return $this->client; |
||
138 | } |
||
139 | |||
140 | /** |
||
141 | * @return string |
||
142 | */ |
||
143 | public function getName() |
||
144 | { |
||
145 | return $this->name; |
||
146 | } |
||
147 | |||
148 | /** |
||
149 | * @return array |
||
150 | */ |
||
151 | public function getConfig() |
||
152 | { |
||
153 | return $this->config; |
||
154 | } |
||
155 | |||
156 | /** |
||
157 | * @param EventDispatcherInterface $eventDispatcher |
||
158 | */ |
||
159 | public function setEventDispatcher(EventDispatcherInterface $eventDispatcher) |
||
160 | { |
||
161 | $this->eventDispatcher = $eventDispatcher; |
||
162 | } |
||
163 | |||
164 | /** |
||
165 | * Returns repository by document class. |
||
166 | * |
||
167 | * @param string $className FQCN or string in Bundle:Document format |
||
168 | * |
||
169 | * @return Repository |
||
170 | */ |
||
171 | public function getRepository($className) |
||
172 | { |
||
173 | if (!is_string($className)) { |
||
174 | throw new \InvalidArgumentException('Document class must be a string.'); |
||
175 | } |
||
176 | |||
177 | $namespace = $this->getMetadataCollector()->getClassName($className); |
||
178 | |||
179 | if (isset($this->repositories[$namespace])) { |
||
180 | return $this->repositories[$namespace]; |
||
181 | } |
||
182 | |||
183 | $repository = $this->createRepository($namespace); |
||
184 | $this->repositories[$namespace] = $repository; |
||
185 | |||
186 | return $repository; |
||
187 | } |
||
188 | |||
189 | /** |
||
190 | * @return MetadataCollector |
||
191 | */ |
||
192 | public function getMetadataCollector() |
||
193 | { |
||
194 | return $this->metadataCollector; |
||
195 | } |
||
196 | |||
197 | /** |
||
198 | * @return Converter |
||
199 | */ |
||
200 | public function getConverter() |
||
201 | { |
||
202 | return $this->converter; |
||
203 | } |
||
204 | |||
205 | /** |
||
206 | * @return string |
||
207 | */ |
||
208 | public function getCommitMode() |
||
209 | { |
||
210 | return $this->commitMode; |
||
211 | } |
||
212 | |||
213 | /** |
||
214 | * @param string $commitMode |
||
215 | */ |
||
216 | public function setCommitMode($commitMode) |
||
217 | { |
||
218 | if ($commitMode === 'refresh' || $commitMode === 'flush' || $commitMode === 'none') { |
||
219 | $this->commitMode = $commitMode; |
||
220 | } else { |
||
221 | throw new \LogicException('The commit method must be either refresh, flush or none.'); |
||
222 | } |
||
223 | } |
||
224 | |||
225 | /** |
||
226 | * @return int |
||
227 | */ |
||
228 | public function getBulkCommitSize() |
||
229 | { |
||
230 | return $this->bulkCommitSize; |
||
231 | } |
||
232 | |||
233 | /** |
||
234 | * @param int $bulkCommitSize |
||
235 | */ |
||
236 | public function setBulkCommitSize($bulkCommitSize) |
||
237 | { |
||
238 | $this->bulkCommitSize = $bulkCommitSize; |
||
239 | } |
||
240 | |||
241 | /** |
||
242 | * Creates a repository. |
||
243 | * |
||
244 | * @param string $className |
||
245 | * |
||
246 | * @return Repository |
||
247 | */ |
||
248 | private function createRepository($className) |
||
249 | { |
||
250 | return new Repository($this, $className); |
||
251 | } |
||
252 | |||
253 | /** |
||
254 | * Executes search query in the index. |
||
255 | * |
||
256 | * @param array $types List of types to search in. |
||
257 | * @param array $query Query to execute. |
||
258 | * @param array $queryStringParams Query parameters. |
||
259 | * |
||
260 | * @return array |
||
261 | */ |
||
262 | public function search(array $types, array $query, array $queryStringParams = []) |
||
263 | { |
||
264 | $params = []; |
||
265 | $params['index'] = $this->getIndexName(); |
||
266 | $params['type'] = implode(',', $types); |
||
267 | $params['body'] = $query; |
||
268 | |||
269 | if (!empty($queryStringParams)) { |
||
270 | $params = array_merge($queryStringParams, $params); |
||
271 | } |
||
272 | |||
273 | return $this->client->search($params); |
||
274 | } |
||
275 | |||
276 | /** |
||
277 | * Adds document to next flush. |
||
278 | * |
||
279 | * @param object $document |
||
280 | */ |
||
281 | public function persist($document) |
||
282 | { |
||
283 | $documentArray = $this->converter->convertToArray($document); |
||
284 | $type = $this->getMetadataCollector()->getDocumentType(get_class($document)); |
||
285 | |||
286 | $this->bulk('index', $type, $documentArray); |
||
287 | } |
||
288 | |||
289 | /** |
||
290 | * Adds document for removal. |
||
291 | * |
||
292 | * @param object $document |
||
293 | */ |
||
294 | public function remove($document) |
||
295 | { |
||
296 | $data = $this->converter->convertToArray($document, [], ['_id']); |
||
297 | |||
298 | if (!isset($data['_id'])) { |
||
299 | throw new \LogicException( |
||
300 | 'In order to use remove() method document class must have property with @Id annotation.' |
||
301 | ); |
||
302 | } |
||
303 | |||
304 | $type = $this->getMetadataCollector()->getDocumentType(get_class($document)); |
||
305 | |||
306 | $this->bulk('delete', $type, ['_id' => $data['_id']]); |
||
307 | } |
||
308 | |||
309 | /** |
||
310 | * Flushes elasticsearch index. |
||
311 | * |
||
312 | * @param array $params |
||
313 | * |
||
314 | * @return array |
||
315 | */ |
||
316 | public function flush(array $params = []) |
||
317 | { |
||
318 | return $this->client->indices()->flush(array_merge(['index' => $this->getIndexName()], $params)); |
||
319 | } |
||
320 | |||
321 | /** |
||
322 | * Refreshes elasticsearch index. |
||
323 | * |
||
324 | * @param array $params |
||
325 | * |
||
326 | * @return array |
||
327 | */ |
||
328 | public function refresh(array $params = []) |
||
329 | { |
||
330 | return $this->client->indices()->refresh(array_merge(['index' => $this->getIndexName()], $params)); |
||
331 | } |
||
332 | |||
333 | /** |
||
334 | * Inserts the current query container to the index, used for bulk queries execution. |
||
335 | * |
||
336 | * @param array $params Parameters that will be passed to the flush or refresh queries. |
||
337 | * |
||
338 | * @return null|array |
||
339 | */ |
||
340 | public function commit(array $params = []) |
||
341 | { |
||
342 | if (!empty($this->bulkQueries)) { |
||
343 | $bulkQueries = array_merge($this->bulkQueries, $this->bulkParams); |
||
344 | |||
345 | $this->eventDispatcher->dispatch( |
||
346 | Events::PRE_COMMIT, |
||
347 | new CommitEvent($this->getCommitMode(), $bulkQueries) |
||
348 | ); |
||
349 | |||
350 | $bulkResponse = $this->client->bulk($bulkQueries); |
||
351 | $this->bulkQueries = []; |
||
352 | $this->bulkCount = 0; |
||
353 | |||
354 | switch ($this->getCommitMode()) { |
||
355 | case 'flush': |
||
356 | $this->flush($params); |
||
357 | break; |
||
358 | case 'refresh': |
||
359 | $this->refresh($params); |
||
360 | break; |
||
361 | } |
||
362 | |||
363 | $this->eventDispatcher->dispatch( |
||
364 | Events::POST_COMMIT, |
||
365 | new CommitEvent($this->getCommitMode(), $bulkResponse) |
||
|
|||
366 | ); |
||
367 | |||
368 | return $bulkResponse; |
||
369 | } |
||
370 | |||
371 | return null; |
||
372 | } |
||
373 | |||
374 | /** |
||
375 | * Adds query to bulk queries container. |
||
376 | * |
||
377 | * @param string $operation One of: index, update, delete, create. |
||
378 | * @param string|array $type Elasticsearch type name. |
||
379 | * @param array $query DSL to execute. |
||
380 | * |
||
381 | * @throws \InvalidArgumentException |
||
382 | * |
||
383 | * @return null|array |
||
384 | */ |
||
385 | public function bulk($operation, $type, array $query) |
||
386 | { |
||
387 | if (!in_array($operation, ['index', 'create', 'update', 'delete'])) { |
||
388 | throw new \InvalidArgumentException('Wrong bulk operation selected'); |
||
389 | } |
||
390 | |||
391 | $this->eventDispatcher->dispatch( |
||
392 | Events::BULK, |
||
393 | new BulkEvent($operation, $type, $query) |
||
394 | ); |
||
395 | |||
396 | $this->bulkQueries['body'][] = [ |
||
397 | $operation => array_filter( |
||
398 | [ |
||
399 | '_index' => $this->getIndexName(), |
||
400 | '_type' => $type, |
||
401 | '_id' => isset($query['_id']) ? $query['_id'] : null, |
||
402 | '_ttl' => isset($query['_ttl']) ? $query['_ttl'] : null, |
||
403 | '_parent' => isset($query['_parent']) ? $query['_parent'] : null, |
||
404 | ] |
||
405 | ), |
||
406 | ]; |
||
407 | unset($query['_id'], $query['_ttl'], $query['_parent']); |
||
408 | |||
409 | switch ($operation) { |
||
410 | case 'index': |
||
411 | case 'create': |
||
412 | case 'update': |
||
413 | $this->bulkQueries['body'][] = $query; |
||
414 | break; |
||
415 | case 'delete': |
||
416 | // Body for delete operation is not needed to apply. |
||
417 | default: |
||
418 | // Do nothing. |
||
419 | break; |
||
420 | } |
||
421 | |||
422 | // We are using counter because there is to difficult to resolve this from bulkQueries array. |
||
423 | $this->bulkCount++; |
||
424 | |||
425 | $response = null; |
||
426 | if ($this->bulkCommitSize === $this->bulkCount) { |
||
427 | $response = $this->commit(); |
||
428 | } |
||
429 | |||
430 | return $response; |
||
431 | } |
||
432 | |||
433 | /** |
||
434 | * Optional setter to change bulk query params. |
||
435 | * |
||
436 | * @param array $params Possible keys: |
||
437 | * ['consistency'] = (enum) Explicit write consistency setting for the operation. |
||
438 | * ['refresh'] = (boolean) Refresh the index after performing the operation. |
||
439 | * ['replication'] = (enum) Explicitly set the replication type. |
||
440 | */ |
||
441 | public function setBulkParams(array $params) |
||
442 | { |
||
443 | $this->bulkParams = $params; |
||
444 | } |
||
445 | |||
446 | /** |
||
447 | * Creates fresh elasticsearch index. |
||
448 | * |
||
449 | * @param bool $noMapping Determines if mapping should be included. |
||
450 | * |
||
451 | * @return array |
||
452 | */ |
||
453 | public function createIndex($noMapping = false) |
||
454 | { |
||
455 | if ($noMapping) { |
||
456 | unset($this->indexSettings['body']['mappings']); |
||
457 | } |
||
458 | |||
459 | return $this->getClient()->indices()->create($this->indexSettings); |
||
460 | } |
||
461 | |||
462 | /** |
||
463 | * Drops elasticsearch index. |
||
464 | */ |
||
465 | public function dropIndex() |
||
466 | { |
||
467 | return $this->getClient()->indices()->delete(['index' => $this->getIndexName()]); |
||
468 | } |
||
469 | |||
470 | /** |
||
471 | * Tries to drop and create fresh elasticsearch index. |
||
472 | * |
||
473 | * @param bool $noMapping Determines if mapping should be included. |
||
474 | * |
||
475 | * @return array |
||
476 | */ |
||
477 | public function dropAndCreateIndex($noMapping = false) |
||
478 | { |
||
479 | try { |
||
480 | $this->dropIndex(); |
||
481 | } catch (\Exception $e) { |
||
482 | // Do nothing, our target is to create new index. |
||
483 | } |
||
484 | |||
485 | return $this->createIndex($noMapping); |
||
486 | } |
||
487 | |||
488 | /** |
||
489 | * Checks if connection index is already created. |
||
490 | * |
||
491 | * @return bool |
||
492 | */ |
||
493 | public function indexExists() |
||
494 | { |
||
495 | return $this->getClient()->indices()->exists(['index' => $this->getIndexName()]); |
||
496 | } |
||
497 | |||
498 | /** |
||
499 | * Returns index name this connection is attached to. |
||
500 | * |
||
501 | * @return string |
||
502 | */ |
||
503 | public function getIndexName() |
||
504 | { |
||
505 | return $this->indexSettings['index']; |
||
506 | } |
||
507 | |||
508 | /** |
||
509 | * Sets index name for this connection. |
||
510 | * |
||
511 | * @param string $name |
||
512 | */ |
||
513 | public function setIndexName($name) |
||
517 | |||
518 | /** |
||
519 | * Returns mappings of the index for this connection. |
||
520 | * |
||
521 | * @return array |
||
522 | */ |
||
523 | public function getIndexMappings() |
||
524 | { |
||
525 | return $this->indexSettings['body']['mappings']; |
||
526 | } |
||
527 | |||
528 | /** |
||
529 | * Returns Elasticsearch version number. |
||
530 | * |
||
531 | * @return string |
||
532 | */ |
||
533 | public function getVersionNumber() |
||
534 | { |
||
535 | return $this->client->info()['version']['number']; |
||
536 | } |
||
537 | |||
538 | /** |
||
539 | * Clears elasticsearch client cache. |
||
540 | */ |
||
541 | public function clearCache() |
||
542 | { |
||
543 | $this->getClient()->indices()->clearCache(['index' => $this->getIndexName()]); |
||
544 | } |
||
545 | |||
546 | /** |
||
547 | * Returns a single document by ID. Returns NULL if document was not found. |
||
548 | * |
||
549 | * @param string $className Document class name or Elasticsearch type name |
||
550 | * @param string $id Document ID to find |
||
551 | * |
||
552 | * @return object |
||
553 | */ |
||
554 | public function find($className, $id) |
||
572 | |||
573 | /** |
||
574 | * Executes given search. |
||
575 | * |
||
576 | * @param array $types |
||
577 | * @param Search $search |
||
578 | * @param string $resultsType |
||
579 | * |
||
580 | * @return DocumentIterator|RawIterator|array |
||
581 | */ |
||
582 | public function execute($types, Search $search, $resultsType = Result::RESULTS_OBJECT) |
||
592 | |||
593 | /** |
||
594 | * Parses raw result. |
||
595 | * |
||
596 | * @param array $raw |
||
597 | * @param string $resultsType |
||
598 | * @param string $scrollDuration |
||
599 | * |
||
600 | * @return DocumentIterator|RawIterator|array |
||
601 | * |
||
602 | * @throws \Exception |
||
603 | */ |
||
604 | private function parseResult($raw, $resultsType, $scrollDuration = null) |
||
625 | |||
626 | /** |
||
627 | * Normalizes response array. |
||
628 | * |
||
629 | * @param array $data |
||
630 | * |
||
631 | * @return array |
||
632 | */ |
||
633 | private function convertToNormalizedArray($data) |
||
653 | |||
654 | /** |
||
655 | * Fetches next set of results. |
||
656 | * |
||
657 | * @param string $scrollId |
||
658 | * @param string $scrollDuration |
||
659 | * @param string $resultsType |
||
660 | * |
||
661 | * @return AbstractResultsIterator |
||
662 | * |
||
663 | * @throws \Exception |
||
664 | */ |
||
665 | public function scroll( |
||
674 | |||
675 | /** |
||
676 | * Clears scroll. |
||
677 | * |
||
678 | * @param string $scrollId |
||
679 | */ |
||
680 | public function clearScroll($scrollId) |
||
684 | |||
685 | /** |
||
686 | * Resolves type name by class name. |
||
687 | * |
||
688 | * @param string $className |
||
689 | * |
||
690 | * @return string |
||
691 | */ |
||
692 | private function resolveTypeName($className) |
||
700 | } |
||
701 |
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: