ExportService::exportIndex() - Code Metrics - ongr-io/ElasticsearchBundle - Measure and Improve Code Quality continuously with Scrutinizer

ExportService::exportIndex() B
last analyzed 2020-03-31 10:30 UTC

↳ Parent: ExportService

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	64
rs	8.7853
c	0
b	0
f	0
cc	3
nc	3
nop	5

How to fix Long Method

<?php

/*
 * This file is part of the ONGR package.
 *
 * (c) NFQ Technologies UAB <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ONGR\ElasticsearchBundle\Service;

use Elasticsearch\Helper\Iterators\SearchHitIterator;
use Elasticsearch\Helper\Iterators\SearchResponseIterator;
use ONGR\ElasticsearchBundle\Result\RawIterator;
use ONGR\ElasticsearchBundle\Service\Json\JsonWriter;
use ONGR\ElasticsearchDSL\Query\MatchAllQuery;
use ONGR\ElasticsearchDSL\Search;
use Symfony\Component\Console\Helper\ProgressBar;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * ExportService class.
 */
class ExportService
{
    public function exportIndex(
        IndexService $index,
        $filename,
        $chunkSize,
        OutputInterface $output,
        $maxLinesInFile = 300000
    ) {
        $search = new Search();
        $search->addQuery(new MatchAllQuery());
        $search->setSize($chunkSize);
        $search->setScroll('2m');

        $searchResults = $index->search($search->toArray(), $search->getUriParams());

        $results = new RawIterator(
            $searchResults,
            $index,
            null,
            [
                'duration' => '2m',
                '_scroll_id' => $searchResults['_scroll_id'],
            ]
        );

        $progress = new ProgressBar($output, $results->count());
        $progress->setRedrawFrequency(100);
        $progress->start();

        $counter = $fileCounter = 0;
        $count = $this->getFileCount($results->count(), $maxLinesInFile, $fileCounter);

        $date = date(\DateTime::ISO8601);
        $metadata = [
            'count' => $count,
            'date' => $date,
        ];

        $filename = str_replace('.json', '', $filename);
        $writer = $this->getWriter($this->getFilePath($filename.'.json'), $metadata['count']);

        foreach ($results as $data) {
            if ($counter >= $maxLinesInFile) {
                $writer->finalize();
                $writer = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $fileCounter++;
                $count = $this->getFileCount($results->count(), $maxLinesInFile, $fileCounter);
                $metadata = [
                    'count' => $count,
                    'date' => $date,
                ];
                $writer = $this->getWriter($this->getFilePath($filename."_".$fileCounter.".json"), $metadata['count']);
                $counter = 0;
            }

            $doc = array_intersect_key($data, array_flip(['_id', '_source']));
            $writer->push($doc);
            $progress->advance();
            $counter++;
        }

        $writer->finalize();
        $progress->finish();
        $output->writeln('');
    }

    /**
     * Returns real file path.
     *
     * @param string $filename
     *
     * @return string
     */
    protected function getFilePath($filename): string

    {
        if ($filename[0] == '/' || strstr($filename, ':') !== false) {
            return $filename;
        }

        return getcwd() . '/' . $filename;
    }

    protected function getWriter(string $filename, int $count): JsonWriter
    {
        return new JsonWriter($filename, $count);
    }

    /**
     * @param int $resultsCount
     * @param int $maxLinesInFile
     * @param int $fileCounter
     *
     * @return int
     */
    protected function getFileCount($resultsCount, $maxLinesInFile, $fileCounter): int
    {
        $leftToInsert = $resultsCount - ($fileCounter * $maxLinesInFile);
        if ($leftToInsert <= $maxLinesInFile) {
            $count = $leftToInsert;
        } else {
            $count = $maxLinesInFile;
        }

        return (int) $count;
    }
}


1		<?php
2
3		/*
4		* This file is part of the ONGR package.
5		*
6		* (c) NFQ Technologies UAB <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace ONGR\ElasticsearchBundle\Service;
13
14		use Elasticsearch\Helper\Iterators\SearchHitIterator;
15		use Elasticsearch\Helper\Iterators\SearchResponseIterator;
16		use ONGR\ElasticsearchBundle\Result\RawIterator;
17		use ONGR\ElasticsearchBundle\Service\Json\JsonWriter;
18		use ONGR\ElasticsearchDSL\Query\MatchAllQuery;
19		use ONGR\ElasticsearchDSL\Search;
20		use Symfony\Component\Console\Helper\ProgressBar;
21		use Symfony\Component\Console\Output\OutputInterface;
22
23		/**
24		* ExportService class.
25		*/
26		class ExportService
27		{
28		public function exportIndex(
29		IndexService $index,
30		$filename,
31		$chunkSize,
32		OutputInterface $output,
33		$maxLinesInFile = 300000
34		) {
35		$search = new Search();
36		$search->addQuery(new MatchAllQuery());
37		$search->setSize($chunkSize);
38		$search->setScroll('2m');
39
40		$searchResults = $index->search($search->toArray(), $search->getUriParams());
41
42		$results = new RawIterator(
43		$searchResults,
44		$index,
45		null,
46		[
47		'duration' => '2m',
48		'_scroll_id' => $searchResults['_scroll_id'],
49		]
50		);
51
52		$progress = new ProgressBar($output, $results->count());
53		$progress->setRedrawFrequency(100);
54		$progress->start();
55
56		$counter = $fileCounter = 0;
57		$count = $this->getFileCount($results->count(), $maxLinesInFile, $fileCounter);
58
59		$date = date(\DateTime::ISO8601);
60		$metadata = [
61		'count' => $count,
62		'date' => $date,
63		];
64
65		$filename = str_replace('.json', '', $filename);
66		$writer = $this->getWriter($this->getFilePath($filename.'.json'), $metadata['count']);
67
68		foreach ($results as $data) {
69		if ($counter >= $maxLinesInFile) {
70		$writer->finalize();
71		$writer = null;
		0 ignored issues – show Unused Code introduced 2016-05-25 21:39 UTC by Report Bug Copy Issue Report `$writer` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
72		$fileCounter++;
73		$count = $this->getFileCount($results->count(), $maxLinesInFile, $fileCounter);
74		$metadata = [
75		'count' => $count,
76		'date' => $date,
77		];
78		$writer = $this->getWriter($this->getFilePath($filename."_".$fileCounter.".json"), $metadata['count']);
79		$counter = 0;
80		}
81
82		$doc = array_intersect_key($data, array_flip(['_id', '_source']));
83		$writer->push($doc);
84		$progress->advance();
85		$counter++;
86		}
87
88		$writer->finalize();
89		$progress->finish();
90		$output->writeln('');
91		}
92
93		/**
94		* Returns real file path.
95		*
96		* @param string $filename
97		*
98		* @return string
99		*/
100	View Code Duplication	protected function getFilePath($filename): string
		0 ignored issues – show Duplication introduced 2017-07-31 12:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
101		{
102		if ($filename[0] == '/' \|\| strstr($filename, ':') !== false) {
103		return $filename;
104		}
105
106		return getcwd() . '/' . $filename;
107		}
108
109		protected function getWriter(string $filename, int $count): JsonWriter
110		{
111		return new JsonWriter($filename, $count);
112		}
113
114		/**
115		* @param int $resultsCount
116		* @param int $maxLinesInFile
117		* @param int $fileCounter
118		*
119		* @return int
120		*/
121		protected function getFileCount($resultsCount, $maxLinesInFile, $fileCounter): int
122		{
123		$leftToInsert = $resultsCount - ($fileCounter * $maxLinesInFile);
124		if ($leftToInsert <= $maxLinesInFile) {
125		$count = $leftToInsert;
126		} else {
127		$count = $maxLinesInFile;
128		}
129
130		return (int) $count;
131		}
132		}
133

ongr-io / ElasticsearchBundle

ExportService::exportIndex() B last analyzed 2020-03-31 10:30 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

ExportService::exportIndex() B
last analyzed 2020-03-31 10:30 UTC