ArrayIterator - Code Metrics - ongr-io/ElasticsearchBundle - Measure and Improve Code Quality continuously with Scrutinizer

ArrayIterator A
last analyzed 2020-03-31 10:30 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	7
lcom	1
cbo	1
dl	0
loc	35
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	offsetExists()	4	1
A	offsetGet()	4	1
A	offsetSet()	4	1
A	offsetUnset()	4	1
A	convertDocument()	12	3

<?php

/*
 * This file is part of the ONGR package.
 *
 * (c) NFQ Technologies UAB <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ONGR\ElasticsearchBundle\Result;

class ArrayIterator extends AbstractResultsIterator implements \ArrayAccess
{
    public function offsetExists($offset)
    {
        return $this->documentExists($offset);
    }

    public function offsetGet($offset)
    {
        return $this->getDocument($offset);
    }

    public function offsetSet($offset, $value)
    {
        $this->documents[$offset] = $value;
    }

    public function offsetUnset($offset)
    {
        unset($this->documents[$offset]);
    }

    protected function convertDocument(array $raw)
    {
        if (array_key_exists('_source', $raw)) {
            $doc = $raw['_source'];
        } elseif (array_key_exists('fields', $raw)) {
            $doc = array_map('reset', $raw['fields']);
        }

        $doc['_id'] = $raw['_id'];
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

        return $doc;
    }
}


1			<?php
2
3			/*
4			* This file is part of the ONGR package.
5			*
6			* (c) NFQ Technologies UAB <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace ONGR\ElasticsearchBundle\Result;
13
14			class ArrayIterator extends AbstractResultsIterator implements \ArrayAccess
15			{
16			public function offsetExists($offset)
17			{
18			return $this->documentExists($offset);
19			}
20
21			public function offsetGet($offset)
22			{
23			return $this->getDocument($offset);
24			}
25
26			public function offsetSet($offset, $value)
27			{
28			$this->documents[$offset] = $value;
29			}
30
31			public function offsetUnset($offset)
32			{
33			unset($this->documents[$offset]);
34			}
35
36			protected function convertDocument(array $raw)
37			{
38			if (array_key_exists('_source', $raw)) {
39			$doc = $raw['_source'];
40			} elseif (array_key_exists('fields', $raw)) {
41			$doc = array_map('reset', $raw['fields']);
42			}
43
44			$doc['_id'] = $raw['_id'];
			0 ignored issues – show Bug introduced 2019-03-18 22:16 UTC by Report Bug Copy Issue Report The variable `$doc` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
45
46			return $doc;
47			}
48			}
49

ongr-io / ElasticsearchBundle

ArrayIterator A last analyzed 2020-03-31 10:30 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like

ArrayIterator A
last analyzed 2020-03-31 10:30 UTC