EcbDriver::getRates() - Code Metrics - Inspection of "Merge pull request #36 from mvar/misleading_method" - ongr-io/CurrencyExchangeBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 45f7ef...cf154d )

by Simonas

created 2015-12-18 13:18 UTC

EcbDriver::getRates() A

↳ Parent: EcbDriver

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	13
rs	9.4286
cc	2
eloc	9
nc	2
nop	0

<?php

/*
 * This file is part of the ONGR package.
 *
 * (c) NFQ Technologies UAB <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ONGR\CurrencyExchangeBundle\Driver;

/**
 * This class downloads exchange rates from http://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml.
 */
class EcbDriver implements CurrencyDriverInterface
{
    /**
     * {@inheritdoc}
     */
    public function getRates()
    {
        $rates = [];
        $xml = @simplexml_load_file('http://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml');
        $data = $xml->xpath('//gesmes:Envelope/*[3]/*');
        foreach ($data[0]->children() as $child) {
            $code = (string)$child->attributes()->currency;
            $rate = (float)$child->attributes()->rate;
            $rates[$code] = $rate;
        }

        return $rates;
    }

    /**
     * {@inheritdoc}
     */
    public function getBaseCurrency()
    {
        // Default base currency of The European Central Bank
        return 'EUR';
    }
}


1			<?php
2
3			/*
4			* This file is part of the ONGR package.
5			*
6			* (c) NFQ Technologies UAB <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace ONGR\CurrencyExchangeBundle\Driver;
13
14			/**
15			* This class downloads exchange rates from http://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml.
16			*/
17			class EcbDriver implements CurrencyDriverInterface
18			{
19			/**
20			* {@inheritdoc}
21			*/
22			public function getRates()
23			{
24			$rates = [];
25			$xml = @simplexml_load_file('http://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml');
26			$data = $xml->xpath('//gesmes:Envelope/[3]/');
27			foreach ($data[0]->children() as $child) {
28			$code = (string)$child->attributes()->currency;
29			$rate = (float)$child->attributes()->rate;
30			$rates[$code] = $rate;
31			}
32
33			return $rates;
34			}
35
36			/**
37			* {@inheritdoc}
38			*/
39			public function getBaseCurrency()
40			{
41			// Default base currency of The European Central Bank
42			return 'EUR';
43			}
44			}
45

ongr-io / CurrencyExchangeBundle

Push — master ( 45f7ef...cf154d )

EcbDriver::getRates() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like