Cache::getMultiple() - Code Metrics - onericcomputing/mmanager-module-builder - Measure and Improve Code Quality continuously with Scrutinizer

Cache::getMultiple() A
last analyzed 2020-06-07 09:40 UTC

↳ Parent: Cache

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	9
Ratio	100 %

Importance

Changes

Metric	Value
dl	9
loc	9
c	0
b	0
f	0
rs	9.9666
cc	3
nc	4
nop	2

<?php
/**
 * m'Manager | Invoices Management System
 * 
 * This content is released under the Proprietary License (Proprietary)
 *
 * Copyright (c) 2017, Eric Claver AKAFFOU - All Rights Reserved
 * Unauthorized copying of this file, via any medium is strictly prohibited
 * Proprietary and confidential
 * 
 * @package m'Manager
 * @author  Eric Claver AKAFFOU
 * @copyright   Copyright (c) 2017, on'Eric Computing, Inc. (https://www.onericcomputing.com/)
 * @license https://www.mmanager.fr  Proprietary License
 * @link    https://codecanyon.net/item/mmanager-invoices-management-system/19866435?s_rank=1
 * @since   Version 1.0.0
 * @filesource 
 */
 
 namespace Mmanager\Persistence\Adapter\CodeIgniter;

 use Mmanager\Contract\CacheInterface;

 /**
  * Abstract Repository Class
  */
 class Cache implements CacheInterface {
 	protected $CI;
 	public function __construct() {
 		$this->CI = & get_instance();
 		$this->CI->load->driver('cache', array('adapter' => 'apc', 'backup' => 'file'));
 	}
 	public function get($key, $default = null) {
 		return $this->CI->cache->get($key);
 	}
 	public function set($key, $value, $ttl = 604800) {
 		return $this->CI->cache->save($key, $value, $ttl);
 	}
 	public function delete($key) {
 		return $this->CI->cache->delete($key);
 	}
 	public function clear() {
 		return $this->CI->cache->clean();
 	}
 	public function getMultiple($keys, $default = null) {

 		$return = [];
 		is_array($keys) OR $keys = array($keys);
 		foreach ($keys as &$value) {
 			array_push($return, $this->get($value));
 		}
 		unset($value);
 		return $return;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
 	}
 	public function setMultiple($values, $ttl = 604800) {

 		$return = [];
 		is_array($keys) OR $keys = array($keys);
function someFunction() {
    $x = 5;
    echo $x;
}
 		foreach ($keys as &$value) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
 			array_push($return, $this->set($value, $ttl));
 		}
 		unset($value);
 		return $return;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
 	}
 	public function deleteMultiple($keys) {
 		return [];
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
 	}
 	public function has($key) {
 		return $this->CI->cache->get($key);
 	}
 	public function cacheInfo() {
 		return $this->CI->cache->cache_info($type = 'user');
 	}
 }

1		<?php
2		/**
3		* m'Manager \| Invoices Management System
4		*
5		* This content is released under the Proprietary License (Proprietary)
6		*
7		* Copyright (c) 2017, Eric Claver AKAFFOU - All Rights Reserved
8		* Unauthorized copying of this file, via any medium is strictly prohibited
9		* Proprietary and confidential
10		*
11		* @package m'Manager
12		* @author Eric Claver AKAFFOU
13		* @copyright Copyright (c) 2017, on'Eric Computing, Inc. (https://www.onericcomputing.com/)
14		* @license https://www.mmanager.fr Proprietary License
15		* @link https://codecanyon.net/item/mmanager-invoices-management-system/19866435?s_rank=1
16		* @since Version 1.0.0
17		* @filesource
18		*/
19
20		namespace Mmanager\Persistence\Adapter\CodeIgniter;
21
22		use Mmanager\Contract\CacheInterface;
23
24		/**
25		* Abstract Repository Class
26		*/
27		class Cache implements CacheInterface {
28		protected $CI;
29		public function __construct() {
30		$this->CI = & get_instance();
31		$this->CI->load->driver('cache', array('adapter' => 'apc', 'backup' => 'file'));
32		}
33		public function get($key, $default = null) {
34		return $this->CI->cache->get($key);
35		}
36		public function set($key, $value, $ttl = 604800) {
37		return $this->CI->cache->save($key, $value, $ttl);
38		}
39		public function delete($key) {
40		return $this->CI->cache->delete($key);
41		}
42		public function clear() {
43		return $this->CI->cache->clean();
44		}
45	View Code Duplication	public function getMultiple($keys, $default = null) {
		0 ignored issues – show Duplication introduced 2020-06-07 09:40 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
46		$return = [];
47		is_array($keys) OR $keys = array($keys);
48		foreach ($keys as &$value) {
49		array_push($return, $this->get($value));
50		}
51		unset($value);
52		return $return;
		0 ignored issues – show Bug Best Practice introduced 2020-06-07 09:40 UTC by Report Bug Copy Issue Report The return type of `return $return;` (`array`) is incompatible with the return type declared by the interface `Mmanager\Contract\CacheInterface::getMultiple` of type `Mmanager\Contract\iterable`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
53		}
54	View Code Duplication	public function setMultiple($values, $ttl = 604800) {
		0 ignored issues – show Duplication introduced 2020-06-07 09:40 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
55		$return = [];
56		is_array($keys) OR $keys = array($keys);
		0 ignored issues – show Bug introduced 2020-06-07 09:40 UTC by Report Bug Copy Issue Report The variable `$keys` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
57		foreach ($keys as &$value) {
		0 ignored issues – show Bug introduced 2020-06-07 09:40 UTC by Report Bug Copy Issue Report The variable `$keys` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
58		array_push($return, $this->set($value, $ttl));
59		}
60		unset($value);
61		return $return;
		0 ignored issues – show Bug Best Practice introduced 2020-06-07 09:40 UTC by Report Bug Copy Issue Report The return type of `return $return;` (`array`) is incompatible with the return type declared by the interface `Mmanager\Contract\CacheInterface::setMultiple` of type `boolean`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
62		}
63		public function deleteMultiple($keys) {
64		return [];
		0 ignored issues – show Bug Best Practice introduced 2020-06-07 09:40 UTC by Report Bug Copy Issue Report The return type of `return array();` (`array`) is incompatible with the return type declared by the interface `Mmanager\Contract\CacheInterface::deleteMultiple` of type `boolean`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
65		}
66		public function has($key) {
67		return $this->CI->cache->get($key);
68		}
69		public function cacheInfo() {
70		return $this->CI->cache->cache_info($type = 'user');
71		}
72		}

onericcomputing / mmanager-module-builder

Cache::getMultiple() A last analyzed 2020-06-07 09:40 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

Cache::getMultiple() A
last analyzed 2020-06-07 09:40 UTC