Ivory\Query\ConstrainedRelationDefinition

Complexity

Total Complexity

5

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	3
A	toSql()	0	13	2

<?php
namespace Ivory\Query;

use Ivory\Lang\Sql\ISqlPredicate;
use Ivory\Lang\SqlPattern\SqlPattern;
use Ivory\Type\ITypeDictionary;

class ConstrainedRelationDefinition extends RelationDefinition implements IRelationDefinition
{
    private $baseRelDef;
    private $cond;
    private $args;

    /**
     * @param IRelationDefinition $relationDefinition definition of relation to constrain
     * @param ISqlPredicate|SqlPattern|string $cond
     * @param array $args
     */
    public function __construct(IRelationDefinition $relationDefinition, $cond, ...$args)
    {
        if ($cond instanceof ISqlPredicate && $args) {

The expression $args of type array[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            throw new \InvalidArgumentException('$args not supported for ' . ISqlPredicate::class . ' condition');
        }


        $this->baseRelDef = $relationDefinition;
        $this->cond = $cond;
        $this->args = $args;
    }

    public function toSql(ITypeDictionary $typeDictionary): string
    {
        $relSql = $this->baseRelDef->toSql($typeDictionary);

        if ($this->cond instanceof ISqlPredicate) {
            $condSql = $this->cond->getSql();
        } else {
            $condDef = SqlRelationDefinition::fromPattern($this->cond, ...$this->args);
            $condSql = $condDef->toSql($typeDictionary);
        }

        return "SELECT *\nFROM (\n$relSql\n) t\nWHERE $condSql";
    }
}