Ivory\Value\XmlContent::fromValue()

Complexity

Conditions	15
Paths	20

Size

Total Lines	47
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function fromValue($value): XmlContent
    {
        if (is_string($value)) {
            $xmlStr = $value;
            $isDoc = self::isXmlDocument($value);
        } elseif ($value instanceof XmlContent) {
            return $value;
        } elseif ($value instanceof \DOMDocument) {
            $xmlStr = $value->saveXML();
            if ($xmlStr === false) {
                throw new \InvalidArgumentException('value');
            }
            $isDoc = true;
        } elseif ($value instanceof \DOMNode) {
            $d = $value->ownerDocument->saveXML($value);

The method saveXML() does not exist on null.

            if ($d === false) {
                throw new \InvalidArgumentException('value');
            }
            $xmlStr = self::getXMLDeclaration($value->ownerDocument) . $d;

It seems like $value->ownerDocument can also be of type null; however, parameter $doc of Ivory\Value\XmlContent::getXMLDeclaration() does only seem to accept DOMDocument, maybe add an additional type check?

            $isDoc = true;
        } elseif ($value instanceof \DOMNodeList) {
            $xmlStr = ($value->length > 0 ? self::getXMLDeclaration($value->item(0)->ownerDocument) : '');
            foreach ($value as $i => $node) {
                $n = $node->ownerDocument->saveXML($node);
                if ($n === false) {
                    throw new \InvalidArgumentException("value, node $i");
                }
                $xmlStr .= $n;
            }
            $isDoc = ($value->length == 1);
        } elseif ($value instanceof \SimpleXMLElement) {
            $xmlStr = $value->saveXML();
            if ($xmlStr === false) {
                throw new \InvalidArgumentException('value');
            }
            $isDoc = true;
        } elseif (is_object($value)) {
            $xmlStr = (string)$value;
            $isDoc = self::isXmlDocument($xmlStr);
        } else {
            throw new \InvalidArgumentException('value');
        }

        if ($isDoc) {
            return new XmlDocument($xmlStr);

It seems like $xmlStr can also be of type true; however, parameter $xmlStr of Ivory\Value\XmlDocument::__construct() does only seem to accept string, maybe add an additional type check?

        } else {
            return new XmlContent($xmlStr);

It seems like $xmlStr can also be of type true; however, parameter $xmlStr of Ivory\Value\XmlContent::__construct() does only seem to accept string, maybe add an additional type check?

        }