Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
10 | View Code Duplication | class ComposeManagerPsTest extends PHPUnit_Framework_TestCase |
|
|
|||
11 | { |
||
12 | public function setUp() |
||
18 | |||
19 | /** |
||
20 | * Test simple ps without error |
||
21 | */ |
||
22 | public function testPs() |
||
27 | |||
28 | /** |
||
29 | * Test ps success with one compose file |
||
30 | */ |
||
31 | public function testPsWithOneComposeFileSpecified() |
||
36 | |||
37 | /** |
||
38 | * Test ps success with two compose files |
||
39 | */ |
||
40 | public function testPsWithTwoComposeFilesSpecified() |
||
45 | |||
46 | /** |
||
47 | * Test ps with project option |
||
48 | */ |
||
49 | public function testPsWithprojectOption() |
||
58 | } |
||
59 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.