Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
10 | View Code Duplication | class ComposeManagerKillTest extends PHPUnit_Framework_TestCase |
|
|
|||
11 | { |
||
12 | public function setUp() |
||
18 | |||
19 | /** |
||
20 | * Test simple kill without error |
||
21 | */ |
||
22 | public function testKill() |
||
27 | |||
28 | /** |
||
29 | * Test simple kill with specific SIGNAL |
||
30 | */ |
||
31 | public function testKillWithSpecificSIGNAL() |
||
36 | |||
37 | /** |
||
38 | * Test kill success with one compose file |
||
39 | */ |
||
40 | public function testKillWithOneComposeFileSpecified() |
||
45 | |||
46 | /** |
||
47 | * Test kill success with two compose files |
||
48 | */ |
||
49 | public function testKillWithTwoComposeFilesSpecified() |
||
54 | |||
55 | /** |
||
56 | * Test kill with project option |
||
57 | */ |
||
58 | public function testKillWithprojectOption() |
||
68 | } |
||
69 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.