Omatech\Mage\Core\Domains\Shared\Traits\RolesManager

Complexity

Total Complexity

4

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	1	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	removeRole()	0	6	1
A	assignRoles()	0	6	1
A	removeRoles()	0	6	1
A	assignRole()	0	6	1

<?php

namespace Omatech\Mage\Core\Domains\Shared\Traits;

use Omatech\Mage\Core\Domains\Roles\Contracts\RoleInterface;
use Omatech\Mage\Core\Domains\Roles\RoleModel;

trait RolesManager
{
    /**
     * @param RoleInterface $role
     *
     * @throws \Illuminate\Contracts\Container\BindingResolutionException
     *
     * @return self
     */
    public function assignRole(RoleInterface $role): self
    {
        $this->roles = app()->make(RoleModel::class)

The property roles does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            ->assignRole($this->getRoles(), $role);

It seems like getRoles() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $this;
    }

    /**
     * @param array $roles
     *
     * @throws \Illuminate\Contracts\Container\BindingResolutionException
     *
     * @return self
     */
    public function assignRoles(array $roles): self
    {
        $this->roles = app()->make(RoleModel::class)

The property roles does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            ->assignRoles($this->getRoles(), $roles);

        return $this;
    }

    /**
     * @param RoleInterface $role
     *
     * @throws \Illuminate\Contracts\Container\BindingResolutionException
     *
     * @return self
     */
    public function removeRole(RoleInterface $role): self
    {
        $this->roles = app()->make(RoleModel::class)

The property roles does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            ->removeRole($this->getRoles(), $role);

        return $this;
    }

    /**
     * @param array $roles
     *
     * @throws \Illuminate\Contracts\Container\BindingResolutionException
     *
     * @return self
     */
    public function removeRoles(array $roles): self
    {
        $this->roles = app()->make(RoleModel::class)

The property roles does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            ->removeRoles($this->getRoles(), $roles);

        return $this;
    }
}