Omatech\Mage\Core\Domains\Shared\Traits\PermissionsManager

Complexity

Total Complexity

4

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	1	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	assignPermission()	0	6	1
A	assignPermissions()	0	6	1
A	removePermission()	0	6	1
A	removePermissions()	0	6	1

<?php

namespace Omatech\Mage\Core\Domains\Shared\Traits;

use Omatech\Mage\Core\Domains\Permissions\Contracts\PermissionInterface;
use Omatech\Mage\Core\Domains\Permissions\PermissionModel;

trait PermissionsManager
{
    /**
     * @param PermissionInterface $permission
     *
     * @throws \Illuminate\Contracts\Container\BindingResolutionException
     *
     * @return self
     */
    public function assignPermission(PermissionInterface $permission): self
    {
        $this->permissions = app()->make(PermissionModel::class)

The property permissions does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            ->assignPermission($this->getPermissions(), $permission);

It seems like getPermissions() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $this;
    }

    /**
     * @param array $permissions
     *
     * @throws \Illuminate\Contracts\Container\BindingResolutionException
     *
     * @return self
     */
    public function assignPermissions(array $permissions): self
    {
        $this->permissions = app()->make(PermissionModel::class)

The property permissions does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            ->assignPermissions($this->getPermissions(), $permissions);

        return $this;
    }

    /**
     * @param PermissionInterface $permission
     *
     * @throws \Illuminate\Contracts\Container\BindingResolutionException
     *
     * @return self
     */
    public function removePermission(PermissionInterface $permission): self
    {
        $this->permissions = app()->make(PermissionModel::class)

The property permissions does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            ->removePermission($this->getPermissions(), $permission);

        return $this;
    }

    /**
     * @param array $permissions
     *
     * @throws \Illuminate\Contracts\Container\BindingResolutionException
     *
     * @return self
     */
    public function removePermissions(array $permissions): self
    {
        $this->permissions = app()->make(PermissionModel::class)

The property permissions does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            ->removePermissions($this->getPermissions(), $permissions);

        return $this;
    }
}