Omatech\Mage\Core\Repositories\Roles\CreateRole

Complexity

Total Complexity

1

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	create()	0	17	1

<?php

namespace Omatech\Mage\Core\Repositories\Roles;

use Omatech\Mage\Core\Domains\Roles\Contracts\CreateRoleInterface;
use Omatech\Mage\Core\Domains\Roles\Contracts\RoleInterface;
use Omatech\Mage\Core\Events\Roles\RoleCreated;
use Omatech\Mage\Core\Repositories\RoleBaseRepository;

class CreateRole extends RoleBaseRepository implements CreateRoleInterface
{
    /**
     * @param RoleInterface $role
     * @return bool
     */
    public function create(RoleInterface $role): bool
    {
        $created = $this->query()->create([
            'name'       => $role->getName(),
            'guard_name' => $role->getGuardName(),
        ]);

        $role->setId($created->id);
        $role->setCreatedAt($created->created_at);
        $role->setUpdatedAt($created->updated_at);

        $this->syncPermissions($created, $role);

It seems like $created defined by $this->query()->create(array('name' => $role->getName(), 'guard_name' => $role->getGuardName())) on line 18 can also be of type object<Illuminate\Database\Eloquent\Builder>; however, Omatech\Mage\Core\Repositories\RoleBaseRepository::syncPermissions() does only seem to accept object<Omatech\Mage\Core\Models\Role>, maybe add an additional type check?

$role of type object<Omatech\Mage\Core\Domains\Roles\Contracts\RoleInterface> is not a sub-type of object<Omatech\Mage\Core\Domains\Roles\Role>. It seems like you assume a concrete implementation of the interface Omatech\Mage\Core\Domains\Roles\Contracts\RoleInterface to be always present.

        event(new RoleCreated($role, $created->wasRecentlyCreated));

        return $created->wasRecentlyCreated;
    }
}