olvlvl / elasticsearch-dsl

lib/Query/Term/TermsQuery.php

<?php

namespace olvlvl\ElasticsearchDSL\Query\Term;

use olvlvl\ElasticsearchDSL\Query\QueryAbstract;

/**
 * @see https://www.elastic.co/guide/en/elasticsearch/reference/5.6/query-dsl-terms-query.html
 */
class TermsQuery extends QueryAbstract
{
	const NAME = 'terms';

	/**
	 * @var string
	 */
	private $field;

	/**
	 * @var array
	 */
	private $values;

	/**
	 * @param string $field
	 * @param array $values
	 */
	public function __construct(string $field, array $values)
	{
		$this->field = $field;
		$this->values = $values;
	}

	/**
	 * @param null|string $index
	 *
	 * @return $this
	 */
	public function index(?string $index)
	{
		$this->options[__FUNCTION__] = $index;

		return $this;
	}

	/**
	 * @param null|string $type
	 *
	 * @return $this
	 */
	public function type(?string $type)
	{
		$this->options[__FUNCTION__] = $type;

		return $this;
	}

	/**
	 * @param null|string $id
	 *
	 * @return $this
	 */
	public function id(?string $id)
	{
		$this->options[__FUNCTION__] = $id;

		return $this;
	}

	/**
	 * @param null|string $path
	 *
	 * @return $this
	 */
	public function path(?string $path)
	{
		$this->options[__FUNCTION__] = $path;

		return $this;
	}

	/**
	 * @param null|string $routing
	 *
	 * @return $this
	 */
	public function routing(?string $routing)
	{
		$this->options[__FUNCTION__] = $routing;

		return $this;
	}

	/**
	 * @inheritdoc
	 */
	public function jsonSerialize()
	{
		$options = parent::jsonSerialize();

		if ($options) {

The expression $options of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

			return [ self::NAME => $options ];
		}

		return [ self::NAME => [ $this->field => $this->values ] ];
	}
}