IdentityNumberFormatter::getFormatted() - Code Metrics - olssonm/identity-number - Measure and Improve Code Quality continuously with Scrutinizer

IdentityNumberFormatter::getFormatted() C
last analyzed 2020-12-09 13:47 UTC

↳ Parent: IdentityNumberFormatter

Complexity

Conditions	13
Paths	18

Size

Total Lines	45
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	13
eloc	24
c	1
b	0
f	0
nc	18
nop	0
dl	0
loc	45
rs	6.6166

How to fix Complexity

<?php

namespace Olssonm\IdentityNumber;

/**
 * Handles the identity number formatting
 */
class IdentityNumberFormatter
{

    /**
     * Set value
     *
     * @var string
     */
    private $value;

    /**
     * Number of characters
     *
     * @var integer
     */
    private $characters;

    /**
     * If hyphens is allowed
     *
     * @var boolean
     */
    private $useHyphen;

    /**
     * What type of hyphen to use ("-"/+)
     *
     * @var string
     */
    private $typeHyphen = '-';

    /**
     * Format the personal identity number to make validation easier
     *
     * @param  string   $value          the input value
     * @param  int      $characters     number of characters
     * @param  bool     $useHyphen      if hyphens should be used
     * @return void
     */
    public function __construct($value, $characters, $useHyphen = false)
    {
        $this->value = $value;
        $this->characters = $characters;
        $this->useHyphen = $useHyphen;
    }

    /**
     * Clean the value-string from unwanted characters
     *
     * @return \Olssonm\IdentityNumber\IdentityNumberFormatter
     */
    public function clean()
    {
        // Clean string from invalid values
        $pattern = '0123456789-+';
        $this->value = preg_replace("/[^" . preg_quote($pattern, "/") . "]/", '', $this->value);

        return $this;
    }

    /**
     * Retrieve the formatted personal identity number
     *
     * @return string   the personal identity number
     */
    public function getFormatted()
    {
        $value = $this->value;
        $characters = $this->characters;
        $useHyphen = $this->useHyphen;

        // Check if "+" is present, then use it as a hyphen
        if (strpos($value, '+') !== false) {
            $this->typeHyphen = '+';
        }

        // Remove hyphen
        $value = str_replace(['-', '+'], '', $value);

        if (strlen($value) != 12 && strlen($value) != 10) {
            return false;

        }

        if ($characters == 12 && strlen($value) == 10) {
            $value = 19 . $value;
        }

        if ($characters == 10 && strlen($value) == 12) {
            $newNumber = null;
            for ($i = 0; $i < strlen($value); $i++) {
                if ($i > 1) {
                    $newNumber .= $value[$i];
                }
            }
            $value = $newNumber;
        }

        // Insert hyphen if you need to
        if ($useHyphen == true) {

            $newNumber = null;
            for ($i = 0; $i < strlen($value); $i++) {
                $newNumber .= $value[$i];
                if ($i == strlen($value) - 5) {
                    $newNumber .= $this->typeHyphen;
                }
            }
            $value = $newNumber;
        }

        return $value;
    }
}


1			<?php
2
3			namespace Olssonm\IdentityNumber;
4
5			/**
6			* Handles the identity number formatting
7			*/
8			class IdentityNumberFormatter
9			{
10
11			/**
12			* Set value
13			*
14			* @var string
15			*/
16			private $value;
17
18			/**
19			* Number of characters
20			*
21			* @var integer
22			*/
23			private $characters;
24
25			/**
26			* If hyphens is allowed
27			*
28			* @var boolean
29			*/
30			private $useHyphen;
31
32			/**
33			* What type of hyphen to use ("-"/+)
34			*
35			* @var string
36			*/
37			private $typeHyphen = '-';
38
39			/**
40			* Format the personal identity number to make validation easier
41			*
42			* @param string $value the input value
43			* @param int $characters number of characters
44			* @param bool $useHyphen if hyphens should be used
45			* @return void
46			*/
47			public function __construct($value, $characters, $useHyphen = false)
48			{
49			$this->value = $value;
50			$this->characters = $characters;
51			$this->useHyphen = $useHyphen;
52			}
53
54			/**
55			* Clean the value-string from unwanted characters
56			*
57			* @return \Olssonm\IdentityNumber\IdentityNumberFormatter
58			*/
59			public function clean()
60			{
61			// Clean string from invalid values
62			$pattern = '0123456789-+';
63			$this->value = preg_replace("/[^" . preg_quote($pattern, "/") . "]/", '', $this->value);
64
65			return $this;
66			}
67
68			/**
69			* Retrieve the formatted personal identity number
70			*
71			* @return string the personal identity number
72			*/
73			public function getFormatted()
74			{
75			$value = $this->value;
76			$characters = $this->characters;
77			$useHyphen = $this->useHyphen;
78
79			// Check if "+" is present, then use it as a hyphen
80			if (strpos($value, '+') !== false) {
81			$this->typeHyphen = '+';
82			}
83
84			// Remove hyphen
85			$value = str_replace(['-', '+'], '', $value);
86
87			if (strlen($value) != 12 && strlen($value) != 10) {
88			return false;
			0 ignored issues – show Bug Best Practice introduced 2020-09-10 09:29 UTC by Report Bug Copy Issue Report The expression `return false` returns the type `false` which is incompatible with the documented return type `string`. Loading history...
89			}
90
91			if ($characters == 12 && strlen($value) == 10) {
92			$value = 19 . $value;
93			}
94
95			if ($characters == 10 && strlen($value) == 12) {
96			$newNumber = null;
97			for ($i = 0; $i < strlen($value); $i++) {
98			if ($i > 1) {
99			$newNumber .= $value[$i];
100			}
101			}
102			$value = $newNumber;
103			}
104
105			// Insert hyphen if you need to
106			if ($useHyphen == true) {
			0 ignored issues – show Coding Style Best Practice introduced 2020-09-10 09:29 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
107			$newNumber = null;
108			for ($i = 0; $i < strlen($value); $i++) {
109			$newNumber .= $value[$i];
110			if ($i == strlen($value) - 5) {
111			$newNumber .= $this->typeHyphen;
112			}
113			}
114			$value = $newNumber;
115			}
116
117			return $value;
118			}
119			}
120

olssonm / identity-number

IdentityNumberFormatter::getFormatted() C last analyzed 2020-12-09 13:47 UTC

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like

IdentityNumberFormatter::getFormatted() C
last analyzed 2020-12-09 13:47 UTC