Oliverde8\PhpEtlBundle\Etl\Operation\Cleanup\DeleteEntityForOldExecutionOperation

Complexity

Total Complexity

2

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	processData()	0	9	1
A	__construct()	0	3	1

<?php


namespace Oliverde8\PhpEtlBundle\Etl\Operation\Cleanup;


use Doctrine\ORM\EntityManagerInterface;
use Oliverde8\Component\PhpEtl\ChainOperation\AbstractChainOperation;
use Oliverde8\Component\PhpEtl\Item\ItemInterface;
use Oliverde8\PhpEtlBundle\Entity\EtlExecution;

class DeleteEntityForOldExecutionOperation extends AbstractChainOperation
{
    /** @var EntityManagerInterface  */
    protected EntityManagerInterface $em;

    /**
     * DeleteEntityForOldExecutionOperation constructor.
     * @param EntityManagerInterface $em
     */
    public function __construct(EntityManagerInterface $em)
    {
        $this->em = $em;
    }

    protected function processData(ItemInterface $item, array &$context)

The parameter $context is not used and could be removed.

    {
        /** @var EtlExecution $entity */
        $entity = $item->getData();

The method getData() does not exist on Oliverde8\Component\PhpEtl\Item\ItemInterface. It seems like you code against a sub-type of Oliverde8\Component\PhpEtl\Item\ItemInterface such as Oliverde8\Component\PhpEtl\Item\DataItemInterface.

        $this->em->remove($entity);
        $this->em->flush();
        // Method is currently deprecated but has been un-deprecated it doctrine 3.
        $this->em->detach($entity);

The function Doctrine\Persistence\ObjectManager::detach() has been deprecated: Detach operation is deprecated and will be removed in Persistence 2.0. Please use {@see ObjectManager::clear()} instead.

    }

}